-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor XContentType to mediaType #721
Merged
Hailong-am
merged 1 commit into
opensearch-project:main
from
Hailong-am:fix_core/media_type
Jul 26, 2023
Merged
Refactor XContentType to mediaType #721
Hailong-am
merged 1 commit into
opensearch-project:main
from
Hailong-am:fix_core/media_type
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
xluo-aws,
gaobinlong,
SuZhou-Joe,
zhichao-aws,
yuye-aws and
zhongnansu
as code owners
July 25, 2023 05:51
gaobinlong
approved these changes
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
============================================
+ Coverage 61.84% 66.19% +4.35%
- Complexity 114 253 +139
============================================
Files 73 39 -34
Lines 2495 1698 -797
Branches 266 158 -108
============================================
- Hits 1543 1124 -419
+ Misses 775 456 -319
+ Partials 177 118 -59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yuye-aws
approved these changes
Jul 26, 2023
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-721-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d0a322cb518a5294207b954f8877da6b15629338
# Push it to GitHub
git push --set-upstream origin backport/backport-721-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x Then, create a pull request where the |
Hailong-am
added a commit
to Hailong-am/notifications
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit d0a322c)
Hailong-am
added a commit
that referenced
this pull request
Aug 7, 2023
* Fix core XcontentFactory refactor (#732) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 216dfcb) * Refactor XContentType to mediaType (#721) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit d0a322c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
opensearch-project/OpenSearch#8636
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.