[Backport 2.x] Fix core XcontentFactory refactor #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 216dfcb)
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit d0a322c)
Codecov Report
@@ Coverage Diff @@
## 2.x #734 +/- ##
=========================================
Coverage 65.77% 65.77%
Complexity 253 253
=========================================
Files 39 39
Lines 1677 1677
Branches 158 158
=========================================
Hits 1103 1103
Misses 456 456
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. |
gaobinlong
approved these changes
Aug 7, 2023
zhichao-aws
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 216dfcb from #732
Backport d0a322c from #721