[Refactor] MediaTypeParser to MediaTypeParserRegistry

[nknize]

Refactors the static MediaTypeParser utility to a dynamic registry to support registration of new MediaType definitions. This is a next step to decoupling the x-content library from core classes in the server module to support modularity and cloud or serverless implementations.

relates #5910
relates #8110

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/19933/
• CommitID: 614b0ca
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/19966/
• CommitID: 2b50552
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating

• URL: https://build.ci.opensearch.org/job/gradle-check/19984/
• CommitID: 2b50552
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #8636 (c7eacc4) into main (3ee4292) will decrease coverage by 0.18%.
The diff coverage is 69.79%.

@@             Coverage Diff              @@
##               main    #8636      +/-   ##
============================================
- Coverage     71.14%   70.96%   -0.18%     
+ Complexity    57214    57172      -42     
============================================
  Files          4757     4757              
  Lines        269804   269823      +19     
  Branches      39454    39474      +20     
============================================
- Hits         191940   191471     -469     
- Misses        61716    62266     +550     
+ Partials      16148    16086      -62     

Files Changed	Coverage Δ
...ch/plugin/noop/action/bulk/RestNoopBulkAction.java	0.00% <0.00%> (ø)
...org/opensearch/action/bulk/BulkRequestBuilder.java	12.50% <0.00%> (ø)
...ensearch/action/bulk/TransportShardBulkAction.java	74.49% <0.00%> (-1.16%)	⬇️
...pensearch/action/update/TransportUpdateAction.java	4.57% <0.00%> (ø)
...ava/org/opensearch/action/update/UpdateHelper.java	73.68% <ø> (ø)
...org/opensearch/common/xcontent/XContentHelper.java	60.09% <ø> (+0.96%)	⬆️
...rch/extensions/rest/RestSendToExtensionAction.java	42.50% <0.00%> (ø)
...earch/index/reindex/ClientScrollableHitSource.java	83.60% <ø> (ø)
...ensearch/index/termvectors/TermVectorsService.java	17.22% <0.00%> (ø)
...st/action/admin/indices/RestCreateIndexAction.java	60.86% <0.00%> (ø)
... and 55 more

... and 431 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/20837/
• CommitID: c7eacc4

[monusingh-1]

Will this be backported to 2.x ?

[Yury-Fridlyand]

When CreateIndexRequest::mapping is called with non initiated MediaTypeParserRegistry, an NPE is thrown instead of IAE.

OpenSearch/client/rest-high-level/src/main/java/org/opensearch/client/indices/CreateIndexRequest.java

Lines 188 to 190 in 6786608

	public CreateIndexRequest mapping(Map<String, ?> source) {
	try {
	XContentBuilder builder = XContentFactory.contentBuilder(MediaTypeParserRegistry.getDefaultMediaType());

OpenSearch/libs/x-content/src/main/java/org/opensearch/common/xcontent/XContentFactory.java

Lines 132 to 136 in 6786608

	public static XContentBuilder contentBuilder(MediaType type) throws IOException {
	if (type instanceof XContentType) {
	return contentBuilder((XContentType) (type));
	}
	throw new IllegalArgumentException("Content type [" + type.getClass().getName() + "] not supported");

type.getClass() crashes on line 136 above ^, because type is null.

[vmmusings]

When CreateIndexRequest::mapping is called with non initiated MediaTypeParserRegistry, an NPE is thrown instead of IAE.

OpenSearch/client/rest-high-level/src/main/java/org/opensearch/client/indices/CreateIndexRequest.java

Lines 188 to 190 in 6786608

	public CreateIndexRequest mapping(Map<String, ?> source) {
	try {
	XContentBuilder builder = XContentFactory.contentBuilder(MediaTypeParserRegistry.getDefaultMediaType());

OpenSearch/libs/x-content/src/main/java/org/opensearch/common/xcontent/XContentFactory.java

Lines 132 to 136 in 6786608

	public static XContentBuilder contentBuilder(MediaType type) throws IOException {
	if (type instanceof XContentType) {
	return contentBuilder((XContentType) (type));
	}
	throw new IllegalArgumentException("Content type [" + type.getClass().getName() + "] not supported");

type.getClass() crashes on line 136 above ^, because type is null.

@nknize Whats the reason for removing default media type and introducing a new static function to set it up?

[nknize]

@nknize Whats the reason for removing default media type and introducing a new static function to set it up?

Defaults are still there. The registry needs to be initialized.

The static Singleton was refactored so the core is not tightly coupled to the XContentType enum. This way downstream plugins can dynamically register a custom media type.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8636-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f8e0cd3de219dee302788a3616ec33835055e5f
# Push it to GitHub
git push --set-upstream origin backport/backport-8636-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8636-to-2.x.