Backport from 2.11 to 2.x #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#1586) * support step size for embedding model which outputs less embeddings Signed-off-by: Yaliang Wu <[email protected]> * tune parameter name Signed-off-by: Yaliang Wu <[email protected]> * fine tune processed doc to always respect step size Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]>
rbhavna
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1728 +/- ##
============================================
+ Coverage 80.82% 80.84% +0.01%
- Complexity 4220 4223 +3
============================================
Files 404 404
Lines 16994 17007 +13
Branches 1819 1821 +2
============================================
+ Hits 13736 13749 +13
Misses 2545 2545
Partials 713 713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
approved these changes
Dec 1, 2023
dhrubo-os
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #1586 and #1587 from 2.11 to 2.x
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.