validate step size

[ylwu-amzn]

Description

Validate step size
This is to address comments from this PR #1586

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #1587 (d418c37) into 2.11 (073b372) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               2.11    #1587      +/-   ##
============================================
- Coverage     80.00%   79.94%   -0.06%     
+ Complexity     2461     2460       -1     
============================================
  Files           197      197              
  Lines          9825     9829       +4     
  Branches        991      992       +1     
============================================
- Hits           7860     7858       -2     
- Misses         1497     1500       +3     
- Partials        468      471       +3     

Flag	Coverage Δ
ml-commons	79.94% <100.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ine/algorithms/remote/RemoteConnectorExecutor.java	90.47% <100.00%> (+1.00%)	⬆️

... and 4 files with indirect coverage changes

[krishna-ggk]

1. parseInt can throw exception as well - can we handle that too?
2. I understand it is param for one type of connector, but should it be more generalized and property of connector?

[ylwu-amzn]

1. It should ok to not handle, it will throw exception and will not crash the service. User should always follow our blueprint, sample blueprint https://github.com/opensearch-project/ml-commons/blob/2.x/docs/remote_inference_blueprints/bedrock_connector_anthropic_claude_blueprint.md. We will publish a new blueprint for multi-modal one soon.
2. Parameters map is one property of connector. This step size is just one parameter in it.

[krishna-ggk]

Parameters map is one property of connector. This step size is just one parameter in it.

I don’t see input_docs_processed_step_size in blueprint - probably I still didn’t understand this clearly. Shouldn't this be generalized param we extract?

17:15
Wouldn’t it be different param we need to check for different connector? The code currently is in RemoteConnectorExecutor.java (generic)

[opensearch-trigger-bot]

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1587-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5da2d91cb8b54c37281c15a5f7ee0d533c1cc1a0
# Push it to GitHub
git push --set-upstream origin backport/backport-1587-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1587-to-main.