[Backport 2.x] Fix no model show up when search a model #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fix: reset to page 1 after name or state search Signed-off-by: Lin Wang <[email protected]> * refactor: remove unnecessary act call Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 24aa9df)
Codecov Report
@@ Coverage Diff @@
## 2.x #242 +/- ##
==========================================
+ Coverage 78.32% 78.64% +0.31%
==========================================
Files 20 20
Lines 383 384 +1
Branches 75 76 +1
==========================================
+ Hits 300 302 +2
Misses 60 60
+ Partials 23 22 -1 |
wanglam
approved these changes
Aug 2, 2023
wanglam
added a commit
that referenced
this pull request
Nov 16, 2023
* Increment version to 2.8.0.0 (#169) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * chore: update husky to 8.0.3 to avoid use execa (#160) (#189) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 6a3faee) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.8.0 (#190) (#191) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit f2b701b) Co-authored-by: Lin Wang <[email protected]> * feat: remove experiment warning banner (#194) (#195) * feat: remove experiment warning banner Signed-off-by: Lin Wang <[email protected]> * doc: update release notes for remove experiment banner Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 0ef4753) Co-authored-by: Lin Wang <[email protected]> * feat: enable ml-commons-dashboards plugin by default (#200) (#201) * feat: enable ml-commons-dashboards plugin by default Signed-off-by: Lin Wang <[email protected]> * feat: update release notes for enable plugin by default Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit a1cb7de) Co-authored-by: Lin Wang <[email protected]> * Revert remove experiment banner and enable by default (#203) (#204) * Revert "feat: enable ml-commons-dashboards plugin by default (#200)" This reverts commit a1cb7de. Signed-off-by: Lin Wang <[email protected]> * Revert "feat: remove experiment warning banner (#194)" This reverts commit 0ef4753. Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 31df7d4) Co-authored-by: Lin Wang <[email protected]> * remove background for dark mode to fix #206 (#209) (#212) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 2bc3f38) Co-authored-by: Lin Wang <[email protected]> * Fix ml document link address (#210) (#213) * update to correct machine learning document address to fix #208 Signed-off-by: Lin Wang <[email protected]> * fix: update link in deployment table empty screen Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 7a33d01) Co-authored-by: Lin Wang <[email protected]> * feat: open external link in blank page (#211) (#214) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit e2825c4) Co-authored-by: Lin Wang <[email protected]> * Increment version to 2.9.0.0 (#222) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * feat: exclude remote model for admin UI (#225) (#228) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit ba01d34) Co-authored-by: Lin Wang <[email protected]> * Revert "Revert remove experiment banner and enable by default (#203)" (#229) (#231) * Revert "Revert remove experiment banner and enable by default (#203)" This reverts commit 31df7d4. Signed-off-by: Lin Wang <[email protected]> * doc: remove release update for 2.8.0 Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 2caf020) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.9.0 (#232) (#233) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 02e80a9) Co-authored-by: Lin Wang <[email protected]> * Add source field to distinguish local and external model (#239) (#240) * Revert "feat: exclude remote model for admin UI (#225)" This reverts commit ba01d34. Signed-off-by: Lin Wang <[email protected]> * feat: add source field to distinguish local and external model Signed-off-by: Lin Wang <[email protected]> * feat: add miss display words Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 63c7a5a) Co-authored-by: Lin Wang <[email protected]> * Fix no model show up when search a model (#238) (#242) * fix: reset to page 1 after name or state search Signed-off-by: Lin Wang <[email protected]> * refactor: remove unnecessary act call Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 24aa9df) Co-authored-by: Lin Wang <[email protected]> * Feat mitigate to oui style variables (#227) (#246) * feat: remove customized font size and font weight Signed-off-by: Lin Wang <[email protected]> * feat: update color to $ouiLinkColor Signed-off-by: Lin Wang <[email protected]> * feat: remove white background for refresh interval Signed-off-by: Lin Wang <[email protected]> * remove ace theme Signed-off-by: Lin Wang <[email protected]> * refactor: update <b> to <strong> Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 3aa8eaf) Co-authored-by: Lin Wang <[email protected]> * feat: support external models in deployed model list (#248) (#251) * feat: support external models in deployed model list Signed-off-by: Lin Wang <[email protected]> * refactor: update name to required Signed-off-by: Lin Wang <[email protected]> * fix: connector index not found Signed-off-by: Lin Wang <[email protected]> * refactor: update options filter with normal string[] value Signed-off-by: Lin Wang <[email protected]> * fix: hits not defined Signed-off-by: Lin Wang <[email protected]> * fix: update wording Signed-off-by: Lin Wang <[email protected]> * fix: connector id not exists in all connectors Signed-off-by: Lin Wang <[email protected]> * fix: show models when failed to load all external connectors Signed-off-by: Lin Wang <[email protected]> * feat: update deployed models title to models Signed-off-by: Lin Wang <[email protected]> * refactor: remove unused code in model connector filter Signed-off-by: Lin Wang <[email protected]> * feat: address PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc3810b) Co-authored-by: Lin Wang <[email protected]> * update preview panel for external models (#252) (#253) * feat: update preview panel for external models Signed-off-by: tygao <[email protected]> * feat: update preview panel for external models Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 9bbd25f) Co-authored-by: raintygao <[email protected]> * Increment version to 2.10.0.0 (#237) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * feat: update ui component and use fallback (#254) (#256) Signed-off-by: tygao <[email protected]> * feat: replace dash with em dash (#255) (#257) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit b817d98) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.10 (#258) (#259) * doc: add release notes for 2.10 Signed-off-by: tygao <[email protected]> * doc: append prs Signed-off-by: tygao <[email protected]> * doc: separate prs Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit db0003d) Co-authored-by: tygao <[email protected]> * Increment version to 2.11.0.0 (#265) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * doc: add release notes for 2.11.0.0 (#276) (#277) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc2d58e) Co-authored-by: Lin Wang <[email protected]> * Onboard jenkins build docker image to ml-commons-dashboards github ci checks 2.x (#281) Signed-off-by: Peter Zhu <[email protected]> * Increment version to 2.12.0.0 (#279) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> --------- Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: raintygao <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 24aa9df from #238