Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong document link #208

Closed
ylwu-amzn opened this issue Jun 6, 2023 · 1 comment · Fixed by #210
Closed

[BUG] Wrong document link #208

ylwu-amzn opened this issue Jun 6, 2023 · 1 comment · Fixed by #210
Assignees
@wanglam
Labels
bug Something isn't working v2.9.0

Comments

@ylwu-amzn
Copy link

Screenshot 2023-06-06 at 4 23 56 PM

The Machine Learning Documentation is an invalid URL. Should change to https://opensearch.org/docs/latest/ml-commons-plugin/ml-dashboard/
@ylwu-amzn ylwu-amzn added bug Something isn't working untriaged labels Jun 6, 2023
@wanglam
Copy link
Collaborator

wanglam commented Jun 7, 2023

Hi @ylwu-amzn , Thank you for reporting this issue. This link was provided by @Naarcha-AWS at the first release of the admin UI. As I remember, there was a redirect from current URL to https://opensearch.org/docs/latest/ml-commons-plugin/ml-dashboard/ . @Naarcha-AWS Could you help me check why this redirect not work? I think we can update the link to the correct address. So we don't need to redirect anymore in the future version.

@wanglam wanglam added the v2.9.0 label Jun 7, 2023
@wanglam wanglam self-assigned this Jun 8, 2023
wanglam added a commit to wanglam/ml-commons-dashboards that referenced this issue Jun 9, 2023
@wanglam
update to correct machine learning document address to fix opensearch…
3870422 
…-project#208

Signed-off-by: Lin Wang <[email protected]>
@wanglam wanglam removed the untriaged label Jun 9, 2023
Naarcha-AWS added a commit to opensearch-project/documentation-website that referenced this issue Jun 9, 2023
@Naarcha-AWS
Add redirect for ML Dashboard
a7de9ff 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS mentioned this issue Jun 9, 2023
Merged
1 task
Naarcha-AWS added a commit to opensearch-project/documentation-website that referenced this issue Jun 9, 2023
@Naarcha-AWS
Add redirect for ML Dashboard (#4294)
a01ef06 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot pushed a commit to opensearch-project/documentation-website that referenced this issue Jun 9, 2023
@github-actions
Add redirect for ML Dashboard (#4294)
2ac176d 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit a01ef06)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit to opensearch-project/documentation-website that referenced this issue Jun 9, 2023
@github-actions
Add redirect for ML Dashboard (#4294)
55835df 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit a01ef06)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit to opensearch-project/documentation-website that referenced this issue Jun 9, 2023
@opensearch-trigger-bot @github-actions
Add redirect for ML Dashboard (#4294) (#4296)
3717380 
Relates to issue opensearch-project/ml-commons-dashboards#208


(cherry picked from commit a01ef06)

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit to opensearch-project/documentation-website that referenced this issue Jun 9, 2023
@opensearch-trigger-bot @github-actions
Add redirect for ML Dashboard (#4294) (#4295)
4192109 
Relates to issue opensearch-project/ml-commons-dashboards#208


(cherry picked from commit a01ef06)

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@wanglam wanglam mentioned this issue Jun 13, 2023
Merged
wanglam added a commit that referenced this issue Jun 14, 2023
@wanglam
Fix ml document link address (#210)
7a33d01 
* update to correct machine learning document address to fix #208

Signed-off-by: Lin Wang <[email protected]>

* fix: update link in deployment table empty screen

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 14, 2023
@wanglam @github-actions
Fix ml document link address (#210)
9a18c59 
* update to correct machine learning document address to fix #208

Signed-off-by: Lin Wang <[email protected]>

* fix: update link in deployment table empty screen

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 7a33d01)
wanglam added a commit that referenced this issue Jun 14, 2023
@opensearch-trigger-bot @wanglam
Fix ml document link address (#210) (#213)
5e39ffc 
* update to correct machine learning document address to fix #208

Signed-off-by: Lin Wang <[email protected]>

* fix: update link in deployment table empty screen

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 7a33d01)

Co-authored-by: Lin Wang <[email protected]>
vagimeli pushed a commit to opensearch-project/documentation-website that referenced this issue Jun 14, 2023
@Naarcha-AWS @vagimeli
Add redirect for ML Dashboard (#4294)
45e4d3d 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
vagimeli pushed a commit to opensearch-project/documentation-website that referenced this issue Aug 24, 2023
@Naarcha-AWS @vagimeli
Add redirect for ML Dashboard (#4294)
bf49967 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this issue Oct 31, 2023
@Naarcha-AWS @harshavamsi
Add redirect for ML Dashboard (opensearch-project#4294)
e990b6a 
Relates to issue opensearch-project/ml-commons-dashboards#208

Signed-off-by: Naarcha-AWS <[email protected]>
wanglam added a commit that referenced this issue Nov 16, 2023
@wanglam @opensearch-trigger-bot
@opensearch-ci-bot @raintygao @peterzhuamazon
Merge 2.x to model registry (#289)
54f8603 
* Increment version to 2.8.0.0 (#169)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* chore: update husky to 8.0.3 to avoid use execa (#160) (#189)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 6a3faee)

Co-authored-by: Lin Wang <[email protected]>

* doc: add release notes for 2.8.0 (#190) (#191)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit f2b701b)

Co-authored-by: Lin Wang <[email protected]>

* feat: remove experiment warning banner (#194) (#195)

* feat: remove experiment warning banner

Signed-off-by: Lin Wang <[email protected]>

* doc: update release notes for remove experiment banner

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 0ef4753)

Co-authored-by: Lin Wang <[email protected]>

* feat: enable ml-commons-dashboards plugin by default (#200) (#201)

* feat: enable ml-commons-dashboards plugin by default

Signed-off-by: Lin Wang <[email protected]>

* feat: update release notes for enable plugin by default

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit a1cb7de)

Co-authored-by: Lin Wang <[email protected]>

* Revert remove experiment banner and enable by default (#203) (#204)

* Revert "feat: enable ml-commons-dashboards plugin by default (#200)"

This reverts commit a1cb7de.

Signed-off-by: Lin Wang <[email protected]>

* Revert "feat: remove experiment warning banner (#194)"

This reverts commit 0ef4753.

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 31df7d4)

Co-authored-by: Lin Wang <[email protected]>

* remove background for dark mode to fix #206 (#209) (#212)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 2bc3f38)

Co-authored-by: Lin Wang <[email protected]>

* Fix ml document link address (#210) (#213)

* update to correct machine learning document address to fix #208

Signed-off-by: Lin Wang <[email protected]>

* fix: update link in deployment table empty screen

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 7a33d01)

Co-authored-by: Lin Wang <[email protected]>

* feat: open external link in blank page (#211) (#214)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit e2825c4)

Co-authored-by: Lin Wang <[email protected]>

* Increment version to 2.9.0.0 (#222)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* feat: exclude remote model for admin UI (#225) (#228)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit ba01d34)

Co-authored-by: Lin Wang <[email protected]>

* Revert "Revert remove experiment banner and enable by default (#203)" (#229) (#231)

* Revert "Revert remove experiment banner and enable by default (#203)"

This reverts commit 31df7d4.

Signed-off-by: Lin Wang <[email protected]>

* doc: remove release update for 2.8.0

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 2caf020)

Co-authored-by: Lin Wang <[email protected]>

* doc: add release notes for 2.9.0 (#232) (#233)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 02e80a9)

Co-authored-by: Lin Wang <[email protected]>

* Add source field to distinguish local and external model (#239) (#240)

* Revert "feat: exclude remote model for admin UI (#225)"

This reverts commit ba01d34.

Signed-off-by: Lin Wang <[email protected]>

* feat: add source field to distinguish local and external model

Signed-off-by: Lin Wang <[email protected]>

* feat: add miss display words

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 63c7a5a)

Co-authored-by: Lin Wang <[email protected]>

* Fix no model show up when search a model (#238) (#242)

* fix: reset to page 1 after name or state search

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unnecessary act call

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 24aa9df)

Co-authored-by: Lin Wang <[email protected]>

* Feat mitigate to oui style variables (#227) (#246)

* feat: remove customized font size and font weight

Signed-off-by: Lin Wang <[email protected]>

* feat: update color to $ouiLinkColor

Signed-off-by: Lin Wang <[email protected]>

* feat: remove white background for refresh interval

Signed-off-by: Lin Wang <[email protected]>

* remove ace theme

Signed-off-by: Lin Wang <[email protected]>

* refactor: update <b> to <strong>

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 3aa8eaf)

Co-authored-by: Lin Wang <[email protected]>

* feat: support external models in deployed model list (#248) (#251)

* feat: support external models in deployed model list

Signed-off-by: Lin Wang <[email protected]>

* refactor: update name to required

Signed-off-by: Lin Wang <[email protected]>

* fix: connector index not found

Signed-off-by: Lin Wang <[email protected]>

* refactor: update options filter with normal string[] value

Signed-off-by: Lin Wang <[email protected]>

* fix: hits not defined

Signed-off-by: Lin Wang <[email protected]>

* fix: update wording

Signed-off-by: Lin Wang <[email protected]>

* fix: connector id not exists in all connectors

Signed-off-by: Lin Wang <[email protected]>

* fix: show models when failed to load all external connectors

Signed-off-by: Lin Wang <[email protected]>

* feat: update deployed models title to models

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unused code in model connector filter

Signed-off-by: Lin Wang <[email protected]>

* feat: address PR comments

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit cc3810b)

Co-authored-by: Lin Wang <[email protected]>

* update preview panel for external models (#252) (#253)

* feat: update preview panel for external models

Signed-off-by: tygao <[email protected]>

* feat: update preview panel for external models

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
(cherry picked from commit 9bbd25f)

Co-authored-by: raintygao <[email protected]>

* Increment version to 2.10.0.0 (#237)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* feat: update ui component and use fallback (#254) (#256)

Signed-off-by: tygao <[email protected]>

* feat: replace dash with em dash (#255) (#257)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit b817d98)

Co-authored-by: Lin Wang <[email protected]>

* doc: add release notes for 2.10 (#258) (#259)

* doc: add release notes for 2.10

Signed-off-by: tygao <[email protected]>

* doc: append prs

Signed-off-by: tygao <[email protected]>

* doc: separate prs

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
(cherry picked from commit db0003d)

Co-authored-by: tygao <[email protected]>

* Increment version to 2.11.0.0 (#265)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* doc: add release notes for 2.11.0.0 (#276) (#277)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit cc2d58e)

Co-authored-by: Lin Wang <[email protected]>

* Onboard jenkins build docker image to ml-commons-dashboards github ci checks 2.x (#281)

Signed-off-by: Peter Zhu <[email protected]>

* Increment version to 2.12.0.0 (#279)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

---------

Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: raintygao <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wanglam wanglam

Labels
bug Something isn't working v2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ml document link address wanglam/ml-commons-dashboards
2 participants
@wanglam @ylwu-amzn