Feat mitigate to oui style variables #227

wanglam · 2023-07-03T02:33:20Z

Description

This PR will remove all exists customized color and font style. Make sure all styles from oui or oui component.
This PR will fix #217

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ruanyl

Nice changes, approved!

codecov · 2023-07-03T02:40:59Z

Codecov Report

Merging #227 (a2eef3e) into main (24aa9df) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   78.64%   78.53%   -0.12%     
==========================================
  Files          20       20              
  Lines         384      382       -2     
  Branches       76       75       -1     
==========================================
- Hits          302      300       -2     
  Misses         60       60              
  Partials       22       22

see 3 files with indirect coverage changes

joshuarrrr

From the technical side, all these changes look great, thanks! Make sure to get final screenshots or demos validated by UX.

joshuarrrr · 2023-08-01T18:17:01Z

public/components/monitoring/model_deployment_table.tsx

@@ -98,8 +98,7 @@ export const ModelDeploymentTable = ({
            return (
              <EuiHealth className="ml-modelStatusCell" color="danger">
                <div className="eui-textTruncate">
-                  <span style={{ fontWeight: 600 }}>Not responding</span> on {planningNodesCount} of{' '}
-                  {planningNodesCount} nodes
+                  <b>Not responding</b> on {planningNodesCount} of {planningNodesCount} nodes


nit - I generally think we'd recommend  over  for semantic purposes, but realistically t shouldn't matter.

Will change to use 

joshuarrrr · 2023-08-01T18:20:41Z

public/ace-themes/sql_console.js

-
-import * as ace from 'brace';
-
-ace.define('ace/theme/sql_console', ['require', 'exports', 'module', 'ace/lib/dom'], function (


I may have missed in this PR where you were previously specifying use of this custom ace theme, but for consistency with OpenSearch Dashboards (particularly in dark mode), you should use the textmate theme in any ace/EuiCodeEditor component. See opensearch-project/OpenSearch-Dashboards#4609 for an example of similar cleanup in core.

Sure. Thank you. The code editor was been used in feature/model-registry branch. It's not been used in current application. Is that means we don't need to provide more scss files by using textmate theme?

Correct. OpenSearch Dashboards core specifically provides some style overrides for the EuiCodeEditor component if using the textmate theme and in dark mode.

Signed-off-by: Lin Wang <[email protected]>

* feat: remove customized font size and font weight Signed-off-by: Lin Wang <[email protected]> * feat: update color to $ouiLinkColor Signed-off-by: Lin Wang <[email protected]> * feat: remove white background for refresh interval Signed-off-by: Lin Wang <[email protected]> * remove ace theme Signed-off-by: Lin Wang <[email protected]> * refactor: update to Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 3aa8eaf)

* feat: remove customized font size and font weight Signed-off-by: Lin Wang <[email protected]> * feat: update color to $ouiLinkColor Signed-off-by: Lin Wang <[email protected]> * feat: remove white background for refresh interval Signed-off-by: Lin Wang <[email protected]> * remove ace theme Signed-off-by: Lin Wang <[email protected]> * refactor: update to Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 3aa8eaf) Co-authored-by: Lin Wang <[email protected]>

* Increment version to 2.8.0.0 (#169) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * chore: update husky to 8.0.3 to avoid use execa (#160) (#189) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 6a3faee) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.8.0 (#190) (#191) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit f2b701b) Co-authored-by: Lin Wang <[email protected]> * feat: remove experiment warning banner (#194) (#195) * feat: remove experiment warning banner Signed-off-by: Lin Wang <[email protected]> * doc: update release notes for remove experiment banner Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 0ef4753) Co-authored-by: Lin Wang <[email protected]> * feat: enable ml-commons-dashboards plugin by default (#200) (#201) * feat: enable ml-commons-dashboards plugin by default Signed-off-by: Lin Wang <[email protected]> * feat: update release notes for enable plugin by default Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit a1cb7de) Co-authored-by: Lin Wang <[email protected]> * Revert remove experiment banner and enable by default (#203) (#204) * Revert "feat: enable ml-commons-dashboards plugin by default (#200)" This reverts commit a1cb7de. Signed-off-by: Lin Wang <[email protected]> * Revert "feat: remove experiment warning banner (#194)" This reverts commit 0ef4753. Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 31df7d4) Co-authored-by: Lin Wang <[email protected]> * remove background for dark mode to fix #206 (#209) (#212) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 2bc3f38) Co-authored-by: Lin Wang <[email protected]> * Fix ml document link address (#210) (#213) * update to correct machine learning document address to fix #208 Signed-off-by: Lin Wang <[email protected]> * fix: update link in deployment table empty screen Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 7a33d01) Co-authored-by: Lin Wang <[email protected]> * feat: open external link in blank page (#211) (#214) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit e2825c4) Co-authored-by: Lin Wang <[email protected]> * Increment version to 2.9.0.0 (#222) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * feat: exclude remote model for admin UI (#225) (#228) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit ba01d34) Co-authored-by: Lin Wang <[email protected]> * Revert "Revert remove experiment banner and enable by default (#203)" (#229) (#231) * Revert "Revert remove experiment banner and enable by default (#203)" This reverts commit 31df7d4. Signed-off-by: Lin Wang <[email protected]> * doc: remove release update for 2.8.0 Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 2caf020) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.9.0 (#232) (#233) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 02e80a9) Co-authored-by: Lin Wang <[email protected]> * Add source field to distinguish local and external model (#239) (#240) * Revert "feat: exclude remote model for admin UI (#225)" This reverts commit ba01d34. Signed-off-by: Lin Wang <[email protected]> * feat: add source field to distinguish local and external model Signed-off-by: Lin Wang <[email protected]> * feat: add miss display words Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 63c7a5a) Co-authored-by: Lin Wang <[email protected]> * Fix no model show up when search a model (#238) (#242) * fix: reset to page 1 after name or state search Signed-off-by: Lin Wang <[email protected]> * refactor: remove unnecessary act call Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 24aa9df) Co-authored-by: Lin Wang <[email protected]> * Feat mitigate to oui style variables (#227) (#246) * feat: remove customized font size and font weight Signed-off-by: Lin Wang <[email protected]> * feat: update color to $ouiLinkColor Signed-off-by: Lin Wang <[email protected]> * feat: remove white background for refresh interval Signed-off-by: Lin Wang <[email protected]> * remove ace theme Signed-off-by: Lin Wang <[email protected]> * refactor: update to Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 3aa8eaf) Co-authored-by: Lin Wang <[email protected]> * feat: support external models in deployed model list (#248) (#251) * feat: support external models in deployed model list Signed-off-by: Lin Wang <[email protected]> * refactor: update name to required Signed-off-by: Lin Wang <[email protected]> * fix: connector index not found Signed-off-by: Lin Wang <[email protected]> * refactor: update options filter with normal string[] value Signed-off-by: Lin Wang <[email protected]> * fix: hits not defined Signed-off-by: Lin Wang <[email protected]> * fix: update wording Signed-off-by: Lin Wang <[email protected]> * fix: connector id not exists in all connectors Signed-off-by: Lin Wang <[email protected]> * fix: show models when failed to load all external connectors Signed-off-by: Lin Wang <[email protected]> * feat: update deployed models title to models Signed-off-by: Lin Wang <[email protected]> * refactor: remove unused code in model connector filter Signed-off-by: Lin Wang <[email protected]> * feat: address PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc3810b) Co-authored-by: Lin Wang <[email protected]> * update preview panel for external models (#252) (#253) * feat: update preview panel for external models Signed-off-by: tygao <[email protected]> * feat: update preview panel for external models Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 9bbd25f) Co-authored-by: raintygao <[email protected]> * Increment version to 2.10.0.0 (#237) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * feat: update ui component and use fallback (#254) (#256) Signed-off-by: tygao <[email protected]> * feat: replace dash with em dash (#255) (#257) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit b817d98) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.10 (#258) (#259) * doc: add release notes for 2.10 Signed-off-by: tygao <[email protected]> * doc: append prs Signed-off-by: tygao <[email protected]> * doc: separate prs Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit db0003d) Co-authored-by: tygao <[email protected]> * Increment version to 2.11.0.0 (#265) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * doc: add release notes for 2.11.0.0 (#276) (#277) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc2d58e) Co-authored-by: Lin Wang <[email protected]> * Onboard jenkins build docker image to ml-commons-dashboards github ci checks 2.x (#281) Signed-off-by: Peter Zhu <[email protected]> * Increment version to 2.12.0.0 (#279) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> --------- Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: raintygao <[email protected]> Co-authored-by: Peter Zhu <[email protected]>

wanglam added the backport 2.x label Jul 3, 2023

wanglam requested a review from joshuarrrr July 3, 2023 02:33

wanglam marked this pull request as ready for review July 3, 2023 02:33

wanglam requested review from ruanyl and raintygao as code owners July 3, 2023 02:33

wanglam mentioned this pull request Jul 3, 2023

Validate OUI theme compliance - phase 1 #217

Closed

8 tasks

ruanyl approved these changes Jul 3, 2023

View reviewed changes

wanglam added the v2.10.0 label Jul 7, 2023

joshuarrrr approved these changes Aug 1, 2023

View reviewed changes

wanglam added 5 commits August 3, 2023 11:08

feat: remove customized font size and font weight

313c245

Signed-off-by: Lin Wang <[email protected]>

feat: update color to $ouiLinkColor

36b3343

Signed-off-by: Lin Wang <[email protected]>

feat: remove white background for refresh interval

ee0d2b8

Signed-off-by: Lin Wang <[email protected]>

remove ace theme

26539ea

Signed-off-by: Lin Wang <[email protected]>

refactor: update to 

a2eef3e

Signed-off-by: Lin Wang <[email protected]>

wanglam force-pushed the feat-mitigate-to-oui-style-variables branch from 11d1a67 to a2eef3e Compare August 3, 2023 03:16

ruanyl approved these changes Aug 3, 2023

View reviewed changes

wanglam merged commit 3aa8eaf into opensearch-project:main Aug 23, 2023
6 checks passed

opensearch-trigger-bot bot mentioned this pull request Aug 23, 2023

[Backport 2.x] Feat mitigate to oui style variables #246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat mitigate to oui style variables #227

Feat mitigate to oui style variables #227

wanglam commented Jul 3, 2023

ruanyl left a comment

codecov bot commented Jul 3, 2023 •

edited

Loading

joshuarrrr left a comment

joshuarrrr Aug 1, 2023

wanglam Aug 2, 2023

joshuarrrr Aug 1, 2023

wanglam Aug 2, 2023

joshuarrrr Aug 2, 2023


		import * as ace from 'brace';

		ace.define('ace/theme/sql_console', ['require', 'exports', 'module', 'ace/lib/dom'], function (

Feat mitigate to oui style variables #227

Feat mitigate to oui style variables #227

Conversation

wanglam commented Jul 3, 2023

Description

Issues Resolved

ruanyl left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 3, 2023 • edited Loading

Codecov Report

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr Aug 1, 2023

Choose a reason for hiding this comment

wanglam Aug 2, 2023

Choose a reason for hiding this comment

joshuarrrr Aug 1, 2023

Choose a reason for hiding this comment

wanglam Aug 2, 2023

Choose a reason for hiding this comment

joshuarrrr Aug 2, 2023

Choose a reason for hiding this comment

codecov bot commented Jul 3, 2023 •

edited

Loading