Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add missing Core REST API endpoints #424

Closed
37 tasks done
Naarcha-AWS opened this issue Feb 23, 2022 · 7 comments · Fixed by #1094
Closed
37 tasks done

[DOC] Add missing Core REST API endpoints #424

Naarcha-AWS opened this issue Feb 23, 2022 · 7 comments · Fixed by #1094
Assignees
Labels
API Closed - Complete Issue: Work is done and associated PRs closed
Milestone

Comments

@Naarcha-AWS
Copy link
Collaborator

Naarcha-AWS commented Feb 23, 2022

Because the OpenSearch REST API documentation is no longer automated, we need to create a feature complete API reference, one the includes all endpoints, request bodies, and responses.

For reference on what ideal REST API reference page looks like, see the OpenSearch Create Index API.

List of missing endpoints

To assist in achieving this goal, I've put together a list of APIs that are missing, based on cross-referencing the old Open Distro API reference. NOTE: This list is not comprehensive and might not include all missing endpoints.

After the request and responses have been documented, please check off the API from this list.

Test API

  1. Install OpenSearch. We recommend using Docker with the a sample Docker compose file that disables the security plugin.
  2. After installation, run OpenSearch and log into Dashboards.
  3. Find the API test console. There, enter each API endpoint listed above with the correct request body. Upon successful execution, the response appears on the right column.

Time to complete

Each API endpoint should only take about 4 - 5 hours to test, document, and address any review feedback required. With 19 found undocumented endpoints, this assumes an average time to complete of 12 - 15 days.

@Naarcha-AWS Naarcha-AWS added enhancement New feature or request untriaged labels Feb 23, 2022
@Naarcha-AWS
Copy link
Collaborator Author

Looking at this issue and thinking, "That endpoint is already documented!" or "What about this endpoint?". Leave a comment and we'll add or remove endpoints to the list.

@bgdnlp
Copy link

bgdnlp commented Apr 20, 2022

As per #176, I think ingest pipelines are an undervalued feature that seems to be little known. Would it be possible to add some clear and straight forward documentation about it?

I'm talking about ingest pipelines and APIs.

I wasn't able to find any dedicated pages for that. There are some references, for example in the _reindex section, but there's no chapter that I could find that explains ingest pipeline or nodes, their role, and how it can replace Logstash for example. Which seems very useful to me, but I'm definitely no expert.

@lukas-vlcek
Copy link
Contributor

lukas-vlcek commented Apr 20, 2022

@bgdnlp I think there is basic documentation about Ingest APIs but I agree it is missing more detailed information including list of available ingest processors and their doc. (And yes I agree that ingest pipelines is a cool feature!)

@bgdnlp
Copy link

bgdnlp commented Apr 21, 2022

To add more details, in case it helps, what I'd like to see as a newcomer is

  • A page describing ingestion pipelines and how they can be an alternative to Logstash (I believe). Something like ElasticSearch docs. Maybe even some kind of howto like the AWS blog post where I first found out about this feature.
  • A mention and links to the above in the docs, wherever ingestion methods are presented, like here.
  • A comparison with Logstash. I know that Logstash is more feature rich and moving processing to nodes obviously can have consequences, but for simpler use cases not having to manage Logstash seems like a net win to me, so I'm not sure why it's not presented as an alternative. For example, the AWS page on data ingestion doesn't even mention it, neither does the FAQ. Which makes me think that maybe it's never a good choice.

What I mean is that if I didn't already know about it, if I looked at the documentation around OpenSearch as a newcomer I don't think I'd find it. ElasticSearch, yes, probably. But in OpenSearch it seems to be completely ignored for some reason. I hope it helps.

lukas-vlcek added a commit to lukas-vlcek/documentation-website that referenced this issue Apr 22, 2022
In this commit we are introducing a new section in REST API Reference for Nodes APIs.

We are adding documentation for "Nodes hot threads" and "Nodes info". Because Nodes APIs share common request parameters we also add more detailed section into parent index page (notice that the nodes-filter parameter was moved from "Cluster stats" page and was improved, and relevant links were updated).

There are more Nodes APIs that still need to be documented, this is just a good start.

We updated nav_order parameter for some pages as well.

Relevant ticket: opensearch-project#424

Signed-off-by: Lukáš Vlček <[email protected]>
@lukas-vlcek lukas-vlcek mentioned this issue Apr 22, 2022
1 task
@oridool
Copy link

oridool commented May 8, 2022

what about the missing snapshot endpoints ?
Specifically, can we use URL parameters in GET endpoint such as sort and from_sort_value mentioned here? https://www.elastic.co/guide/en/elasticsearch/reference/current/get-snapshot-api.html

@Naarcha-AWS
Copy link
Collaborator Author

@Steve-O-Murphy: Thanks for coming on board, Steve. Here is the list Rest APIs we'll get started:

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed enhancement New feature or request labels Aug 4, 2022
@Naarcha-AWS Naarcha-AWS added this to the 2022-Q3 milestone Aug 8, 2022
@cwillum
Copy link
Contributor

cwillum commented Aug 9, 2022

API to enable audit logs is in process. #746.

  • GET _plugins/_security/api/audit
  • PUT _plugins/_security/api/audit/config
  • PATCH _plugins/_security/api/audit

@Naarcha-AWS Naarcha-AWS changed the title Add missing REST API endpoints Add missing Core REST API endpoints Aug 12, 2022
@Naarcha-AWS Naarcha-AWS reopened this Sep 7, 2022
@ariamarble ariamarble self-assigned this Sep 19, 2022
@ariamarble ariamarble changed the title Add missing Core REST API endpoints [DOC] Add missing Core REST API endpoints Sep 19, 2022
@ariamarble ariamarble added API Closed - Complete Issue: Work is done and associated PRs closed and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Closed - Complete Issue: Work is done and associated PRs closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants