Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding documentation for dangling index api #1370

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Adding documentation for dangling index api #1370

merged 2 commits into from
Oct 4, 2022

Conversation

ariamarble
Copy link
Contributor

@ariamarble ariamarble commented Sep 30, 2022 •
edited
Loading

Signed-off-by: ariamarble [email protected]

Description

Adds documentation for dangling index api

Issues Resolved

#1271

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ariamarble ariamarble requested a review from a team as a code owner September 30, 2022 15:35
@ariamarble ariamarble self-assigned this Sep 30, 2022
@ariamarble ariamarble added backport 2.0 PR: Backport label for v2.0.x 4 - Doc review PR: Doc review in progress backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 labels Sep 30, 2022
@ariamarble
Copy link
Contributor Author

confirmed and tested

alicejw1
alicejw1 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just check if "indices" is ok to use/hard coded. otherwise replace with "indexes"

@hdhalter hdhalter mentioned this pull request Sep 30, 2022
Closed
37 tasks
JeffHuss
JeffHuss approved these changes Oct 3, 2022
View reviewed changes
Copy link

@JeffHuss JeffHuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariamarble ariamarble added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Oct 3, 2022
natebower
natebower reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariamarble Please see my comments and let me know if you have any questions. Thanks!

_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
_opensearch/rest-api/index-apis/dangling-index.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Oct 4, 2022
@ariamarble
made editorial changes
718e9f3 
Signed-off-by: ariamarble <[email protected]>
@ariamarble ariamarble merged commit 3720f19 into main Oct 4, 2022
@ariamarble ariamarble added the Closed - Complete Issue: Work is done and associated PRs closed label Oct 4, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
@ariamarble @github-actions
Adding documentation for dangling index api (#1370)
2efc454 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 4, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
@ariamarble @github-actions
Adding documentation for dangling index api (#1370)
8a42dda 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)
This was referenced Oct 4, 2022
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
@ariamarble @github-actions
Adding documentation for dangling index api (#1370)
b859bea 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
@ariamarble @github-actions
Adding documentation for dangling index api (#1370)
a0ec17c 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 4, 2022
Merged
ariamarble added a commit that referenced this pull request Oct 4, 2022
@opensearch-trigger-bot @ariamarble
Adding documentation for dangling index api (#1370) (#1411)
00c37f9 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)

Co-authored-by: Aria Marble <[email protected]>
ariamarble added a commit that referenced this pull request Oct 4, 2022
@opensearch-trigger-bot @ariamarble
Adding documentation for dangling index api (#1370) (#1410)
2c42274 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)

Co-authored-by: Aria Marble <[email protected]>
ariamarble added a commit that referenced this pull request Oct 4, 2022
@opensearch-trigger-bot @ariamarble
Adding documentation for dangling index api (#1370) (#1409)
5c97daf 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)

Co-authored-by: Aria Marble <[email protected]>
ariamarble added a commit that referenced this pull request Oct 4, 2022
@opensearch-trigger-bot @ariamarble
Adding documentation for dangling index api (#1370) (#1408)
80823bf 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit 3720f19)

Co-authored-by: Aria Marble <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Oct 6, 2022
@ariamarble @Naarcha-AWS
Adding documentation for dangling index api (#1370)
8af5217 
* adding documentation for dangling index api

Signed-off-by: ariamarble <[email protected]>

* made editorial changes

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the issue1271 branch December 13, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@JeffHuss JeffHuss JeffHuss approved these changes

@alicejw1 alicejw1 alicejw1 approved these changes

Assignees

@ariamarble ariamarble

Labels
backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 Closed - Complete Issue: Work is done and associated PRs closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariamarble @alicejw1 @natebower @JeffHuss