Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ism rollup to documentation #1371

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Add ism rollup to documentation #1371

merged 6 commits into from
Oct 5, 2022

Conversation

ariamarble
Copy link
Contributor

Signed-off-by: ariamarble [email protected]

Description

Adds ism rollup to documentation

Issues Resolved

#1270

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ariamarble ariamarble requested a review from a team as a code owner September 30, 2022 16:35
@ariamarble ariamarble self-assigned this Sep 30, 2022
@ariamarble ariamarble added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x 4 - Doc review PR: Doc review in progress backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 labels Sep 30, 2022
@ariamarble
Copy link
Contributor Author

tested and confirmed

Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
@ariamarble
Copy link
Contributor Author

@kolchfa-aws can you re-review the field parameters? thanks!

_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
@ariamarble ariamarble merged commit fa2535a into main Oct 5, 2022
@ariamarble ariamarble added Closed - Complete Issue: Work is done and associated PRs closed and removed 4 - Doc review PR: Doc review in progress Closed - Complete Issue: Work is done and associated PRs closed labels Oct 5, 2022
@Naarcha-AWS Naarcha-AWS added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 and removed backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 labels Oct 5, 2022
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1371-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fa2535ab9d7890b10577713fa000e1fef2328816
# Push it to GitHub
git push --set-upstream origin backport/backport-1371-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1371-to-1.3.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)
ariamarble added a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)

Co-authored-by: Aria Marble <[email protected]>
ariamarble added a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)

Co-authored-by: Aria Marble <[email protected]>
ariamarble added a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)

Co-authored-by: Aria Marble <[email protected]>
ariamarble added a commit that referenced this pull request Oct 5, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
(cherry picked from commit fa2535a)

Co-authored-by: Aria Marble <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Oct 6, 2022
* add ism rollup to documentation

Signed-off-by: ariamarble <[email protected]>

* made suggested changes

Signed-off-by: ariamarble <[email protected]>

* added field descriptions

Signed-off-by: ariamarble <[email protected]>

* added further requested changes

Signed-off-by: ariamarble <[email protected]>

* tech review updates

Signed-off-by: ariamarble <[email protected]>

* minor spelling changes and link update

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the issue1270 branch December 13, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants