[Log Explorer] Remove top level tabs #970

mengweieric · 2023-09-06T00:50:50Z

Description

This is part of the campaign to match look and feel with data explorer and align with the long term goal of supporting s3 datasource.

This is the step 1 of removing tabs where a default tab with name 'OBSERVABILITY-DEFAULT-TAB' is added and button to add new tab as well as all related UIs are removed. This PR contains minimal changes to remove tab for step 1. The second step after this will be removing the default tab completely and changes the code to drop tabId checking all over the places.

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric <[email protected]>

YANG-DB · 2023-09-06T17:23:24Z

@mengweieric
can you please add the github issue containing the User Experience so it would be clearer to understand the UX workflow ?

mengweieric · 2023-09-06T18:04:22Z

@mengweieric can you please add the github issue containing the User Experience so it would be clearer to understand the UX workflow ?

Added the issue, please check

ps48 · 2023-09-07T16:29:16Z

public/components/event_analytics/explorer/log_explorer.tsx

+        savedObjectId={savedObjectId}
+        tabCreatedTypes={tabCreatedTypes}
+        curSelectedTabId={curSelectedTabIdRef}
+        http={http}


Do we need http to be passed here can we use import CoreRefs?

I just copied the entire component over for tab changes. But to your point, I've created the issue for tracking this as I saw there are around 7 - 8 references in explorer where changes required for this are kinda out of the scope of this PR. Later we can have campaign for this as I feel we need to also refactor some of the components to not
depend on http

joshuali925

minor comment

joshuali925 · 2023-09-07T18:38:38Z

common/constants/explorer.ts

 export const EVENT_ANALYTICS_DOCUMENTATION_URL =
  'https://opensearch.org/docs/latest/observability-plugin/event-analytics/';
 export const OPEN_TELEMETRY_LOG_CORRELATION_LINK =
  'https://opentelemetry.io/docs/reference/specification/logs/overview/#log-correlation';
+export const LOG_EXPLORER_BASE_PATH = 'observability-logs#/explorer/';


use ${observabilityLogsID} instead of observability-logs?

mengweieric · 2023-09-07T19:35:26Z

Will wait until after 2.10 branch to be cut.

* remove unused files Signed-off-by: Eric Wei <[email protected]> * missing snapshots Signed-off-by: Eric Wei <[email protected]> * minimal changes to remove log explorer tab Signed-off-by: Eric <[email protected]> * skip tab related tests Signed-off-by: Eric <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> * remove missed logging Signed-off-by: Eric <[email protected]> * add path to constant Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Eric <[email protected]>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: sumukhswamy <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Simeon Widdis <[email protected]>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: sumukhswamy <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Simeon Widdis <[email protected]> (cherry picked from commit 171acde)

mengweieric added 7 commits September 6, 2023 00:41

remove unused files

7b4ca0d

Signed-off-by: Eric Wei <[email protected]>

missing snapshots

79c1551

Signed-off-by: Eric Wei <[email protected]>

minimal changes to remove log explorer tab

f2d44f4

Signed-off-by: Eric <[email protected]>

skip tab related tests

111ff62

Signed-off-by: Eric <[email protected]>

update snapshots

1e93d3c

Signed-off-by: Eric <[email protected]>

remove missed logging

0747ad9

Signed-off-by: Eric <[email protected]>

add path to constant

d63d776

Signed-off-by: Eric <[email protected]>

mengweieric requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, vmmusings, Swiddis, penghuo, seankao-az and anirudha as code owners September 6, 2023 00:50

mengweieric linked an issue Sep 6, 2023 that may be closed by this pull request

[FEATURE] Explorer Tab Removal #973

Closed

Swiddis approved these changes Sep 6, 2023

View reviewed changes

ps48 reviewed Sep 7, 2023

View reviewed changes

joshuali925 approved these changes Sep 7, 2023

View reviewed changes

mengweieric merged commit dd50d8b into opensearch-project:main Sep 7, 2023

mengweieric deleted the feature/remove-top-level-tab branch September 7, 2023 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Log Explorer] Remove top level tabs #970

[Log Explorer] Remove top level tabs #970

mengweieric commented Sep 6, 2023 •

edited

Loading

YANG-DB commented Sep 6, 2023

mengweieric commented Sep 6, 2023

ps48 Sep 7, 2023

mengweieric Sep 7, 2023 •

edited

Loading

joshuali925 left a comment

joshuali925 Sep 7, 2023 •

edited

Loading

mengweieric commented Sep 7, 2023

[Log Explorer] Remove top level tabs #970

[Log Explorer] Remove top level tabs #970

Conversation

mengweieric commented Sep 6, 2023 • edited Loading

Description

Issues Resolved

Check List

YANG-DB commented Sep 6, 2023

mengweieric commented Sep 6, 2023

ps48 Sep 7, 2023

Choose a reason for hiding this comment

mengweieric Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

joshuali925 left a comment

Choose a reason for hiding this comment

joshuali925 Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

mengweieric commented Sep 7, 2023

mengweieric commented Sep 6, 2023 •

edited

Loading

mengweieric Sep 7, 2023 •

edited

Loading

joshuali925 Sep 7, 2023 •

edited

Loading