Add fallback to show if user does not have datasource API permissions #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
|
ps48
reviewed
Sep 15, 2023
| @@ -30,21 +31,29 @@ interface DatasourceDetails { | |||
| } | |||
|
|
|||
| export const DataSource = (props: any) => { | |||
| const { dataSource, pplService, http } = props; | |||
| const { dataSource, http } = props; | |||
There was a problem hiding this comment.
Do you want to usehttp from CoreRefs that way you never have to pass it from props.
There was a problem hiding this comment.
Is there anyway to make CoreRefs http always exist?
There was a problem hiding this comment.
http and all other coreRefs will be null at the beginning, when the plugin is in start mode. It is safe to assume that when the users is on this page coreRefs elements are not null.
There was a problem hiding this comment.
Addressed here : 011308f - will remove from other child components and from Home in follow up PR. Merging this as is.
Codecov Report
@@ Coverage Diff @@
## feature/flint-UI #1008 +/- ##
=================================================
Coverage 43.90% 43.91%
=================================================
Files 319 320 +1
Lines 18796 18816 +20
Branches 4581 4585 +4
=================================================
+ Hits 8253 8263 +10
- Misses 9987 9995 +8
- Partials 556 558 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…boards-observability into falback Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
derek-ho
added a commit
that referenced
this pull request
Sep 25, 2023
* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
derek-ho
added a commit
that referenced
this pull request
Sep 27, 2023
* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <[email protected]> * Rename and re-organize in folders Signed-off-by: Derek Ho <[email protected]> * Fix import path in testing file Signed-off-by: Derek Ho <[email protected]> * Get Initial S3 configuration working Signed-off-by: Derek Ho <[email protected]> * Configure S3 Data Source Working Signed-off-by: Derek Ho <[email protected]> * Fix query permissions display Signed-off-by: Derek Ho <[email protected]> * Fix merge conflict Signed-off-by: Derek Ho <[email protected]> * Clean up PR Signed-off-by: Derek Ho <[email protected]> * Add s3 logo in manage table Signed-off-by: Derek Ho <[email protected]> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Remove successfully Signed-off-by: Derek Ho <[email protected]> * Update test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Update test in accordance to useLocation Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
derek-ho
added a commit
that referenced
this pull request
Sep 29, 2023
* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <[email protected]> * Rename and re-organize in folders Signed-off-by: Derek Ho <[email protected]> * Fix import path in testing file Signed-off-by: Derek Ho <[email protected]> * Get Initial S3 configuration working Signed-off-by: Derek Ho <[email protected]> * Configure S3 Data Source Working Signed-off-by: Derek Ho <[email protected]> * Fix query permissions display Signed-off-by: Derek Ho <[email protected]> * Fix merge conflict Signed-off-by: Derek Ho <[email protected]> * Clean up PR Signed-off-by: Derek Ho <[email protected]> * Add s3 logo in manage table Signed-off-by: Derek Ho <[email protected]> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Remove successfully Signed-off-by: Derek Ho <[email protected]> * Update test Signed-off-by: Derek Ho <[email protected]> * Initial commit adding prometheus logo and icon Signed-off-by: Derek Ho <[email protected]> * Get the major flow working Signed-off-by: Derek Ho <[email protected]> * Fix app navigation Signed-off-by: Derek Ho <[email protected]> * Fix up PR Signed-off-by: Derek Ho <[email protected]> * Remove management redirection for now and fix test and add cards Signed-off-by: Derek Ho <[email protected]> * Remove type filter and update test according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Add link and update test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Include useful info in the error toast Signed-off-by: Derek Ho <[email protected]> * Update actions in manage table according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Add update button and update tests Signed-off-by: Derek Ho <[email protected]> * Remove unused code until further implementation Signed-off-by: Derek Ho <[email protected]> * Fix router files Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Oct 4, 2023
…roject#1035) * Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Oct 4, 2023
* Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <[email protected]> * Rename and re-organize in folders Signed-off-by: Derek Ho <[email protected]> * Fix import path in testing file Signed-off-by: Derek Ho <[email protected]> * Get Initial S3 configuration working Signed-off-by: Derek Ho <[email protected]> * Configure S3 Data Source Working Signed-off-by: Derek Ho <[email protected]> * Fix query permissions display Signed-off-by: Derek Ho <[email protected]> * Fix merge conflict Signed-off-by: Derek Ho <[email protected]> * Clean up PR Signed-off-by: Derek Ho <[email protected]> * Add s3 logo in manage table Signed-off-by: Derek Ho <[email protected]> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Remove successfully Signed-off-by: Derek Ho <[email protected]> * Update test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Update test in accordance to useLocation Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Oct 4, 2023
* Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * get rid of lint Signed-off-by: Derek Ho <[email protected]> * test for flyout Signed-off-by: Derek Ho <[email protected]> * flyout to medium size Signed-off-by: Derek Ho <[email protected]> * make accelerate extensible Signed-off-by: Derek Ho <[email protected]> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <[email protected]> * get flint working Signed-off-by: Derek Ho <[email protected]> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <[email protected]> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <[email protected]> * hook up manage to show datasources call Signed-off-by: Derek Ho <[email protected]> * update two tables with descriptions Signed-off-by: Derek Ho <[email protected]> * make some updates to the page Signed-off-by: Derek Ho <[email protected]> * cleanup unused files for data connections Signed-off-by: Derek Ho <[email protected]> * cleanup and add overview panel columns Signed-off-by: Derek Ho <[email protected]> * render tabs Signed-off-by: Derek Ho <[email protected]> * add unit tests Signed-off-by: Derek Ho <[email protected]> * update data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> * Add datasources to management overview Signed-off-by: Derek Ho <[email protected]> * remove spark logo and update snapshot Signed-off-by: Derek Ho <[email protected]> * refactor routes out Signed-off-by: Derek Ho <[email protected]> * separate out the roles Signed-off-by: Derek Ho <[email protected]> * bump version back to 3.0 Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <[email protected]> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <[email protected]> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * update snapshot Signed-off-by: Shenoy Pratik <[email protected]> * update window location to hash Signed-off-by: Shenoy Pratik <[email protected]> * remove unused headers Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <[email protected]> * final cleanup Signed-off-by: Derek Ho <[email protected]> * update acceleration breadcrumb Signed-off-by: Derek Ho <[email protected]> * fix API call for data connection page Signed-off-by: Derek Ho <[email protected]> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <[email protected]> * always show datasources via pplservice Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <[email protected]> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <[email protected]> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <[email protected]> * remove unused import Signed-off-by: Derek Ho <[email protected]> * fix import and snapshot Signed-off-by: Derek Ho <[email protected]> * fix test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Remove unused files and variables Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <[email protected]> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <[email protected]> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <[email protected]> * Update test with mock role data Signed-off-by: Derek Ho <[email protected]> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <[email protected]> * remove acceleration components Signed-off-by: Shenoy Pratik <[email protected]> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <[email protected]> * Rename and re-organize in folders Signed-off-by: Derek Ho <[email protected]> * Fix import path in testing file Signed-off-by: Derek Ho <[email protected]> * Get Initial S3 configuration working Signed-off-by: Derek Ho <[email protected]> * Configure S3 Data Source Working Signed-off-by: Derek Ho <[email protected]> * Fix query permissions display Signed-off-by: Derek Ho <[email protected]> * Fix merge conflict Signed-off-by: Derek Ho <[email protected]> * Clean up PR Signed-off-by: Derek Ho <[email protected]> * Add s3 logo in manage table Signed-off-by: Derek Ho <[email protected]> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Remove successfully Signed-off-by: Derek Ho <[email protected]> * Update test Signed-off-by: Derek Ho <[email protected]> * Initial commit adding prometheus logo and icon Signed-off-by: Derek Ho <[email protected]> * Get the major flow working Signed-off-by: Derek Ho <[email protected]> * Fix app navigation Signed-off-by: Derek Ho <[email protected]> * Fix up PR Signed-off-by: Derek Ho <[email protected]> * Remove management redirection for now and fix test and add cards Signed-off-by: Derek Ho <[email protected]> * Remove type filter and update test according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Add link and update test Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> * Include useful info in the error toast Signed-off-by: Derek Ho <[email protected]> * Update actions in manage table according to UX feedback Signed-off-by: Derek Ho <[email protected]> * Add update button and update tests Signed-off-by: Derek Ho <[email protected]> * Remove unused code until further implementation Signed-off-by: Derek Ho <[email protected]> * Fix router files Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
pjfitzgibbons
added a commit
that referenced
this pull request
Oct 5, 2023
* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: sumukhswamy <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Simeon Widdis <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: sumukhswamy <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Simeon Widdis <[email protected]> (cherry picked from commit 171acde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.