Move convertDateTime, refactor query_utils

[pjfitzgibbons]

Signed-off-by: Peter Fitzgibbons [email protected]

Description

Add tests for QueryUtils #parsePromQLIntoKeywords

Moved #convertDateTime from custom_panels/helpser/utils in order to cerntralize and allow QueryUtils to be tested without import overhead of many TSX modules.

Issues Resolved

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[pjfitzgibbons]

I know it's hard to see (well impossible to see).
Fixed a bug here.

Before/after regexes :

/(?<aggregation>\S+) *?(by ?\((?<attributesGroupBy>.*?)\))? *?\((?<metric>\S+)\)/i
/(?<aggregation>\S+) *?(by ?\((?<attributesGroupBy>.*?))\)? *?\((?<metric>\S+)\)/i
                                                      --^

[codecov]

Codecov Report

Merging #1064 (4bdb825) into main (7630b2d) will increase coverage by 0.29%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   44.28%   44.57%   +0.29%     
==========================================
  Files         325      325              
  Lines       19176    19333     +157     
  Branches     4567     4606      +39     
==========================================
+ Hits         8492     8618     +126     
- Misses      10642    10672      +30     
- Partials       42       43       +1     

Flag	Coverage Δ
dashboards-observability	44.57% <ø> (+0.29%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1064-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c4ed77c361c47648f498aa86a4b2484163108249
# Push it to GitHub
git push --set-upstream origin backport/backport-1064-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1064-to-2.x.

[joshuali925]

this is backported by 171acde