Add Toasts to Observability Dashboards #435

ps48 · 2023-04-27T07:18:29Z

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]>

Signed-off-by: Peter Fitzgibbons <[email protected]>

Signed-off-by: Shenoy Pratik <[email protected]>

Signed-off-by: Derek Ho <[email protected]>

pjfitzgibbons

I am very excited for this change! This sets a great precident for encapsulation and simplification of our code.
Thanks for taking it through to completion.

I'll approve upon responses/refactors.

common/constants/custom_panels.ts

pjfitzgibbons · 2023-04-27T20:05:36Z

public/components/custom_panels/custom_panel_view_so.tsx

  }: {
    savedVisualizationId: string;
    oldVisualizationId?: string;
+    onSuccess: string;


Love this!

Since onSuccess, onFailure are string, it might be more clear to avoid the "handler-function" name structure ("on..."). Maybe successMsg, failureMsg ?

If so, carry the change throughout.

pjfitzgibbons · 2023-04-27T20:08:25Z

public/components/custom_panels/redux/panel_slice.ts

@@ -81,6 +82,8 @@ const normalizedPanel = (panel: CustomPanelType): CustomPanelType => ({

 export const selectPanelList = (rootState): CustomPanelType[] => rootState.customPanel.panelList;

+const {setToast} = useToast();


For some reason I'm very surprised this works (?)

I think b/c in a previous incantation of useToast it had react state (used setState) and therefore was required to be inside a React-FC. (the inception of the use... naming).

Glad it works outside too!

pjfitzgibbons · 2023-04-27T20:09:40Z

public/components/custom_panels/redux/panel_slice.ts

    dispatch(setPanel(panel));
    const panelList = getState().customPanel.panelList.map((p) => (p.id === panel.id ? panel : p));
    dispatch(setPanelList(panelList));
-  } catch (err) {
-    console.log('Error updating Dashboard', { err, panel });
+  } catch (e) {    


I'm about to believe that this try..catch block... especially the catch{} could be put in a wrapper function.
Maybe I'm over-engineering.

I think its over engineering for now... My 2 cents is to push it into another PR if necessary. I think this PR is already doing a lot regarding the framework around how we want to handle success and error in redux world

pjfitzgibbons · 2023-04-27T20:11:54Z

public/components/custom_panels/redux/panel_slice.ts

@@ -212,40 +217,68 @@ const deleteLegacyPanels = (customPanelIdList: string[]) => {
 };

 export const deletePanels = (panelsToDelete: CustomPanelType[]) => async (dispatch, getState) => {
-  const ids = panelsToDelete.map((p) => p.id);
-  await Promise.all([deleteLegacyPanels(ids), deletePanelSO(ids)]);
+  const toastMessage = `Observability Dashboard${


I'm finding myself re-reading this block every time to see what it does... and that it does it right. sigh

Can we wrap this in a function pluralize() or something?

Maybe even simpler... just say "Observability Dashboard(s)". No one truly cares... unless UX objects on some principle reason.

Should we still try to show the name of the deleted dashboard if it's only one? I think this is just saying show:
Observability Dashboards successfully deleted
if plural
else
Observability Dashboard "name" successfully deleted

derek-ho · 2023-04-27T20:23:10Z

common/constants/shared.ts

@@ -25,7 +25,7 @@ export const DSL_ENDPOINT = '/_plugins/_dsl';

 export const observabilityID = 'observability-logs';
 export const observabilityTitle = 'Observability';
-export const observabilityPluginOrder = 6000;
+export const observabilityPluginOrder = 1500;


what's this for?

For this:

dashboards-observability/public/plugin.ts

Line 116 in dfd8582

order: observabilityPluginOrder,

Earlier it was hardcoded in plugin.ts moved it to constants.

Signed-off-by: Derek Ho <[email protected]>

opensearch-trigger-bot · 2023-04-28T17:04:19Z

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-435-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a9d1d37035f41d5e81f521f16dd4ebcfaf478398
# Push it to GitHub
git push --set-upstream origin backport/backport-435-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-435-to-main.

* Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <[email protected]> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <[email protected]> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unused redux slice Signed-off-by: Shenoy Pratik <[email protected]> * revert cypress changes Signed-off-by: Shenoy Pratik <[email protected]> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <[email protected]> * fix messaging for multiple delete Signed-off-by: Derek Ho <[email protected]> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <[email protected]> * fix up clone Signed-off-by: Derek Ho <[email protected]> * fix rename in table Signed-off-by: Derek Ho <[email protected]> * fix rename in custom panel so view Signed-off-by: Derek Ho <[email protected]> * fix up panel toasts Signed-off-by: Derek Ho <[email protected]> * fix up for flyout Signed-off-by: Derek Ho <[email protected]> * code cleanup Signed-off-by: Derek Ho <[email protected]> * finish merge Signed-off-by: Derek Ho <[email protected]> * fix up PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> (cherry picked from commit a9d1d37) Signed-off-by: Derek Ho <[email protected]>

* Add Toasts to Observability Dashboards (#435) * Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <[email protected]> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <[email protected]> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unused redux slice Signed-off-by: Shenoy Pratik <[email protected]> * revert cypress changes Signed-off-by: Shenoy Pratik <[email protected]> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <[email protected]> * fix messaging for multiple delete Signed-off-by: Derek Ho <[email protected]> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <[email protected]> * fix up clone Signed-off-by: Derek Ho <[email protected]> * fix rename in table Signed-off-by: Derek Ho <[email protected]> * fix rename in custom panel so view Signed-off-by: Derek Ho <[email protected]> * fix up panel toasts Signed-off-by: Derek Ho <[email protected]> * fix up for flyout Signed-off-by: Derek Ho <[email protected]> * code cleanup Signed-off-by: Derek Ho <[email protected]> * finish merge Signed-off-by: Derek Ho <[email protected]> * fix up PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> (cherry picked from commit a9d1d37) Signed-off-by: Derek Ho <[email protected]> * remove duplicate inport Signed-off-by: Derek Ho <[email protected]> * remove duplicate code block Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]>

* Fix for hover issue on docs of discover/explorer data grid (#329) (#358) Signed-off-by: Eric Wei <[email protected]> (cherry picked from commit 19f29e1) Co-authored-by: Eric Wei <[email protected]> * [2.7] Refactor Saved objects and add visualization embeddable (#341) (#353) Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> * Cohesion main to 2.7 (#382) Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL (#383) (#384) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 23e09e5) Co-authored-by: Joshua Li <[email protected]> * [2.7] Redo pick from main to 2.7 (#385) Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Metrics analytics support for SOpanels (#386) (#388) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1ecd7ea) Co-authored-by: Shenoy Pratik <[email protected]> * change plugin ordering (#389) (#390) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a6c1ebc) Co-authored-by: Shenoy Pratik <[email protected]> * notebooks fix for cypress and minor bugs (#392) (#393) * notebooks fix for cypress and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * remove comments Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 3219f14) * Update traces integration tests (#391) (#397) * Update traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Update traces cypress test Signed-off-by: Rupal Mahajan <[email protected]> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Fix filters test Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit b8f9ca3) Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL from dashboards (#399) (#403) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 05ef180) Co-authored-by: Joshua Li <[email protected]> * Adjust metrics top menu layout to avoid overflow (#398) (#402) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6309e63) Co-authored-by: Joshua Li <[email protected]> * Support duplicate visualization in dashboard (#400) (#405) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 3d74bac) Co-authored-by: Joshua Li <[email protected]> * fix panel visualization preview, new viz workflow (#401) (#404) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 78347d9) Co-authored-by: Shenoy Pratik <[email protected]> * Fix saving multiple metrics to SOpanels (#407) (#408) * fix saving multiple metrics to SOpanels Signed-off-by: Shenoy Pratik <[email protected]> * remove unused variable Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a4cb6d1) Co-authored-by: Shenoy Pratik <[email protected]> * Panel table fixes (#406) * Fix Panel View (legacy) - Duplicate - Rename - Delete --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Release Notes 2.7.0.0 (#394) (#412) * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 969e639) Co-authored-by: Peter Fitzgibbons <[email protected]> * [Dashboard listing] update edit url and view url (#416) (#421) * [Dashboard listing] update edit url and view url Update to include BASE_URL if basePath is defined. Since create url is just a direct nav and needs the basePath when passing props to the provider, the source code no longer appends the basePath to keep these URLs consistent. A feature should consolidate the basePaths in the dashboard listing service so that createUrl also adds the base path. At which point we no longer need the base path. Also removed some rogue URLs. Core PR: opensearch-project/OpenSearch-Dashboards#3922 --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit f94c21e) Co-authored-by: Kawika Avilla <[email protected]> * Fix invalid time range in new panels (#419) Signed-off-by: Joshua Li <[email protected]> * open new tab for editing panel visualization (#430) Signed-off-by: Eric Wei <[email protected]> * Save new prometheus metrics to OSD saved objects (#428) * Save new prometheus metrics to OSD saved objects Signed-off-by: Joshua Li <[email protected]> * Return if failed at saving metrics Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> * fixes edit mode callback bug in Saved Object Panels (#420) * fix for SOpanels editMode Signed-off-by: Shenoy Pratik <[email protected]> * rename edit button data-test-subj Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Add Toasts to Observability Dashboards (#435) * Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <[email protected]> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <[email protected]> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unused redux slice Signed-off-by: Shenoy Pratik <[email protected]> * revert cypress changes Signed-off-by: Shenoy Pratik <[email protected]> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <[email protected]> * fix messaging for multiple delete Signed-off-by: Derek Ho <[email protected]> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <[email protected]> * fix up clone Signed-off-by: Derek Ho <[email protected]> * fix rename in table Signed-off-by: Derek Ho <[email protected]> * fix rename in custom panel so view Signed-off-by: Derek Ho <[email protected]> * fix up panel toasts Signed-off-by: Derek Ho <[email protected]> * fix up for flyout Signed-off-by: Derek Ho <[email protected]> * code cleanup Signed-off-by: Derek Ho <[email protected]> * finish merge Signed-off-by: Derek Ho <[email protected]> * fix up PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> * change samples to saved object (#427) (#436) * change samples to saved object * add sample to so * fix saved object sample * fix up * add back toast * revert file * refactoring * use constant --------- (cherry picked from commit ce06ccb) Signed-off-by: Derek Ho <[email protected]> * Add Error handling on duplicate dashboard names (#441) * Add check for existing panel name Signed-off-by: Rupal Mahajan <[email protected]> * Nit Signed-off-by: Rupal Mahajan <[email protected]> * Remove double await Signed-off-by: Rupal Mahajan <[email protected]> * Add rename name check test Signed-off-by: Rupal Mahajan <[email protected]> * Remove test Signed-off-by: Rupal Mahajan <[email protected]> * Add unique id to sample panel name Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> * fix timestamp overriding issue (#449) Signed-off-by: Eric Wei <[email protected]> * Renaming custom panels to Observability Dashboards (#450) * change custom panels -> observability dashboards Signed-off-by: Eric Wei <[email protected]> * rest of the panel renaming Signed-off-by: Eric Wei <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> * Fix delete failure when no osd item selected (#452) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a4a310e) * Open log patterns by default (#444) (#459) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 72970aa) * diff merging between 2.x and 2.7 Signed-off-by: Shenoy Pratik <[email protected]> * add service fields length check in app analytics Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]>

* Fix for hover issue on docs of discover/explorer data grid (opensearch-project#329) (opensearch-project#358) Signed-off-by: Eric Wei <[email protected]> (cherry picked from commit 19f29e1) Co-authored-by: Eric Wei <[email protected]> * [2.7] Refactor Saved objects and add visualization embeddable (opensearch-project#341) (opensearch-project#353) Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> * Cohesion main to 2.7 (opensearch-project#382) Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL (opensearch-project#383) (opensearch-project#384) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 23e09e5) Co-authored-by: Joshua Li <[email protected]> * [2.7] Redo pick from main to 2.7 (opensearch-project#385) Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Metrics analytics support for SOpanels (opensearch-project#386) (opensearch-project#388) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1ecd7ea) Co-authored-by: Shenoy Pratik <[email protected]> * change plugin ordering (opensearch-project#389) (opensearch-project#390) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a6c1ebc) Co-authored-by: Shenoy Pratik <[email protected]> * notebooks fix for cypress and minor bugs (opensearch-project#392) (opensearch-project#393) * notebooks fix for cypress and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * remove comments Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 3219f14) * Update traces integration tests (opensearch-project#391) (opensearch-project#397) * Update traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Update traces cypress test Signed-off-by: Rupal Mahajan <[email protected]> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Fix filters test Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit b8f9ca3) Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL from dashboards (opensearch-project#399) (opensearch-project#403) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 05ef180) Co-authored-by: Joshua Li <[email protected]> * Adjust metrics top menu layout to avoid overflow (opensearch-project#398) (opensearch-project#402) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6309e63) Co-authored-by: Joshua Li <[email protected]> * Support duplicate visualization in dashboard (opensearch-project#400) (opensearch-project#405) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 3d74bac) Co-authored-by: Joshua Li <[email protected]> * fix panel visualization preview, new viz workflow (opensearch-project#401) (opensearch-project#404) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 78347d9) Co-authored-by: Shenoy Pratik <[email protected]> * Fix saving multiple metrics to SOpanels (opensearch-project#407) (opensearch-project#408) * fix saving multiple metrics to SOpanels Signed-off-by: Shenoy Pratik <[email protected]> * remove unused variable Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a4cb6d1) Co-authored-by: Shenoy Pratik <[email protected]> * Panel table fixes (opensearch-project#406) * Fix Panel View (legacy) - Duplicate - Rename - Delete --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Release Notes 2.7.0.0 (opensearch-project#394) (opensearch-project#412) * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 969e639) Co-authored-by: Peter Fitzgibbons <[email protected]> * [Dashboard listing] update edit url and view url (opensearch-project#416) (opensearch-project#421) * [Dashboard listing] update edit url and view url Update to include BASE_URL if basePath is defined. Since create url is just a direct nav and needs the basePath when passing props to the provider, the source code no longer appends the basePath to keep these URLs consistent. A feature should consolidate the basePaths in the dashboard listing service so that createUrl also adds the base path. At which point we no longer need the base path. Also removed some rogue URLs. Core PR: opensearch-project/OpenSearch-Dashboards#3922 --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit f94c21e) Co-authored-by: Kawika Avilla <[email protected]> * Fix invalid time range in new panels (opensearch-project#419) Signed-off-by: Joshua Li <[email protected]> * open new tab for editing panel visualization (opensearch-project#430) Signed-off-by: Eric Wei <[email protected]> * Save new prometheus metrics to OSD saved objects (opensearch-project#428) * Save new prometheus metrics to OSD saved objects Signed-off-by: Joshua Li <[email protected]> * Return if failed at saving metrics Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> * fixes edit mode callback bug in Saved Object Panels (opensearch-project#420) * fix for SOpanels editMode Signed-off-by: Shenoy Pratik <[email protected]> * rename edit button data-test-subj Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Add Toasts to Observability Dashboards (opensearch-project#435) * Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <[email protected]> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <[email protected]> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unused redux slice Signed-off-by: Shenoy Pratik <[email protected]> * revert cypress changes Signed-off-by: Shenoy Pratik <[email protected]> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <[email protected]> * fix messaging for multiple delete Signed-off-by: Derek Ho <[email protected]> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <[email protected]> * fix up clone Signed-off-by: Derek Ho <[email protected]> * fix rename in table Signed-off-by: Derek Ho <[email protected]> * fix rename in custom panel so view Signed-off-by: Derek Ho <[email protected]> * fix up panel toasts Signed-off-by: Derek Ho <[email protected]> * fix up for flyout Signed-off-by: Derek Ho <[email protected]> * code cleanup Signed-off-by: Derek Ho <[email protected]> * finish merge Signed-off-by: Derek Ho <[email protected]> * fix up PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> * change samples to saved object (opensearch-project#427) (opensearch-project#436) * change samples to saved object * add sample to so * fix saved object sample * fix up * add back toast * revert file * refactoring * use constant --------- (cherry picked from commit ce06ccb) Signed-off-by: Derek Ho <[email protected]> * Add Error handling on duplicate dashboard names (opensearch-project#441) * Add check for existing panel name Signed-off-by: Rupal Mahajan <[email protected]> * Nit Signed-off-by: Rupal Mahajan <[email protected]> * Remove double await Signed-off-by: Rupal Mahajan <[email protected]> * Add rename name check test Signed-off-by: Rupal Mahajan <[email protected]> * Remove test Signed-off-by: Rupal Mahajan <[email protected]> * Add unique id to sample panel name Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> * fix timestamp overriding issue (opensearch-project#449) Signed-off-by: Eric Wei <[email protected]> * Renaming custom panels to Observability Dashboards (opensearch-project#450) * change custom panels -> observability dashboards Signed-off-by: Eric Wei <[email protected]> * rest of the panel renaming Signed-off-by: Eric Wei <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> * Fix delete failure when no osd item selected (opensearch-project#452) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a4a310e) * Open log patterns by default (opensearch-project#444) (opensearch-project#459) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 72970aa) * diff merging between 2.x and 2.7 Signed-off-by: Shenoy Pratik <[email protected]> * add service fields length check in app analytics Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit 776d1ed)

Peter Fitzgibbons and others added 13 commits April 26, 2023 22:51

Fixes

c74385b

* Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]>

Toasts use hook from useOpenSearchDashboards context provider

4aa38ac

Signed-off-by: Peter Fitzgibbons <[email protected]>

Testing for CustomPanel Toast

20faeda

Signed-off-by: Peter Fitzgibbons <[email protected]>

update catches from comments, minor code cleaning

67d04e0

Signed-off-by: Shenoy Pratik <[email protected]>

update tests

1a1edeb

Signed-off-by: Shenoy Pratik <[email protected]>

remove unused redux slice

485b8a8

Signed-off-by: Shenoy Pratik <[email protected]>

revert cypress changes

9c6173b

Signed-off-by: Shenoy Pratik <[email protected]>

add toasts to SOflyout

8d9d08b

Signed-off-by: Shenoy Pratik <[email protected]>

fix messaging for multiple delete

7ffe655

Signed-off-by: Derek Ho <[email protected]>

fix up toast and error handling for create and delete flows

0b82588

Signed-off-by: Derek Ho <[email protected]>

fix up clone

d06d546

Signed-off-by: Derek Ho <[email protected]>

fix rename in table

d45692f

Signed-off-by: Derek Ho <[email protected]>

fix rename in custom panel so view

642f5e0

Signed-off-by: Derek Ho <[email protected]>

ps48 mentioned this pull request Apr 27, 2023

fixes edit mode callback bug in Saved Object Panels #420

Merged

6 tasks

derek-ho added 5 commits April 27, 2023 14:43

fix up panel toasts

a20c042

Signed-off-by: Derek Ho <[email protected]>

fix up for flyout

7eba7b4

Signed-off-by: Derek Ho <[email protected]>

Merge branch '2.7' into toast

f62f1b8

Signed-off-by: Derek Ho <[email protected]>

code cleanup

dbc7976

Signed-off-by: Derek Ho <[email protected]>

finish merge

dfd8582

Signed-off-by: Derek Ho <[email protected]>

pjfitzgibbons reviewed Apr 27, 2023

View reviewed changes

derek-ho reviewed Apr 27, 2023

View reviewed changes

fix up PR comments

6c9e867

Signed-off-by: Derek Ho <[email protected]>

derek-ho approved these changes Apr 27, 2023

View reviewed changes

joshuali925 approved these changes Apr 28, 2023

View reviewed changes

ps48 mentioned this pull request Apr 28, 2023

Add Error handling on duplicate dashboard names #422

Closed

6 tasks

derek-ho merged commit a9d1d37 into opensearch-project:2.7 Apr 28, 2023

derek-ho added the backport main label Apr 28, 2023

derek-ho mentioned this pull request May 9, 2023

[BACKPORT MAIN]Add Toasts to Observability Dashboards (#435) #455

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Toasts to Observability Dashboards #435

Add Toasts to Observability Dashboards #435

ps48 commented Apr 27, 2023

pjfitzgibbons left a comment •

edited

Loading

pjfitzgibbons Apr 27, 2023

pjfitzgibbons Apr 27, 2023

pjfitzgibbons Apr 27, 2023

derek-ho Apr 27, 2023

pjfitzgibbons Apr 27, 2023

derek-ho Apr 27, 2023

derek-ho Apr 27, 2023

ps48 Apr 27, 2023

opensearch-trigger-bot bot commented Apr 28, 2023

		@@ -81,6 +82,8 @@ const normalizedPanel = (panel: CustomPanelType): CustomPanelType => ({

		export const selectPanelList = (rootState): CustomPanelType[] => rootState.customPanel.panelList;

		const {setToast} = useToast();

Add Toasts to Observability Dashboards #435

Add Toasts to Observability Dashboards #435

Conversation

ps48 commented Apr 27, 2023

Description

Issues Resolved

Check List

pjfitzgibbons left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Apr 28, 2023

pjfitzgibbons left a comment •

edited

Loading