[Backport 2.7] Update traces integration tests #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Update traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Update traces cypress test Signed-off-by: Rupal Mahajan <[email protected]> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Fix filters test Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit b8f9ca3)
rupal-bq
approved these changes
Apr 19, 2023
YANG-DB
approved these changes
Apr 19, 2023
ps48
added a commit
that referenced
this pull request
May 24, 2023
* Fix for hover issue on docs of discover/explorer data grid (#329) (#358) Signed-off-by: Eric Wei <[email protected]> (cherry picked from commit 19f29e1) Co-authored-by: Eric Wei <[email protected]> * [2.7] Refactor Saved objects and add visualization embeddable (#341) (#353) Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> * Cohesion main to 2.7 (#382) Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL (#383) (#384) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 23e09e5) Co-authored-by: Joshua Li <[email protected]> * [2.7] Redo pick from main to 2.7 (#385) Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Metrics analytics support for SOpanels (#386) (#388) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1ecd7ea) Co-authored-by: Shenoy Pratik <[email protected]> * change plugin ordering (#389) (#390) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a6c1ebc) Co-authored-by: Shenoy Pratik <[email protected]> * notebooks fix for cypress and minor bugs (#392) (#393) * notebooks fix for cypress and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * remove comments Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 3219f14) * Update traces integration tests (#391) (#397) * Update traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Update traces cypress test Signed-off-by: Rupal Mahajan <[email protected]> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Fix filters test Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit b8f9ca3) Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL from dashboards (#399) (#403) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 05ef180) Co-authored-by: Joshua Li <[email protected]> * Adjust metrics top menu layout to avoid overflow (#398) (#402) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6309e63) Co-authored-by: Joshua Li <[email protected]> * Support duplicate visualization in dashboard (#400) (#405) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 3d74bac) Co-authored-by: Joshua Li <[email protected]> * fix panel visualization preview, new viz workflow (#401) (#404) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 78347d9) Co-authored-by: Shenoy Pratik <[email protected]> * Fix saving multiple metrics to SOpanels (#407) (#408) * fix saving multiple metrics to SOpanels Signed-off-by: Shenoy Pratik <[email protected]> * remove unused variable Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a4cb6d1) Co-authored-by: Shenoy Pratik <[email protected]> * Panel table fixes (#406) * Fix Panel View (legacy) - Duplicate - Rename - Delete --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Release Notes 2.7.0.0 (#394) (#412) * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 969e639) Co-authored-by: Peter Fitzgibbons <[email protected]> * [Dashboard listing] update edit url and view url (#416) (#421) * [Dashboard listing] update edit url and view url Update to include BASE_URL if basePath is defined. Since create url is just a direct nav and needs the basePath when passing props to the provider, the source code no longer appends the basePath to keep these URLs consistent. A feature should consolidate the basePaths in the dashboard listing service so that createUrl also adds the base path. At which point we no longer need the base path. Also removed some rogue URLs. Core PR: opensearch-project/OpenSearch-Dashboards#3922 --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit f94c21e) Co-authored-by: Kawika Avilla <[email protected]> * Fix invalid time range in new panels (#419) Signed-off-by: Joshua Li <[email protected]> * open new tab for editing panel visualization (#430) Signed-off-by: Eric Wei <[email protected]> * Save new prometheus metrics to OSD saved objects (#428) * Save new prometheus metrics to OSD saved objects Signed-off-by: Joshua Li <[email protected]> * Return if failed at saving metrics Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> * fixes edit mode callback bug in Saved Object Panels (#420) * fix for SOpanels editMode Signed-off-by: Shenoy Pratik <[email protected]> * rename edit button data-test-subj Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Add Toasts to Observability Dashboards (#435) * Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <[email protected]> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <[email protected]> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unused redux slice Signed-off-by: Shenoy Pratik <[email protected]> * revert cypress changes Signed-off-by: Shenoy Pratik <[email protected]> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <[email protected]> * fix messaging for multiple delete Signed-off-by: Derek Ho <[email protected]> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <[email protected]> * fix up clone Signed-off-by: Derek Ho <[email protected]> * fix rename in table Signed-off-by: Derek Ho <[email protected]> * fix rename in custom panel so view Signed-off-by: Derek Ho <[email protected]> * fix up panel toasts Signed-off-by: Derek Ho <[email protected]> * fix up for flyout Signed-off-by: Derek Ho <[email protected]> * code cleanup Signed-off-by: Derek Ho <[email protected]> * finish merge Signed-off-by: Derek Ho <[email protected]> * fix up PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> * change samples to saved object (#427) (#436) * change samples to saved object * add sample to so * fix saved object sample * fix up * add back toast * revert file * refactoring * use constant --------- (cherry picked from commit ce06ccb) Signed-off-by: Derek Ho <[email protected]> * Add Error handling on duplicate dashboard names (#441) * Add check for existing panel name Signed-off-by: Rupal Mahajan <[email protected]> * Nit Signed-off-by: Rupal Mahajan <[email protected]> * Remove double await Signed-off-by: Rupal Mahajan <[email protected]> * Add rename name check test Signed-off-by: Rupal Mahajan <[email protected]> * Remove test Signed-off-by: Rupal Mahajan <[email protected]> * Add unique id to sample panel name Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> * fix timestamp overriding issue (#449) Signed-off-by: Eric Wei <[email protected]> * Renaming custom panels to Observability Dashboards (#450) * change custom panels -> observability dashboards Signed-off-by: Eric Wei <[email protected]> * rest of the panel renaming Signed-off-by: Eric Wei <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> * Fix delete failure when no osd item selected (#452) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a4a310e) * Open log patterns by default (#444) (#459) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 72970aa) * diff merging between 2.x and 2.7 Signed-off-by: Shenoy Pratik <[email protected]> * add service fields length check in app analytics Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Fix for hover issue on docs of discover/explorer data grid (opensearch-project#329) (opensearch-project#358) Signed-off-by: Eric Wei <[email protected]> (cherry picked from commit 19f29e1) Co-authored-by: Eric Wei <[email protected]> * [2.7] Refactor Saved objects and add visualization embeddable (opensearch-project#341) (opensearch-project#353) Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> * Cohesion main to 2.7 (opensearch-project#382) Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL (opensearch-project#383) (opensearch-project#384) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 23e09e5) Co-authored-by: Joshua Li <[email protected]> * [2.7] Redo pick from main to 2.7 (opensearch-project#385) Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Metrics analytics support for SOpanels (opensearch-project#386) (opensearch-project#388) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1ecd7ea) Co-authored-by: Shenoy Pratik <[email protected]> * change plugin ordering (opensearch-project#389) (opensearch-project#390) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a6c1ebc) Co-authored-by: Shenoy Pratik <[email protected]> * notebooks fix for cypress and minor bugs (opensearch-project#392) (opensearch-project#393) * notebooks fix for cypress and minor bugs Signed-off-by: Shenoy Pratik <[email protected]> * remove comments Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 3219f14) * Update traces integration tests (opensearch-project#391) (opensearch-project#397) * Update traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Update traces cypress test Signed-off-by: Rupal Mahajan <[email protected]> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <[email protected]> * Fix filters test Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit b8f9ca3) Co-authored-by: Rupal Mahajan <[email protected]> * Fix redirection to legacy event_analytics URL from dashboards (opensearch-project#399) (opensearch-project#403) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 05ef180) Co-authored-by: Joshua Li <[email protected]> * Adjust metrics top menu layout to avoid overflow (opensearch-project#398) (opensearch-project#402) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6309e63) Co-authored-by: Joshua Li <[email protected]> * Support duplicate visualization in dashboard (opensearch-project#400) (opensearch-project#405) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 3d74bac) Co-authored-by: Joshua Li <[email protected]> * fix panel visualization preview, new viz workflow (opensearch-project#401) (opensearch-project#404) Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 78347d9) Co-authored-by: Shenoy Pratik <[email protected]> * Fix saving multiple metrics to SOpanels (opensearch-project#407) (opensearch-project#408) * fix saving multiple metrics to SOpanels Signed-off-by: Shenoy Pratik <[email protected]> * remove unused variable Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a4cb6d1) Co-authored-by: Shenoy Pratik <[email protected]> * Panel table fixes (opensearch-project#406) * Fix Panel View (legacy) - Duplicate - Rename - Delete --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Release Notes 2.7.0.0 (opensearch-project#394) (opensearch-project#412) * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 969e639) Co-authored-by: Peter Fitzgibbons <[email protected]> * [Dashboard listing] update edit url and view url (opensearch-project#416) (opensearch-project#421) * [Dashboard listing] update edit url and view url Update to include BASE_URL if basePath is defined. Since create url is just a direct nav and needs the basePath when passing props to the provider, the source code no longer appends the basePath to keep these URLs consistent. A feature should consolidate the basePaths in the dashboard listing service so that createUrl also adds the base path. At which point we no longer need the base path. Also removed some rogue URLs. Core PR: opensearch-project/OpenSearch-Dashboards#3922 --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit f94c21e) Co-authored-by: Kawika Avilla <[email protected]> * Fix invalid time range in new panels (opensearch-project#419) Signed-off-by: Joshua Li <[email protected]> * open new tab for editing panel visualization (opensearch-project#430) Signed-off-by: Eric Wei <[email protected]> * Save new prometheus metrics to OSD saved objects (opensearch-project#428) * Save new prometheus metrics to OSD saved objects Signed-off-by: Joshua Li <[email protected]> * Return if failed at saving metrics Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> * fixes edit mode callback bug in Saved Object Panels (opensearch-project#420) * fix for SOpanels editMode Signed-off-by: Shenoy Pratik <[email protected]> * rename edit button data-test-subj Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * Add Toasts to Observability Dashboards (opensearch-project#435) * Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <[email protected]> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <[email protected]> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <[email protected]> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unused redux slice Signed-off-by: Shenoy Pratik <[email protected]> * revert cypress changes Signed-off-by: Shenoy Pratik <[email protected]> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <[email protected]> * fix messaging for multiple delete Signed-off-by: Derek Ho <[email protected]> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <[email protected]> * fix up clone Signed-off-by: Derek Ho <[email protected]> * fix rename in table Signed-off-by: Derek Ho <[email protected]> * fix rename in custom panel so view Signed-off-by: Derek Ho <[email protected]> * fix up panel toasts Signed-off-by: Derek Ho <[email protected]> * fix up for flyout Signed-off-by: Derek Ho <[email protected]> * code cleanup Signed-off-by: Derek Ho <[email protected]> * finish merge Signed-off-by: Derek Ho <[email protected]> * fix up PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> * change samples to saved object (opensearch-project#427) (opensearch-project#436) * change samples to saved object * add sample to so * fix saved object sample * fix up * add back toast * revert file * refactoring * use constant --------- (cherry picked from commit ce06ccb) Signed-off-by: Derek Ho <[email protected]> * Add Error handling on duplicate dashboard names (opensearch-project#441) * Add check for existing panel name Signed-off-by: Rupal Mahajan <[email protected]> * Nit Signed-off-by: Rupal Mahajan <[email protected]> * Remove double await Signed-off-by: Rupal Mahajan <[email protected]> * Add rename name check test Signed-off-by: Rupal Mahajan <[email protected]> * Remove test Signed-off-by: Rupal Mahajan <[email protected]> * Add unique id to sample panel name Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> * fix timestamp overriding issue (opensearch-project#449) Signed-off-by: Eric Wei <[email protected]> * Renaming custom panels to Observability Dashboards (opensearch-project#450) * change custom panels -> observability dashboards Signed-off-by: Eric Wei <[email protected]> * rest of the panel renaming Signed-off-by: Eric Wei <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> * Fix delete failure when no osd item selected (opensearch-project#452) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a4a310e) * Open log patterns by default (opensearch-project#444) (opensearch-project#459) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 72970aa) * diff merging between 2.x and 2.7 Signed-off-by: Shenoy Pratik <[email protected]> * add service fields length check in app analytics Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Rupal Mahajan <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit 776d1ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b8f9ca3 from #391