change samples to saved object

[derek-ho]

Description

Saves sample panels as saved object instead of observability ops panel

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ps48]

minor: should we move this to common/constants?

[ps48]

Should we move this to /common/constants/utils? Cause, the createDemoPanel function is defined in the server whereas it is being used in public component.

[pjfitzgibbons]

Yes, +1, please relocate createDemoPanel fn

[derek-ho]

It's also being used in server here:

dashboards-observability/server/adaptors/custom_panels/custom_panel_adaptor.ts

Line 9 in 72def7d

import { createDemoPanel } from '../../common/helpers/custom_panels/sample_panels';

@pjfitzgibbons @ps48 take a look and let me know what you think. I think the original use case is to use it in the server, I am just using it as well to create the SO panel

[pjfitzgibbons]

Yes, +1, please relocate createDemoPanel fn

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-427-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce06ccb9fc4acd75d3ccbfbacab9db8a521de252
# Push it to GitHub
git push --set-upstream origin backport/backport-427-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-427-to-2.x.

[opensearch-trigger-bot]

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-427-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce06ccb9fc4acd75d3ccbfbacab9db8a521de252
# Push it to GitHub
git push --set-upstream origin backport/backport-427-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-427-to-2.7.