-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reporting on-demand menu items back in notebooks #229
Merged
joshuali925
merged 2 commits into
opensearch-project:main
from
joshuali925:fix-reporting
Feb 14, 2023
Merged
Add reporting on-demand menu items back in notebooks #229
joshuali925
merged 2 commits into
opensearch-project:main
from
joshuali925:fix-reporting
Feb 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
mengweieric
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 task
ps48
approved these changes
Feb 7, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-229-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0527730d9c7a7743e03061048937c6b3aa611788
# Push it to GitHub
git push --set-upstream origin backport/backport-229-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
ps48
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 0527730)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 0527730)
ps48
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 0527730) Co-authored-by: Joshua Li <[email protected]>
ps48
added a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 0527730) Co-authored-by: Joshua Li <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ect#229) (opensearch-project#499) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 0527730) Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit da169ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add reporting on-demand menu items back in notebooks. Clicking on them will open a new tab of notebooks in
output only
mode and trigger report generationIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.