Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporting on-demand menu items back in notebooks #229

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

joshuali925
Copy link
Member

Description

Add reporting on-demand menu items back in notebooks. Clicking on them will open a new tab of notebooks in output only mode and trigger report generation

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner January 26, 2023 18:41
Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuali925 joshuali925 merged commit 0527730 into opensearch-project:main Feb 14, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-229-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0527730d9c7a7743e03061048937c6b3aa611788
# Push it to GitHub
git push --set-upstream origin backport/backport-229-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-229-to-2.x.

ps48 pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)
ps48 pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)

Co-authored-by: Joshua Li <[email protected]>
ps48 added a commit that referenced this pull request May 30, 2023
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)

Co-authored-by: Joshua Li <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ect#229) (opensearch-project#499)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)

Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit da169ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants