Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add reporting on-demand menu items back in notebooks (#229) #499

Merged
merged 1 commit into from
May 30, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented May 30, 2023

Signed-off-by: Joshua Li [email protected]
(cherry picked from commit 0527730)

Description

Add reporting on-demand menu items back in notebooks. Clicking on them will open a new tab of notebooks in output only mode and trigger report generation

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)
@ps48
Copy link
Member Author

ps48 commented May 30, 2023

Please ignore the failing CI the fix is here: #499

@ps48 ps48 merged commit da169ae into 2.x May 30, 2023
@github-actions github-actions bot deleted the backport/backport-229-to-2.x branch May 30, 2023 17:53
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ect#229) (opensearch-project#499)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 0527730)

Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit da169ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants