Temporarily remove reporting menu tests in notebooks #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
vamsimanohar
approved these changes
Jan 14, 2023
rupal-bq
approved these changes
Jan 14, 2023
mengweieric
approved these changes
Jan 14, 2023
tianleh
approved these changes
Jan 15, 2023
@joshuali925 Feel free to merge |
|
@joshuali925 Do you want to merge the PR at this time? |
|
Also please add any backport labels if needed. Thanks |
|
sorry forgot about this PR. I'm waiting for opensearch-project/dashboards-observability#229 to be merged, this will revert the reporting menu changes, then I'll update tests if needed in a new PR. not sure why removing tests can introduce error in CI. Will check in new PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
see opensearch-project/dashboards-observability#202
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.