Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Flint datasource 2.13 bug bash fix #1574

Merged
merged 7 commits into from
Mar 20, 2024
Merged

[Bug Fix] Flint datasource 2.13 bug bash fix #1574

merged 7 commits into from
Mar 20, 2024

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Mar 19, 2024 •
edited
Loading

Description

Flint datasource 2.13 bug bash fix

Issues Resolved

  • Align the font with AO table
  • Acceleration table's status column capitalization issue.
  • Acceleration table header and buttons formatting.
  • Acceleration table timestamp localization.
  • "Query in Observability Logs" instead of "Query in Discover" for Get Started box in data connection.
  • Fix the discover icons description in both acceleration table and associated table.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.84%. Comparing base (cffc104) to head (81a4f88).

Files Patch % Lines
...nage/accelerations/acceleration_action_overlay.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
+ Coverage   57.83%   57.84%   +0.01%     
==========================================
  Files         367      367              
  Lines       13781    13785       +4     
  Branches     3612     3613       +1     
==========================================
+ Hits         7970     7974       +4     
  Misses       5747     5747              
  Partials       64       64
Flag Coverage Δ
dashboards-observability 57.84% <93.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997 RyanL1997 added bug Something isn't working enhancement New feature or request backport 2.x labels Mar 19, 2024
@RyanL1997 RyanL1997 marked this pull request as ready for review March 20, 2024 00:47
@ps48 ps48 merged commit ce9db20 into opensearch-project:main Mar 20, 2024
15 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
@github-actions
[Bug Fix] Flint datasource 2.13 bug bash fix (#1574)
c6cdba7 
* Fix the acc status caplitalization

Signed-off-by: Ryan Liang <[email protected]>

* Fix the header of acc table

Signed-off-by: Ryan Liang <[email protected]>

* Fix discover box text in get started boxes of data coneection

Signed-off-by: Ryan Liang <[email protected]>

* Fix the description for discover icon button

Signed-off-by: Ryan Liang <[email protected]>

* change the format of overlay msg for delete and vacuum

Signed-off-by: Ryan Liang <[email protected]>

* Fix the font issue in acc table

Signed-off-by: Ryan Liang <[email protected]>

* Change discover to query data

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit ce9db20)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
@github-actions
[Bug Fix] Flint datasource 2.13 bug bash fix (#1574)
b779f77 
* Fix the acc status caplitalization

Signed-off-by: Ryan Liang <[email protected]>

* Fix the header of acc table

Signed-off-by: Ryan Liang <[email protected]>

* Fix discover box text in get started boxes of data coneection

Signed-off-by: Ryan Liang <[email protected]>

* Fix the description for discover icon button

Signed-off-by: Ryan Liang <[email protected]>

* change the format of overlay msg for delete and vacuum

Signed-off-by: Ryan Liang <[email protected]>

* Fix the font issue in acc table

Signed-off-by: Ryan Liang <[email protected]>

* Change discover to query data

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit ce9db20)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2024
Merged
ps48 pushed a commit that referenced this pull request Mar 20, 2024
@opensearch-trigger-bot @github-actions
[Bug Fix] Flint datasource 2.13 bug bash fix (#1574) (#1584)
5f309a2 
* Fix the acc status caplitalization



* Fix the header of acc table



* Fix discover box text in get started boxes of data coneection



* Fix the description for discover icon button



* change the format of overlay msg for delete and vacuum



* Fix the font issue in acc table



* Change discover to query data



---------


(cherry picked from commit ce9db20)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 20, 2024
@opensearch-trigger-bot @github-actions
[Bug Fix] Flint datasource 2.13 bug bash fix (#1574) (#1585)
f16371b 
* Fix the acc status caplitalization



* Fix the header of acc table



* Fix discover box text in get started boxes of data coneection



* Fix the description for discover icon button



* change the format of overlay msg for delete and vacuum



* Fix the font issue in acc table



* Change discover to query data



---------


(cherry picked from commit ce9db20)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
[Bug Fix] Flint datasource 2.13 bug bash fix (opensearch-project#1574) (
85d8bcd 
opensearch-project#1585)

* Fix the acc status caplitalization

* Fix the header of acc table

* Fix discover box text in get started boxes of data coneection

* Fix the description for discover icon button

* change the format of overlay msg for delete and vacuum

* Fix the font issue in acc table

* Change discover to query data

---------

(cherry picked from commit ce9db20)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit f16371b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengweieric mengweieric mengweieric approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@ps48 ps48 ps48 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

@paulstn paulstn Awaiting requested review from paulstn

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy

Assignees
No one assigned
Labels
backport 2.x backport 2.13 bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanL1997 @ps48 @YANG-DB @mengweieric