Skip to content

Commit

Permalink
[Bug Fix] Flint datasource 2.13 bug bash fix (opensearch-project#1574)
Browse files Browse the repository at this point in the history 
* Fix the acc status caplitalization

Signed-off-by: Ryan Liang <[email protected]>

* Fix the header of acc table

Signed-off-by: Ryan Liang <[email protected]>

* Fix discover box text in get started boxes of data coneection

Signed-off-by: Ryan Liang <[email protected]>

* Fix the description for discover icon button

Signed-off-by: Ryan Liang <[email protected]>

* change the format of overlay msg for delete and vacuum

Signed-off-by: Ryan Liang <[email protected]>

* Fix the font issue in acc table

Signed-off-by: Ryan Liang <[email protected]>

* Change discover to query data

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
  • Loading branch information
@RyanL1997
RyanL1997 authored Mar 20, 2024
1 parent cffc104 commit ce9db20
Show file tree
Hide file tree
Showing 8 changed files with 60 additions and 50 deletions.
46 changes: 23 additions & 23 deletions ...nents/datasources/components/__tests__/__snapshots__/associated_objects_tab.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
Object {
"actions": Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -1286,7 +1286,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
Object {
"actions": Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -1991,7 +1991,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2017,7 +2017,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2040,7 +2040,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_0_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -2256,7 +2256,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2282,7 +2282,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2305,7 +2305,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_1_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -2521,7 +2521,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -2555,7 +2555,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2578,7 +2578,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_2_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -2890,7 +2890,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -2924,7 +2924,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2947,7 +2947,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_3_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -3259,7 +3259,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -3293,7 +3293,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -3316,7 +3316,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_4_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -3628,7 +3628,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -3662,7 +3662,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -3685,7 +3685,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_5_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -3997,7 +3997,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -4031,7 +4031,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -4054,7 +4054,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_6_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down
2 changes: 1 addition & 1 deletion ...c/components/datasources/components/__tests__/__snapshots__/data_connection.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ exports[`Data Connection Page test Renders S3 data connection page with data 1`]
<span
class="euiButtonEmpty__text"
>
Query in Discover
Query in Observability Logs
</span>
</span>
</button>
Expand Down
4 changes: 2 additions & 2 deletions public/components/datasources/components/__tests__/acceleration_table.test.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ describe('AccelerationTable Component', () => {
});

const activeStatusRows = wrapper!.find('tr.euiTableRow').filterWhere((node) => {
return node.find('.euiFlexItem').someWhere((subNode) => subNode.text() === 'active');
return node.find('.euiFlexItem').someWhere((subNode) => subNode.text() === 'Active');
});

expect(activeStatusRows.length).toBe(
Expand All @@ -177,7 +177,7 @@ describe('AccelerationTable Component', () => {
});
wrapper!.update();

const expectedLocalizedTime = 'Thu, 14 Mar 2024 04:05:53';
const expectedLocalizedTime = '3/14/2024, 4:05:53 AM';

expect(wrapper!.text()).toContain(expectedLocalizedTime);
});
Expand Down
4 changes: 2 additions & 2 deletions ...ic/components/datasources/components/manage/accelerations/acceleration_action_overlay.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ export const AccelerationActionOverlay: React.FC<AccelerationActionOverlayProps>

switch (actionType) {
case 'vacuum':
title = `Vacuum acceleration ${displayIndexName} on ${displayFullPath}?`;
title = `Vacuum acceleration ${displayIndexName} on ${displayFullPath} ?`;
description = ACC_VACUUM_MSG;
confirmButtonText = 'Vacuum';
confirmEnabled = confirmationInput === displayIndexName;
break;
case 'delete':
title = `Delete acceleration ${displayIndexName} on ${displayFullPath}?`;
title = `Delete acceleration ${displayIndexName} on ${displayFullPath} ?`;
description = ACC_DELETE_MSG;
confirmButtonText = 'Delete';
break;
Expand Down
Loading

0 comments on commit ce9db20

Please sign in to comment.