Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Flint datasource 2.13 bug bash fix #1574

Merged
merged 7 commits into from
Mar 20, 2024
Merged

[Bug Fix] Flint datasource 2.13 bug bash fix #1574

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
028b33d
Fix the acc status caplitalization
RyanL1997 Mar 19, 2024
2e088a5
Fix the header of acc table
RyanL1997 Mar 19, 2024
d9ca2c0
Fix discover box text in get started boxes of data coneection
RyanL1997 Mar 19, 2024
a359fc8
Fix the description for discover icon button
RyanL1997 Mar 19, 2024
002e9f8
change the format of overlay msg for delete and vacuum
RyanL1997 Mar 20, 2024
52230e5
Fix the font issue in acc table
RyanL1997 Mar 20, 2024
81a4f88
Change discover to query data
RyanL1997 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions ...nents/datasources/components/__tests__/__snapshots__/associated_objects_tab.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
Object {
"actions": Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -1286,7 +1286,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
Object {
"actions": Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -1991,7 +1991,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2017,7 +2017,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2040,7 +2040,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_0_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -2256,7 +2256,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2282,7 +2282,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2305,7 +2305,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_1_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -2521,7 +2521,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -2555,7 +2555,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2578,7 +2578,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_2_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -2890,7 +2890,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -2924,7 +2924,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -2947,7 +2947,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_3_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -3259,7 +3259,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -3293,7 +3293,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -3316,7 +3316,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_4_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -3628,7 +3628,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -3662,7 +3662,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -3685,7 +3685,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_5_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down Expand Up @@ -3997,7 +3997,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
actions={
Array [
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand Down Expand Up @@ -4031,7 +4031,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
<DefaultItemAction
action={
Object {
"description": "Discover this object",
"description": "Query in Observability Logs",
"icon": "discoverApp",
"name": "Discover",
"onClick": [Function],
Expand All @@ -4054,7 +4054,7 @@ exports[`AssociatedObjectsTab Component renders correctly with associated object
key="item_action_6_0"
>
<EuiToolTip
content="Discover this object"
content="Query in Observability Logs"
delay="long"
position="top"
>
Expand Down
2 changes: 1 addition & 1 deletion ...c/components/datasources/components/__tests__/__snapshots__/data_connection.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ exports[`Data Connection Page test Renders S3 data connection page with data 1`]
<span
class="euiButtonEmpty__text"
>
Query in Discover
Query in Observability Logs
</span>
</span>
</button>
Expand Down
4 changes: 2 additions & 2 deletions public/components/datasources/components/__tests__/acceleration_table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ describe('AccelerationTable Component', () => {
});

const activeStatusRows = wrapper!.find('tr.euiTableRow').filterWhere((node) => {
return node.find('.euiFlexItem').someWhere((subNode) => subNode.text() === 'active');
return node.find('.euiFlexItem').someWhere((subNode) => subNode.text() === 'Active');
});

expect(activeStatusRows.length).toBe(
Expand All @@ -177,7 +177,7 @@ describe('AccelerationTable Component', () => {
});
wrapper!.update();

const expectedLocalizedTime = 'Thu, 14 Mar 2024 04:05:53';
const expectedLocalizedTime = '3/14/2024, 4:05:53 AM';

expect(wrapper!.text()).toContain(expectedLocalizedTime);
});
Expand Down
4 changes: 2 additions & 2 deletions ...ic/components/datasources/components/manage/accelerations/acceleration_action_overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@

switch (actionType) {
case 'vacuum':
title = `Vacuum acceleration ${displayIndexName} on ${displayFullPath}?`;
title = `Vacuum acceleration ${displayIndexName} on ${displayFullPath} ?`;

Check warning on line 51 in public/components/datasources/components/manage/accelerations/acceleration_action_overlay.tsx

View check run for this annotation

Codecov / codecov/patch

public/components/datasources/components/manage/accelerations/acceleration_action_overlay.tsx#L51 

Added line #L51 was not covered by tests
description = ACC_VACUUM_MSG;
confirmButtonText = 'Vacuum';
confirmEnabled = confirmationInput === displayIndexName;
break;
case 'delete':
title = `Delete acceleration ${displayIndexName} on ${displayFullPath}?`;
title = `Delete acceleration ${displayIndexName} on ${displayFullPath} ?`;
description = ACC_DELETE_MSG;
confirmButtonText = 'Delete';
break;
Expand Down
Loading
Loading