Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queryFieldNames field in Doc Level Queries #582

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jan 31, 2024

add queryFieldNames field in Doc Level Queries. When specified this field gives the list of fields to query and fetch from all docs to be searched in the index as opposed to fetching entire _source of each document.

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (730b1f8) 74.00% compared to head (13c2cb8) 73.98%.

Files Patch % Lines
...opensearch/commons/alerting/model/DocLevelQuery.kt 69.23% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #582      +/-   ##
============================================
- Coverage     74.00%   73.98%   -0.03%     
- Complexity      890      892       +2     
============================================
  Files           133      133              
  Lines          5843     5865      +22     
  Branches        715      716       +1     
============================================
+ Hits           4324     4339      +15     
- Misses         1207     1215       +8     
+ Partials        312      311       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eirsep eirsep self-assigned this Feb 19, 2024
@eirsep eirsep marked this pull request as ready for review February 19, 2024 02:05
@eirsep eirsep requested a review from engechas as a code owner February 19, 2024 02:05
@eirsep eirsep merged commit 75925dc into opensearch-project:main Feb 19, 2024
9 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 19, 2024
* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 75925dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit that referenced this pull request Feb 19, 2024
* add queryFieldNames field in Doc Level Queries



* add tests to verify queryFieldNames field in DocLevelQuery



---------


(cherry picked from commit 75925dc)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit to eirsep/common-utils that referenced this pull request Mar 13, 2024
… (opensearch-project#597)

* add queryFieldNames field in Doc Level Queries

* add tests to verify queryFieldNames field in DocLevelQuery

---------

(cherry picked from commit 75925dc)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
engechas pushed a commit to engechas/common-utils that referenced this pull request Mar 13, 2024
* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
@engechas engechas mentioned this pull request Mar 13, 2024
5 tasks
eirsep added a commit that referenced this pull request Mar 13, 2024
* add queryFieldNames field in Doc Level Queries

* add tests to verify queryFieldNames field in DocLevelQuery

---------

(cherry picked from commit 75925dc)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
goyamegh pushed a commit to goyamegh/common-utils that referenced this pull request Mar 13, 2024
… (opensearch-project#597)

---------

(cherry picked from commit 75925dc)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
engechas added a commit that referenced this pull request Mar 13, 2024
* add logback-classic for CVE-2023-6378

Signed-off-by: Joanne Wang <[email protected]>

* updated com.pinterest:ktlint to v0.47.1

Signed-off-by: jowg-amazon <[email protected]>

* Run ktlintFormat

Signed-off-by: Chase Engelbrecht <[email protected]>

* add queryFieldNames field in Doc Level Queries (#582)

* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>

* Fix tests

Signed-off-by: Chase Engelbrecht <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: jowg-amazon <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Joanne Wang <[email protected]>
Co-authored-by: Surya Sashank Nistala <[email protected]>
jowg-amazon pushed a commit that referenced this pull request Mar 14, 2024
* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 75925dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon added a commit that referenced this pull request Mar 14, 2024
* fix cve

Signed-off-by: jowg-amazon <[email protected]>

* add queryFieldNames field in Doc Level Queries (#582)

* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 75925dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: jowg-amazon <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
goyamegh added a commit to goyamegh/common-utils that referenced this pull request Mar 15, 2024
… (opensearch-project#597)

---------

(cherry picked from commit 75925dc)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	src/test/kotlin/org/opensearch/commons/alerting/model/XContentTests.kt
jowg-amazon added a commit that referenced this pull request Mar 15, 2024
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
… (opensearch-project#597)

* add queryFieldNames field in Doc Level Queries



* add tests to verify queryFieldNames field in DocLevelQuery



---------


(cherry picked from commit 75925dc)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants