Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Backports PRs #585 and #597 to 2.11 #615

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

jowg-amazon
Copy link
Collaborator

Description

Manual backports PRs #585 and #597 to 2.11

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jowg-amazon and others added 2 commits March 13, 2024 16:28
Signed-off-by: jowg-amazon <[email protected]>
* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 75925dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 73.91%. Comparing base (bd2a4f1) to head (db2e8e9).

Files Patch % Lines
...opensearch/commons/alerting/model/DocLevelQuery.kt 72.00% 7 Missing ⚠️
...lin/org/opensearch/commons/alerting/model/Alert.kt 58.33% 4 Missing and 1 partial ⚠️
...n/org/opensearch/commons/alerting/model/Monitor.kt 28.57% 3 Missing and 2 partials ⚠️
...ch/commons/alerting/action/IndexWorkflowRequest.kt 71.42% 4 Missing ⚠️
...rch/commons/alerting/action/GetWorkflowResponse.kt 0.00% 2 Missing ⚠️
...opensearch/commons/alerting/model/action/Action.kt 0.00% 1 Missing and 1 partial ⚠️
...n/bucketselectorext/BucketSelectorExtAggregator.kt 0.00% 1 Missing ⚠️
...pensearch/commons/alerting/model/CompositeInput.kt 66.66% 1 Missing ⚠️
.../org/opensearch/commons/alerting/model/Workflow.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #615      +/-   ##
============================================
+ Coverage     73.56%   73.91%   +0.35%     
- Complexity      851      853       +2     
============================================
  Files           130      130              
  Lines          5651     5685      +34     
  Branches        696      698       +2     
============================================
+ Hits           4157     4202      +45     
+ Misses         1187     1173      -14     
- Partials        307      310       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit b7872ea into 2.11 Mar 14, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants