Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 585 and 582 to 2.5 #613

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

engechas
Copy link
Collaborator

Description

Backports for
#585
#582

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jowg-amazon and others added 5 commits March 13, 2024 10:08
Signed-off-by: Chase Engelbrecht <[email protected]>
* add queryFieldNames field in Doc Level Queries

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests to verify queryFieldNames field in DocLevelQuery

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 73.47%. Comparing base (f8c6ca4) to head (adb6e61).

Files Patch % Lines
...n/org/opensearch/commons/alerting/model/Monitor.kt 25.00% 3 Missing and 3 partials ⚠️
...n/bucketselectorext/BucketSelectorExtAggregator.kt 0.00% 4 Missing ⚠️
.../commons/alerting/model/AggregationResultBucket.kt 0.00% 4 Missing ⚠️
...lin/org/opensearch/commons/alerting/model/Alert.kt 0.00% 3 Missing and 1 partial ⚠️
...search/commons/alerting/model/QueryLevelTrigger.kt 25.00% 3 Missing ⚠️
...arch/commons/alerting/model/ClusterMetricsInput.kt 77.77% 0 Missing and 2 partials ⚠️
...opensearch/commons/alerting/model/action/Action.kt 0.00% 1 Missing and 1 partial ⚠️
...g/opensearch/commons/alerting/model/DataSources.kt 0.00% 1 Missing ⚠️
...rch/commons/alerting/model/DocLevelMonitorInput.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.5     #613      +/-   ##
============================================
+ Coverage     73.02%   73.47%   +0.44%     
- Complexity      697      700       +3     
============================================
  Files           110      110              
  Lines          4612     4645      +33     
  Branches        609      611       +2     
============================================
+ Hits           3368     3413      +45     
+ Misses          990      975      -15     
- Partials        254      257       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@engechas engechas merged commit c03386b into opensearch-project:2.5 Mar 13, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants