Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gradle task to check compability with child components #7998

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jun 10, 2023

Description

This change adds a gradle task to check the compatibility with any child projects/components. The task is dependent on publishToMavenLocal as it publishes the core engine to maven local and then clones the remote project in temporary directory and runs ./gradlew assemble.
The task takes 2 inputs:

  1. repositoryUrls: a comma separated git url of the components. Defaults to https://raw.githubusercontent.com/opensearch-project/opensearch-plugins/main/plugins/.meta
  2. ref: branch or reference to checkout. Defaults to main

Run with specific components:

./gradlew checkCompatibility
> Task :checkCompatibility
Incompatible components: [[email protected]:opensearch-project/k-nn.git, [email protected]:opensearch-project/asynchronous-search.git, [email protected]:opensearch-project/anomaly-detection.git, [email protected]:opensearch-project/observability.git, [email protected]:opensearch-project/performance-analyzer-rca.git, [email protected]:opensearch-project/performance-analyzer.git, [email protected]:opensearch-project/reporting.git, [email protected]:opensearch-project/geospatial.git, [email protected]:opensearch-project/sql.git, [email protected]:opensearch-project/cross-cluster-replication.git, [email protected]:opensearch-project/opensearch-oci-object-storage.git, [email protected]:opensearch-project/neural-search.git]
Compatible components: [[email protected]:opensearch-project/job-scheduler.git, [email protected]:opensearch-project/common-utils.git, [email protected]:opensearch-project/notifications.git, [email protected]:opensearch-project/security.git, [email protected]:opensearch-project/alerting.git, [email protected]:opensearch-project/security-analytics.git, [email protected]:opensearch-project/index-management.git, [email protected]:opensearch-project/ml-commons.git]

BUILD SUCCESSFUL in 11m 49s
983 actionable tasks: 821 executed, 90 from cache, 72 up-to-date

Run with all components:

./gradlew checkCompatibility -PrepositoryUrls=https://github.com/opensearch-project/job-scheduler.git,https://github.com/opensearch-project/common-utils.git,https://github.com/opensearch-project/asynchronous-search.git
> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git]
Compatible components: [https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git]

BUILD SUCCESSFUL in 1m 57s
837 actionable tasks: 259 executed, 578 up-to-date

BUILD SUCCESSFUL in 2m 23s
837 actionable tasks: 259 executed, 578 up-to-date

Run with specific branch

./gradlew checkCompatibility -PrepositoryUrls=https://github.com/opensearch-project/common-utils -Pref=lol

> Task :checkCompatibility
Skipping compatibility check for https://github.com/opensearch-project/common-utils
Components skipped due to git failures: [https://github.com/opensearch-project/common-utils]

BUILD SUCCESSFUL in 14s
837 actionable tasks: 255 executed, 582 up-to-date

Related Issues

opensearch-project/opensearch-devops#114 (comment)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testSingleIndexShardAllocation

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #7998 (92619ee) into main (9c5c6eb) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7998      +/-   ##
============================================
- Coverage     71.01%   70.91%   -0.11%     
+ Complexity    56695    56648      -47     
============================================
  Files          4720     4721       +1     
  Lines        267605   267654      +49     
  Branches      39213    39220       +7     
============================================
- Hits         190047   189814     -233     
- Misses        61569    61859     +290     
+ Partials      15989    15981       -8     
Impacted Files Coverage Δ
...rg/opensearch/gradle/CheckCompatibilityTask.groovy 0.00% <0.00%> (ø)

... and 458 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.indices.replication.SegmentReplicationIT.testCancellation

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@andrross andrross added the backport 2.x Backport to 2.x branch label Jun 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2023
Add compatibility check gradle task ./gradlew checkCompatibility

Signed-off-by: Sayali Gaikawad <[email protected]>
(cherry picked from commit 619aeb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jun 22, 2023
…8232)

Add compatibility check gradle task ./gradlew checkCompatibility


(cherry picked from commit 619aeb5)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…rch-project#7998) (opensearch-project#8232)

Add compatibility check gradle task ./gradlew checkCompatibility

(cherry picked from commit 619aeb5)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
…rch-project#7998)

Add compatibility check gradle task ./gradlew checkCompatibility

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
This was referenced Jun 28, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…rch-project#7998)

Add compatibility check gradle task ./gradlew checkCompatibility

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants