Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility check readiness #973

Closed
1 of 2 tasks
gaiksaya opened this issue Jun 28, 2023 · 4 comments
Closed
1 of 2 tasks

Ensure compatibility check readiness #973

gaiksaya opened this issue Jun 28, 2023 · 4 comments
Labels
v2.9.0 v2.9.0

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Jun 28, 2023

Coming from opensearch-project/opensearch-devops#114 (comment)

Overview

In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on publishToMavenLocal task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs ./gradlew assemble.

Action Items

In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:

  • The build.gradle file in this repository uses mavenLocal() as the first entry in repositories() section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks.
  • ./gradlew assemble task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.

Please close this issue once the above checklist is complete.

Thanks!

@gaiksaya gaiksaya added the v2.9.0 v2.9.0 label Jul 5, 2023
@bbarani
Copy link
Member

bbarani commented Jul 7, 2023

@praveensameneni @lezzago can you please provide an update?

@lezzago
Copy link
Member

lezzago commented Jul 8, 2023

Will have this completed by Monday

@lezzago
Copy link
Member

lezzago commented Jul 10, 2023

Currently there are new breaking changes so Alerting wont build anymore. Will get that resolved and try have this issue resolved tomorrow.

@lezzago
Copy link
Member

lezzago commented Jul 12, 2023

Maven local is the first repository: https://github.com/opensearch-project/alerting/blob/main/build.gradle#L30

./gradlew assemble passes

@lezzago lezzago closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.9.0 v2.9.0
Projects
None yet
Development

No branches or pull requests

4 participants