-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatibility check readiness #1028
Labels
Comments
@saikaranam-amazon @mohitamg can you please provide an update? |
Checked the above two Action items, the build succeeded for 2.9 branch (ran it in 2.x which is currently tracking OS 2.9.0)
|
Thanks Mohit, will close the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Coming from opensearch-project/opensearch-devops#114 (comment)
Overview
In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on
publishToMavenLocal
task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs./gradlew assemble
.Action Items
In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:
mavenLocal()
as the first entry inrepositories()
section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks../gradlew assemble
task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.Please close this issue once the above checklist is complete.
Thanks!
The text was updated successfully, but these errors were encountered: