Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility #2178

aponb · 2022-02-20T12:27:13Z

Description

Replacing the exclusionary words whitelist and blacklist that won't impact the compatibility. Changes just in code comments, internal variables, methods and class names.

Issues Resolved

This Pull request replaces Pull request #1970
Resolve #1484

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andreas [email protected]

…tibility. Signed-off-by: Andreas <[email protected]>

opensearch-ci-bot · 2022-02-20T12:28:02Z

Can one of the admins verify this patch?

opensearch-ci-bot · 2022-02-20T13:10:02Z

✅ Gradle Check success 097ca57
Log 2627

Reports 2627

tlfeng

Thanks for the change! 👍

nknize · 2022-02-25T17:11:38Z

Can we rebase and merge this?

tlfeng · 2022-03-02T21:31:45Z

Hi @aponb, could you please resolve the conflicts, by either manually, or merge/rebase the upstream main branch to your feature branch? So that your code change can be merged. We would ship this change in version 1.3.0 release.

aponb · 2022-03-03T21:47:49Z

Hi @aponb, could you please resolve the conflicts, by either manually, or merge/rebase the upstream main branch to your feature branch? So that your code change can be merged. We would ship this change in version 1.3.0 release.

I merged the new changes. I pushed my branch, and tests are running now!

opensearch-ci-bot · 2022-03-03T22:05:43Z

❌ Gradle Check failure d309ac51113e6da0ff00ab6d6c3434b2f39e01b7
Log 2994

Reports 2994

dblock · 2022-03-03T22:57:26Z

* What went wrong:
Execution failed for task ':qa:full-cluster-restart:v1.3.0#oldClusterTest'.
> There were failing tests. See the report at: file:///var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/qa/full-cluster-restart/build/reports/tests/v1.3.0%23oldClusterTest/index.html

#1793

dblock · 2022-03-03T22:57:34Z

start gradle check

opensearch-ci-bot · 2022-03-03T23:19:25Z

❌ Gradle Check failure d309ac51113e6da0ff00ab6d6c3434b2f39e01b7
Log 3002

Reports 3002

tlfeng · 2022-03-03T23:24:23Z

In log 3002:


REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery" -Dtests.seed=9E55F733A653B468 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=Australia/Perth -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testOperationBasedRecovery FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:46235], URI [/testoperationbasedrecovery], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testoperationbasedrecovery"}
        at __randomizedtesting.SeedInfo.seed([9E55F733A653B468:83B9FB16A0D54E1F]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery(FullClusterRestartIT.java:1289)

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testSnapshotRestore" -Dtests.seed=9E55F733A653B468 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=Australia/Perth -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testSnapshotRestore FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:46235], URI [/testsnapshotrestore], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testsnapshotrestore"}
        at __randomizedtesting.SeedInfo.seed([9E55F733A653B468:A1301DCA6CEEB317]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testSnapshotRestore(FullClusterRestartIT.java:810)

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testResize" -Dtests.seed=9E55F733A653B468 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=Australia/Perth -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testResize FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:39569], URI [/testresize], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testresize"}
        at __randomizedtesting.SeedInfo.seed([9E55F733A653B468:292AEDC7B9152E53]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testResize(FullClusterRestartIT.java:1387)

aponb · 2022-03-04T16:43:32Z

In log 3002:


REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery" -Dtests.seed=9E55F733A653B468 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=Australia/Perth -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testOperationBasedRecovery FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:46235], URI [/testoperationbasedrecovery], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testoperationbasedrecovery"}
        at __randomizedtesting.SeedInfo.seed([9E55F733A653B468:83B9FB16A0D54E1F]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery(FullClusterRestartIT.java:1289)

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testSnapshotRestore" -Dtests.seed=9E55F733A653B468 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=Australia/Perth -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testSnapshotRestore FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:46235], URI [/testsnapshotrestore], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testsnapshotrestore"}
        at __randomizedtesting.SeedInfo.seed([9E55F733A653B468:A1301DCA6CEEB317]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testSnapshotRestore(FullClusterRestartIT.java:810)

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testResize" -Dtests.seed=9E55F733A653B468 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=Australia/Perth -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testResize FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:39569], URI [/testresize], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testresize"}
        at __randomizedtesting.SeedInfo.seed([9E55F733A653B468:292AEDC7B9152E53]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testResize(FullClusterRestartIT.java:1387)

I also got this error first. By providing a JAVA11_HOME and a JAVA8_HOME on my local machine the test did pass. Strange, that the check is not working on the server.

andrross · 2022-03-04T17:28:48Z

@aponb that error is unrelated to this change and was fixed in #2334. You may need to rebase the latest changes to get the fix.

opensearch-ci-bot · 2022-03-04T20:59:03Z

❌ Gradle Check failure bb0ada8e5d06025c09394b947a03b270fb71586b
Log 3052

Reports 3052

… into replace-whitelist-blacklist Signed-off-by: Andreas <[email protected]>

opensearch-ci-bot · 2022-03-04T21:18:35Z

✅ Gradle Check success 24e3bf181d55d1cc5b37c996351ba9d372082fab
Log 3053

Reports 3053

opensearch-ci-bot · 2022-03-04T21:54:47Z

✅ Gradle Check success fdd8a6e
Log 3055

Reports 3055

aponb · 2022-03-04T22:04:28Z

@aponb that error is unrelated to this change and was fixed in #2334. You may need to rebase the latest changes to get the fix.

thanks. Looks green now.

tlfeng · 2022-03-04T22:44:49Z

Thanks @aponb for your constant quick response! I will merge it today.

opensearch-trigger-bot · 2022-03-05T00:35:09Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2178-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 be64af2f90cfa16dca83f0a945c946f7e25d6d71
# Push it to GitHub
git push --set-upstream origin backport/backport-2178-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2178-to-1.x.

aponb · 2022-03-05T06:18:48Z

Thanks @aponb for your constant quick response! I will merge it today.

Thanks again to you and also the others for your help!

tlfeng · 2022-03-05T06:24:08Z

Hi @aponb , you are very welcome! 😄
The automatic backport workflow failed, maybe there are some conflicts with your commit and 1.x branch.
Would you mind create a PR manually to backport the change into 1.x? So that the change can be included in version 1.3.0 , the code freeze date is Mar.9th (PST)
Even if you don't have enough time, we can help you create the backport PR.

… won't impact backwards compatibility (opensearch-project#2178) * Replace the exclusionary word whitelist with allowlist, and blacklist with denylist, in code commet and internal variable/method/class/package name. Signed-off-by: Andreas <[email protected]>

aponb · 2022-03-05T14:06:02Z

Hi @aponb , you are very welcome! smile The automatic backport workflow failed, maybe there are some conflicts with your commit and 1.x branch. Would you mind create a PR manually to backport the change into 1.x? So that the change can be included in version 1.3.0 , the code freeze date is Mar.9th (PST) Even if you don't have enough time, we can help you create the backport PR.

ok. I created a backport of the changes. See #2365

This includes the following: commit 9cfa395 Author: Kartik <[email protected]> Date: Thu Mar 10 10:12:17 2022 -0800 Remove the IndexCommitRef class (opensearch-project#2421) This inner class is no longer required because its functionality has been moved to the generic GatedCloseable class. Signed-off-by: Kartik Ganesh <[email protected]> commit c8d8009 Author: Andriy Redko <[email protected]> Date: Thu Mar 10 11:46:08 2022 -0500 Fixing bwcVersions and bwc builds (opensearch-project#2430) - adding 1.4.0 into main bwcVersions Signed-off-by: Andriy Redko <[email protected]> commit fb9e150 Author: Kartik <[email protected]> Date: Wed Mar 9 12:21:09 2022 -0800 Refactoring gated and ref-counted interfaces and their implementations (opensearch-project#2396) * Reducing duplication in plugins around ref-counted releasable classes Both AmazonEc2Reference and AmazonS3Reference duplicate the same logic - a subclass of AbstractRefCounted that also implements Releasable. This change centralizes this paradigm into a AbstractRefCountedReleasable class and supports both clients via generics. It also updates all fetching implementations to use the get() method instead of client() Signed-off-by: Kartik Ganesh <[email protected]> * Introduce Reference classes for the Closeable and AutoCloseable interfaces These classes allow you to wrap a reference instance with an onClose runnable that is executed when close() is invoked. Two separate classes are needed because the close() signatures for the two interfaces are different. This change takes the first step to have implementing classes extend from these generic superclasses, before attempting to remove the subclasses entirely. The get() method is also replaced throughout the code base. Note that there is also a separate Releasable interface that has a similar access pattern, but is implemented separately. This is used in AbstractRefCountedReleasable introduced in a prior commit Signed-off-by: Kartik Ganesh <[email protected]> * More improvements and refactoring * Functionality around one-way gating is now moved to a dedicated class - OneWayGate. This replaces duplicate functionality throughout the code. * The two *Reference classes have been renamed to Gated* since that better represents their functionality * The AbstractRefCountedReleasable has been improved to no longer be abstract by accepting the shutdown hook. This removes the need for the inner class in ReleasableBytesReference, and further simplifies the plugin subclasses (these could probably be removed entirely). * Finally, unit tests have been added for some classes Signed-off-by: Kartik Ganesh <[email protected]> * Added tests for GatedCloseable Also updated the license information in GatedAutoCloseableTests Signed-off-by: Kartik Ganesh <[email protected]> * Fixing license information in new files Signed-off-by: Kartik Ganesh <[email protected]> * Added unit tests for RefCountedReleasable Signed-off-by: Kartik Ganesh <[email protected]> commit 5a9a114 Author: Nick Knize <[email protected]> Date: Wed Mar 9 12:50:05 2022 -0600 [Remove] TrimUnsafeCommit logic for legacy 6.x indexes (opensearch-project#2225) * [Remove] TrimUnsafeCommit logic for legacy 6.x indexes Multiple txlog commits was introduced in legacy 7.x. Legacy 6.x indexes could therefore not have a safe commit. Since OpenSearch 2.0 is no longer compatible with legacy 6.x indexes, the logic to trim these unsafe commits is safely removed. Signed-off-by: Nicholas Walter Knize <[email protected]> * fix assertion typo Signed-off-by: Nicholas Walter Knize <[email protected]> * rebase and incorporate pr feedback Signed-off-by: Nicholas Walter Knize <[email protected]> commit 9c679cb Author: Andriy Redko <[email protected]> Date: Tue Mar 8 18:42:32 2022 -0500 MapperService has to be passed in as null for EnginePlugins CodecService constructor (opensearch-project#2177) * MapperService has to be passed in as null for EnginePlugins CodecService constructor Signed-off-by: Andriy Redko <[email protected]> * Addressing code review comments Signed-off-by: Andriy Redko <[email protected]> * Delayed CodecService instantiation up to the shard initialization Signed-off-by: Andriy Redko <[email protected]> * Added logger (associated with shard) to CodecServiceConfig Signed-off-by: Andriy Redko <[email protected]> * Refactored the EngineConfigFactory / IndexShard instantiation of the CodecService Signed-off-by: Andriy Redko <[email protected]> commit a6a47e7 Author: Suraj Singh <[email protected]> Date: Tue Mar 8 14:43:04 2022 -0800 Remove inclue_type_name parameter from rest api spec (opensearch-project#2410) Signed-off-by: Suraj Singh <[email protected]> commit 044f536 Author: Daniel Doubrovkine (dB.) <[email protected]> Date: Tue Mar 8 14:48:51 2022 -0500 Set target and source compatibility to 11, required by Lucene 9. (opensearch-project#2407) * Set target and source compatibility to 11, required by Lucene 9. Signed-off-by: dblock <[email protected]> * Uncomment commented code in opensearch-project#2321 for killing child processes that uses JDK9+ ProcessInfo. Signed-off-by: dblock <[email protected]> * Set distribution checker target JDK compatibility to 11. Signed-off-by: dblock <[email protected]> * Supress processing warnings. Signed-off-by: dblock <[email protected]> commit c3712a5 Author: Nick Knize <[email protected]> Date: Tue Mar 8 11:30:27 2022 -0600 [Remove] include_type_name from HLRC (opensearch-project#2397) Removes include_type_name from the high level reset client along with relevant deprecated methods in IndicesClient. All tests are updated to remove the parameter from the rest requests along with various toXContent methods that are no longer required. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 63c75d1 Author: Tianli Feng <[email protected]> Date: Tue Mar 8 08:35:36 2022 -0800 Deprecate setting 'reindex.remote.whitelist' and introduce the alternative setting 'reindex.remote.allowlist' (opensearch-project#2221) * Add setting reindex.remote.allowlist, and deprecate setting reindex.remote.whitelist Signed-off-by: Tianli Feng <[email protected]> * Add unit test for renaming the setting reindex.remote.allowlist Signed-off-by: Tianli Feng <[email protected]> * Remove system.out.println() Signed-off-by: Tianli Feng <[email protected]> * Adjust format by spotlessApply task Signed-off-by: Tianli Feng <[email protected]> * Replace REMOTE_CLUSTER_WHITELIST with REMOTE_CLUSTER_ALLOWLIST Signed-off-by: Tianli Feng <[email protected]> * Add a unit test to test final setting value when both settings have got a value Signed-off-by: Tianli Feng <[email protected]> * Rename the unit test class name Signed-off-by: Tianli Feng <[email protected]> * Remove the Access modifiers public from the constant REMOTE_CLUSTER_WHITELIST Signed-off-by: Tianli Feng <[email protected]> * Initialize ReindexPlugin without using the @before method Signed-off-by: Tianli Feng <[email protected]> * Rename 'unwhitelisted' to 'unallowlisted' in a yml file used for REST api testing. Signed-off-by: Tianli Feng <[email protected]> commit 65debde Author: Andriy Redko <[email protected]> Date: Tue Mar 8 11:30:48 2022 -0500 Update the BWC versions (post 1.x backport) (opensearch-project#2390) Signed-off-by: Andriy Redko <[email protected]> commit 919d180 Author: Suraj Singh <[email protected]> Date: Mon Mar 7 12:43:05 2022 -0800 Remove type end-points from count action (opensearch-project#2379) Signed-off-by: Suraj Singh <[email protected]> commit 1f0361a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 10:28:17 2022 -0800 Bump asm-commons from 5.0.4 to 9.2 in /modules/lang-expression (opensearch-project#2385) * Bump asm-commons from 5.0.4 to 9.2 in /modules/lang-expression Bumps asm-commons from 5.0.4 to 9.2. --- updated-dependencies: - dependency-name: org.ow2.asm:asm-commons dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 09e16e3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 13:08:07 2022 -0500 Bump guava from 30.1.1-jre to 31.1-jre in /plugins/repository-azure (opensearch-project#2382) * Bump guava from 30.1.1-jre to 31.1-jre in /plugins/repository-azure Bumps [guava](https://github.com/google/guava) from 30.1.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit e1fd4b7 Author: Subhobrata Dey <[email protected]> Date: Mon Mar 7 08:51:49 2022 -0800 Add valuesField in PercentilesAggregationBuilder streamInput constructor (opensearch-project#2308) Signed-off-by: Subhobrata Dey <[email protected]> commit 4395ed5 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:48:38 2022 -0500 Bump guava in /distribution/tools/upgrade-cli (opensearch-project#2383) Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 72c5d81 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:48:18 2022 -0500 Bump guava in /distribution/tools/keystore-cli (opensearch-project#2384) Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 75e837d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:48:00 2022 -0500 Bump guava from 31.0.1-jre to 31.1-jre in /distribution/tools/plugin-cli (opensearch-project#2387) Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3e9031f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 7 11:47:37 2022 -0500 Bump gradle-extra-configurations-plugin from 3.0.3 to 7.0.0 in /buildSrc (opensearch-project#2386) Bumps [gradle-extra-configurations-plugin](https://github.com/nebula-plugins/gradle-extra-configurations-plugin) from 3.0.3 to 7.0.0. - [Release notes](https://github.com/nebula-plugins/gradle-extra-configurations-plugin/releases) - [Changelog](https://github.com/nebula-plugins/gradle-extra-configurations-plugin/blob/main/CHANGELOG.md) - [Commits](nebula-plugins/gradle-extra-configurations-plugin@v3.0.3...v7.0.0) --- updated-dependencies: - dependency-name: com.netflix.nebula:gradle-extra-configurations-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9224537 Author: Owais Kazi <[email protected]> Date: Fri Mar 4 16:58:13 2022 -0800 Updated the url for docker distribution (opensearch-project#2325) Signed-off-by: Owais Kazi <[email protected]> commit d5e58a2 Author: Suraj Singh <[email protected]> Date: Fri Mar 4 16:40:47 2022 -0800 [Remove] Type mappings from GeoShapeQueryBuilder (opensearch-project#2322) * Remove type end-points from GeoShapeBuilder Signed-off-by: Suraj Singh <[email protected]> * Fix integration test failures Signed-off-by: Suraj Singh <[email protected]> commit be64af2 Author: aponb <[email protected]> Date: Sat Mar 5 01:34:09 2022 +0100 Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility (opensearch-project#2178) * Replace the exclusionary word whitelist with allowlist, and blacklist with denylist, in code commet and internal variable/method/class/package name. Signed-off-by: Andreas <[email protected]> commit ae52008 Author: Andriy Redko <[email protected]> Date: Fri Mar 4 17:44:52 2022 -0500 Fixing the --release flag usage for javac (opensearch-project#2343) (opensearch-project#2352) * Fixing the --release flag usage for javac (opensearch-project#2343) * Fixing the --release flag usage for javac Signed-off-by: Andriy Redko <[email protected]> * Fixing the --html5 flag usage for javadoc Signed-off-by: Andriy Redko <[email protected]> * Fix java-version-checker source/target compatibility settings (opensearch-project#2354) Signed-off-by: Andriy Redko <[email protected]> commit 0cc2c9b Author: Nick Knize <[email protected]> Date: Fri Mar 4 13:30:43 2022 -0600 [Remove] types from PutMappingRequest (opensearch-project#2335) Remove type support from putMappingRequest, dependencies, and all tests. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 729bc43 Author: Nick Knize <[email protected]> Date: Fri Mar 4 10:52:24 2022 -0600 [Test-Failure] Mute TranslogPolicyIT (opensearch-project#2342) This test is slated for removal as it only applies to ancient indexes (Legacy 6.x). Muting test so bwc tests are consistent and no longer angry. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 5f90227 Author: Andriy Redko <[email protected]> Date: Fri Mar 4 11:12:27 2022 -0500 Add '_name' field support to score functions and provide it back in explanation response (opensearch-project#2244) * Add '_name' field support to score functions and provide it back in explanation response Signed-off-by: Andriy Redko <[email protected]> * Address code review comments Signed-off-by: Andriy Redko <[email protected]> commit ae14259 Author: Daniel Doubrovkine (dB.) <[email protected]> Date: Thu Mar 3 15:34:53 2022 -0500 Restore Java 8 compatibility for build tools. (opensearch-project#2300) (opensearch-project#2321) * Restore Java 8 compatibility for build tools. Signed-off-by: dblock <[email protected]> * Make source code compatible with Java 8. Signed-off-by: dblock <[email protected]> commit cb57b92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Mar 3 14:23:47 2022 -0500 Bump log4j-core in /buildSrc/src/testKit/thirdPartyAudit/sample_jars (opensearch-project#2281) Bumps log4j-core from 2.17.1 to 2.17.2. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit cdb42ad Author: Vacha Shah <[email protected]> Date: Thu Mar 3 10:39:27 2022 -0800 Remove Github DCO action since DCO runs via Github App now (opensearch-project#2317) Signed-off-by: Vacha Shah <[email protected]> commit f13b951 Author: Andrey Pleskach <[email protected]> Date: Wed Mar 2 23:36:09 2022 +0100 Add support of SOCKS proxies for S3 repository (opensearch-project#2160) Signed-off-by: Andrey Pleskach <[email protected]> commit 3d5aff4 Author: Suraj Singh <[email protected]> Date: Wed Mar 2 13:21:00 2022 -0800 Remove type end-points from search and related APIs (opensearch-project#2263) Signed-off-by: Suraj Singh <[email protected]> commit 897f4e7 Author: Nick Knize <[email protected]> Date: Wed Mar 2 13:44:04 2022 -0600 [Remove] deprecated getMapping API from IndicesClient (opensearch-project#2262) Removes the deprecated types based get, getMapping, getAsync, and getMappingAsync methods from IndicesClient. It also removes extra nesting of mappings belong the deprecated type named object and removes the types based methods from the affected request classes. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 4b89410 Author: Breno Faria <[email protected]> Date: Wed Mar 2 19:52:38 2022 +0100 Reintroduce negative epoch_millis opensearch-project#1991 (opensearch-project#2232) * Reintroduce negative epoch_millis opensearch-project#1991 Fixes a regression introduced with Elasticsearch 7 regarding the date field type that removed support for negative timestamps with sub-second granularity. Thanks to Ryan Kophs (https://github.com/rkophs) for allowing me to use his previous work. Signed-off-by: Breno Faria <[email protected]> * applying spotless fix Signed-off-by: Breno Faria <[email protected]> * more conservative implementation of isSupportedBy Signed-off-by: Breno Faria <[email protected]> * adding braces to control flow statement Signed-off-by: Breno Faria <[email protected]> * spotless fix... Signed-off-by: Breno Faria <[email protected]> Co-authored-by: Breno Faria <[email protected]> commit 9e225dc Author: Peng Huo <[email protected]> Date: Wed Mar 2 10:34:02 2022 -0800 Fix flaky test case - string profiler via global ordinals (opensearch-project#2226) forcemerge to one segment before executing aggregation query. Signed-off-by: Peng Huo <[email protected]> commit c8a7606 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:18:28 2022 -0800 Bump commons-math3 from 3.2 to 3.6.1 in /benchmarks (opensearch-project#2282) Bumps commons-math3 from 3.2 to 3.6.1. --- updated-dependencies: - dependency-name: org.apache.commons:commons-math3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1b8181c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:17:16 2022 -0800 Bump gson from 2.8.9 to 2.9.0 in /plugins/repository-hdfs (opensearch-project#2279) * Bump gson from 2.8.9 to 2.9.0 in /plugins/repository-hdfs Bumps [gson](https://github.com/google/gson) from 2.8.9 to 2.9.0. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.9...gson-parent-2.9.0) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 0df9845 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:16:56 2022 -0800 Bump morfologik-fsa from 2.1.1 to 2.1.8 in /plugins/analysis-ukrainian (opensearch-project#2278) * Bump morfologik-fsa from 2.1.1 to 2.1.8 in /plugins/analysis-ukrainian Bumps [morfologik-fsa](https://github.com/morfologik/morfologik-stemming) from 2.1.1 to 2.1.8. - [Release notes](https://github.com/morfologik/morfologik-stemming/releases) - [Changelog](https://github.com/morfologik/morfologik-stemming/blob/master/CHANGES.txt) - [Commits](morfologik/morfologik-stemming@2.1.1...2.1.8) --- updated-dependencies: - dependency-name: org.carrot2:morfologik-fsa dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 9780fc6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 12:16:34 2022 -0800 Bump bc-fips from 1.0.2.1 to 1.0.2.3 in /distribution/tools/plugin-cli (opensearch-project#2276) * Bump bc-fips from 1.0.2.1 to 1.0.2.3 in /distribution/tools/plugin-cli Bumps bc-fips from 1.0.2.1 to 1.0.2.3. --- updated-dependencies: - dependency-name: org.bouncycastle:bc-fips dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 4ef30f4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:41:46 2022 -0800 Bump azure-storage-common from 12.14.0 to 12.14.3 in /plugins/repository-azure (opensearch-project#2274) * Bump azure-storage-common in /plugins/repository-azure Bumps [azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.14.0 to 12.14.3. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.14.0...azure-storage-blob_12.14.3) --- updated-dependencies: - dependency-name: com.azure:azure-storage-common dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 5d0b015 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:41:33 2022 -0800 Bump jimfs from 1.1 to 1.2 in /distribution/tools/keystore-cli (opensearch-project#2272) Bumps [jimfs](https://github.com/google/jimfs) from 1.1 to 1.2. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.1...v1.2) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f6264a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:41:18 2022 -0800 Bump spock-core from 2.0-groovy-3.0 to 2.1-groovy-3.0 in /buildSrc (opensearch-project#2270) Bumps spock-core from 2.0-groovy-3.0 to 2.1-groovy-3.0. --- updated-dependencies: - dependency-name: org.spockframework:spock-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 21f11ec Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 28 10:40:51 2022 -0800 Bump asm-tree from 5.0.4 to 9.2 in /modules/lang-expression (opensearch-project#2269) * Bump asm-tree from 5.0.4 to 9.2 in /modules/lang-expression Bumps asm-tree from 5.0.4 to 9.2. --- updated-dependencies: - dependency-name: org.ow2.asm:asm-tree dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> commit 223d0b2 Author: Suraj Singh <[email protected]> Date: Fri Feb 25 13:00:25 2022 -0800 Remove type end-points from no-op bulk and search action (opensearch-project#2261) Signed-off-by: Suraj Singh <[email protected]> commit 0bd7850 Author: Nick Knize <[email protected]> Date: Fri Feb 25 13:35:48 2022 -0600 [Remove] remaining type usage in Client and AbstractClient (opensearch-project#2258) Removes type parameter from remaining prepareIndex in Client and AbstractClient. Signed-off-by: Nicholas Walter Knize <[email protected]> commit 3a4c2f6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Feb 25 10:40:11 2022 -0800 Bump jimfs from 1.1 to 1.2 in /qa/evil-tests (opensearch-project#2130) * Bump jimfs from 1.1 to 1.2 in /qa/evil-tests Bumps [jimfs](https://github.com/google/jimfs) from 1.1 to 1.2. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.1...v1.2) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fixing failing precommit and check Signed-off-by: Vacha Shah <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vacha Shah <[email protected]> commit 5b0da85 Author: Suraj Singh <[email protected]> Date: Fri Feb 25 10:18:41 2022 -0800 Remove type from validate query API (opensearch-project#2255) * Remove type mapping from RestValidateAction Signed-off-by: Suraj Singh <[email protected]> * Spotless check apply Signed-off-by: Suraj Singh <[email protected]> * Include suggested review comment Signed-off-by: Suraj Singh <[email protected]> commit 494c7bc Author: Rishikesh Pasham <[email protected]> Date: Fri Feb 25 03:39:43 2022 +0000 Revert "Override Default Distribution Download Url with Custom Distribution Url When User Passes a Url" (opensearch-project#2256) * Override default Distribution Download URL with custom Distribution URL Signed-off-by: Rishikesh1159 <[email protected]> * Accidently made commit to main branch, this revives it.Override default Distribution Download URL with custom Distribution URL Signed-off-by: Rishikesh1159 <[email protected]> * Revert Override Default Distribution Download Url with Custom Distribution Url When User Passes a Url Signed-off-by: Rishikesh1159 <[email protected]> commit 8b48207 Author: Nick Knize <[email protected]> Date: Thu Feb 24 21:20:03 2022 -0600 [Remove] Type from Client.prepare(Index,Delete,Update) (opensearch-project#2253) Removes the type parameter from Client.prepare(Index,Delete,Update) and everywhere it's used throughout the codebase except for prepareIndex(index, type, id) which is removed in a follow up. Signed-off-by: Nicholas Walter Knize <[email protected]> Merge branch 'main' into feature/segment-replication Signed-off-by: Kartik Ganesh <[email protected]>

…ethod names (#2784) (#2812) This is the last commit for replacing non-inclusive terminology `blacklist`. Most of the internal usages of non-inclusive terminology `blacklist/whitelist` was replaced by PR #2178, while there are a few remaining. - Replace `blacklist` with `denylist` in internal class and method names. Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit 47a22bb)

…ethod names (#2784) (#2813) This is the last commit for replacing non-inclusive terminology `blacklist`. Most of the internal usages of non-inclusive terminology `blacklist/whitelist` was replaced by PR #2178, while there are a few remaining. - Replace `blacklist` with `denylist` in internal class and method names. Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit 47a22bb)

aponb added 4 commits February 20, 2022 13:14

Replacing the exclusionary word whitelist that won't impact the compa…

58ef0f4

…tibility. Signed-off-by: Andreas <[email protected]>

Replacing the exclusionary word blacklist that won't impact the compa…

cf5d106

…tibility. Signed-off-by: Andreas <[email protected]>

Replacing the exclusionary word blacklist that won't impact the compa…

c9ec898

…tibility. Signed-off-by: Andreas <[email protected]>

Replacing the exclusionary word whitelist that won't impact the compa…

097ca57

…tibility. Signed-off-by: Andreas <[email protected]>

aponb requested a review from a team as a code owner February 20, 2022 12:27

aponb mentioned this pull request Feb 20, 2022

Replacing the exclusionary words whitelist and blacklist that won't impact the compatibility. #1970

Closed

tlfeng changed the title ~~Replace whitelist blacklist~~ Replace exclusionary words whitelist and blacklist in the places that the compatibility is not impacted Feb 21, 2022

tlfeng changed the title ~~Replace exclusionary words whitelist and blacklist in the places that the compatibility is not impacted~~ Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility Feb 21, 2022

tlfeng linked an issue Feb 21, 2022 that may be closed by this pull request

Replace "blacklist/whitelist" terminology in code comments, and internal variable, method and class names #1484

Closed

tlfeng mentioned this pull request Feb 23, 2022

Deprecate setting 'reindex.remote.whitelist' and introduce the alternative setting 'reindex.remote.allowlist' #2221

Merged

5 tasks

tlfeng added backport 1.x enhancement Enhancement or improvement to existing feature or request v1.3.0 v2.0.0 Version 2.0.0 labels Feb 23, 2022

tlfeng approved these changes Feb 23, 2022

View reviewed changes

aponb force-pushed the replace-whitelist-blacklist branch from bb0ada8 to 24e3bf1 Compare March 4, 2022 20:31

Merge branch 'main' of https://github.com/opensearch-project/OpenSearch…

fdd8a6e

… into replace-whitelist-blacklist Signed-off-by: Andreas <[email protected]>

aponb force-pushed the replace-whitelist-blacklist branch from 24e3bf1 to fdd8a6e Compare March 4, 2022 21:16

tlfeng merged commit be64af2 into opensearch-project:main Mar 5, 2022

tlfeng added the pending backport Identifies an issue or PR that still needs to be backported label Mar 5, 2022

aponb mentioned this pull request Mar 5, 2022

Replace exclusionary words whitelist and blacklist in the places that… #2365

Merged

tlfeng mentioned this pull request Apr 6, 2022

Replace remaining 'blacklist' with 'denylist' in internal class and method names #2784

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility #2178

Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility #2178

aponb commented Feb 20, 2022 •

edited by tlfeng

Loading

opensearch-ci-bot commented Feb 20, 2022

opensearch-ci-bot commented Feb 20, 2022

tlfeng left a comment

nknize commented Feb 25, 2022

tlfeng commented Mar 2, 2022

aponb commented Mar 3, 2022

opensearch-ci-bot commented Mar 3, 2022

dblock commented Mar 3, 2022

dblock commented Mar 3, 2022

opensearch-ci-bot commented Mar 3, 2022

tlfeng commented Mar 3, 2022

aponb commented Mar 4, 2022

andrross commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

aponb commented Mar 4, 2022

tlfeng commented Mar 4, 2022

opensearch-trigger-bot bot commented Mar 5, 2022

aponb commented Mar 5, 2022

tlfeng commented Mar 5, 2022 •

edited

Loading

aponb commented Mar 5, 2022

Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility #2178

Replace exclusionary words whitelist and blacklist in the places that won't impact backwards compatibility #2178

Conversation

aponb commented Feb 20, 2022 • edited by tlfeng Loading

opensearch-ci-bot commented Feb 20, 2022

opensearch-ci-bot commented Feb 20, 2022

tlfeng left a comment

Choose a reason for hiding this comment

nknize commented Feb 25, 2022

tlfeng commented Mar 2, 2022

aponb commented Mar 3, 2022

opensearch-ci-bot commented Mar 3, 2022

dblock commented Mar 3, 2022

dblock commented Mar 3, 2022

opensearch-ci-bot commented Mar 3, 2022

tlfeng commented Mar 3, 2022

aponb commented Mar 4, 2022

andrross commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

opensearch-ci-bot commented Mar 4, 2022

aponb commented Mar 4, 2022

tlfeng commented Mar 4, 2022

opensearch-trigger-bot bot commented Mar 5, 2022

aponb commented Mar 5, 2022

tlfeng commented Mar 5, 2022 • edited Loading

aponb commented Mar 5, 2022

aponb commented Feb 20, 2022 •

edited by tlfeng

Loading

tlfeng commented Mar 5, 2022 •

edited

Loading