-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace exclusionary words whitelist and blacklist in the places that… #2365
Conversation
… won't impact backwards compatibility (opensearch-project#2178) * Replace the exclusionary word whitelist with allowlist, and blacklist with denylist, in code commet and internal variable/method/class/package name. Signed-off-by: Andreas <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Andreas <[email protected]>
I think it can be merged after resolving the conflict in |
anything I can do? |
Signed-off-by: Andreas <[email protected]>
Thank you! Yeah.. there are many new commits being merged recently. |
There are 2 problems in the log 3133:
The first "failed for task ':qa:full-cluster-restart:v1.2.5#oldClusterTest'." is not likely caused by this PR, but the second one ( |
// and whitelist this hack in JarHell | ||
api 'javax.xml.bind:jaxb-api:2.3.1' | ||
// and allowlist this hack in JarHell | ||
api 'javax.xml.bind:jaxb-api:2.2.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the newer version number 2.3.1, the version was updated in this commit: e54656e
api 'javax.xml.bind:jaxb-api:2.2.2' | |
api 'javax.xml.bind:jaxb-api:2.3.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Respect. You have a lot of patience. Sorry for that, I missed that. It's fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are very welcome! 😄 Glad you are so responsive.
Signed-off-by: Andreas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validated all the changes in the backport PR is the same with those that merged in main
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Description
… won't impact backwards compatibility (#2178)
Issues Resolved
backport of #2178 for 1.x
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Andreas [email protected]