[Remove] types from PutMappingRequest

[nknize]

Remove type support from putMappingRequest, dependencies, and all tests.

relates #1940

[opensearch-ci-bot]

Can one of the admins verify this patch?

[opensearch-ci-bot]

❌   Gradle Check failure 9f2912acefcc74760ccbb6432674934625fd1530
Log 3005

Reports 3005

[opensearch-ci-bot]

❌   Gradle Check failure b6eda0e4ea3155392a5d8957b8729a19e155b1da
Log 3006

Reports 3006

[opensearch-ci-bot]

❌   Gradle Check failure 8e71e967b9da95e55ac66d7110e64b6f91f8130b
Log 3008

Reports 3008

[dreamer-89]

The latest job fails testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration test due to assertion error.

REPRODUCE WITH: ./gradlew ':plugins:mapper-size:internalClusterTest' --tests "org.opensearch.index.mapper.size.SizeMappingIT.testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration" -Dtests.seed=4F62945A913A057D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pt -Dtests.timezone=Australia/Currie -Druntime.java=17

org.opensearch.index.mapper.size.SizeMappingIT > testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration FAILED
    java.lang.AssertionError: Expected size field mapping to be enabled for foo
    Expected: map containing ["_size"->ANYTHING]
         but: map was [<properties={otherField={type=text}}>]
        at __randomizedtesting.SeedInfo.seed([4F62945A913A057D:D988F27324556493]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.opensearch.index.mapper.size.SizeMappingIT.assertSizeMappingEnabled(SizeMappingIT.java:119)
        at org.opensearch.index.mapper.size.SizeMappingIT.testThatUpdatingMappingShouldNotRemoveSizeMappingConfiguration(SizeMappingIT.java:85)
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/home/ubuntu/.gradle/wrapper/dists/gradle-7.3.3-all/4295vidhdd9hd3gbjyw1xqxpo/gradle-7.3.3/lib/plugins/gradle-testing-base-7.3.3.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

[dreamer-89]

start gradle check

[nknize]

There are still a few other failures as well.. Getting ready to push an update

[opensearch-ci-bot]

❌   Gradle Check failure 8e71e967b9da95e55ac66d7110e64b6f91f8130b
Log 3011

Reports 3011

[opensearch-ci-bot]

❌   Gradle Check failure 54cf66eedd8e9822a3296afed435783464a723c7
Log 3013

Reports 3013

[opensearch-ci-bot]

❌   Gradle Check failure f08f97bbfd6d52ea486a162c22dd7c1ecc916339
Log 3014

Reports 3014

[opensearch-ci-bot]

❌   Gradle Check failure 5895febddfb05a506e7da4dbe0afd9ff05ff7f6a
Log 3015

Reports 3015

[opensearch-ci-bot]

❌   Gradle Check failure 012ad3fff367a24820cccb6adf15e5e06a7ca2f2
Log 3017

Reports 3017

[dreamer-89]

Multiple failures. Out of these, testRecoverReplica fails more frequently on Jenkins but is not reproducible on local machine.

1. TranslogPolicyIT.testRecoverReplica failure.

REPRODUCE WITH: ./gradlew ':qa:translog-policy:v1.3.0#Step1OldClusterTest' --tests "org.opensearch.upgrades.TranslogPolicyIT.testRecoverReplica" -Dtests.seed=A7F39AB3B5FF3CF9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=mt -Dtests.timezone=Chile/Continental -Druntime.java=17

org.opensearch.upgrades.TranslogPolicyIT > testRecoverReplica FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:33619], URI [/testrecoverreplica], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testrecoverreplica"}
        at __randomizedtesting.SeedInfo.seed([A7F39AB3B5FF3CF9:5D6A55174026FDF4]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.TranslogPolicyIT.testRecoverReplica(TranslogPolicyIT.java:129)

2. testOperationBasedRecovery

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery" -Dtests.seed=A7F39AB3B5FF3CF9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-CR -Dtests.timezone=America/Argentina/San_Juan -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testOperationBasedRecovery FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:35135], URI [/testoperationbasedrecovery], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testoperationbasedrecovery"}
        at __randomizedtesting.SeedInfo.seed([A7F39AB3B5FF3CF9:BA1F9696B379C68E]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testOperationBasedRecovery(FullClusterRestartIT.java:1289)

3. testEnableSoftDeletesOnRestore

  2> REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testEnableSoftDeletesOnRestore" -Dtests.seed=A7F39AB3B5FF3CF9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-CR -Dtests.timezone=America/Argentina/San_Juan -Druntime.java=17
  2> org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:35135], URI [/testenablesoftdeletesonrestore], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"testenablesoftdeletesonrestore"}
        at __randomizedtesting.SeedInfo.seed([A7F39AB3B5FF3CF9:93AC5E1A696C82C2]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)

[nknize]

This test has started failing more frequently on Jenkins but this test is not reproducible on local machine

I thought I was going crazy! This is tripping up in RestClient.java#L345 which could be related to types removal warning but the exception doesn't print the offending warning. We should add that and try to reproduce in jenkins.

[dreamer-89]

This test has started failing more frequently on Jenkins but this test is not reproducible on local machine

I thought I was going crazy! This is tripping up in RestClient.java#L345 which could be related to types removal warning but the exception doesn't print the offending warning. We should add that and try to reproduce in jenkins.

Raised PR to log warnings #2338

[VachaShah]

@nknize @dreamer-89 This might be related to #2334. I am working on a fix for this.

[dblock]

start gradle check

[reta]

@nknize LGTM but it looks incomplete (to me), the PutMappingRequest still uses type in payload:

{
  "_doc": {
    "properties": {
      "name": {
        "type": "text",
   ....
}

I think it would be great to remove it as well in scope of this change, wdyt?

[opensearch-ci-bot]

❌   Gradle Check failure 012ad3fff367a24820cccb6adf15e5e06a7ca2f2
Log 3029

Reports 3029

[nknize]

TranslogPolicyIT is no longer needed. This was added to trim unsafe commits for indexes created before 6.2. This is failing now because Step1OldClusterTest applies to 7.x/1.x indices whereas it used to be Legacy 6.2. There's a PR open #2225 that removes all of this ancient logic.

[nknize]

Until the PR is merged I'm going to unilaterly push a MuteTest commit.

[nknize]

I'm going to unilaterly push a MuteTest commit.

As a good steward I opened a PR instead. #2342

[reta]

I'm going to unilaterly push a MuteTest commit.

As a good steward I opened a PR instead. #2342

@nknize could we get #2225 in before merging this one?

[nknize]

@nknize could we get #2225 in before merging this one?

Yes. It needs to land before this can be merged.

I think it would be great to remove it as well in scope of this change, wdyt?

I noticed a few more removals needed for this PR that I think will bring this one to ready. Then we can continue to detangle in follow up PRs.

[opensearch-ci-bot]

❌   Gradle Check failure 6cf60d9
Log 3037

Reports 3037

[opensearch-ci-bot]

✅   Gradle Check success e7b59ab
Log 3045

Reports 3045

[dreamer-89]

LGTM!

[dreamer-89]

Are other deprecated methods e.g. getFieldMapping, getFieldMappingAsync etc; also under your radar for removal ?

[nknize]

Yes! Upcoming PR