[2.18] Fix NPE in CatShardsRequestTests on version bump #16590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
reta
reviewed
Nov 7, 2024
server/src/test/java/org/opensearch/action/admin/cluster/shards/CatShardsRequestTests.java
Show resolved
Hide resolved
reta
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
owaiskazi19
approved these changes
Nov 7, 2024
|
❌ Gradle check result for 82d74ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.18 #16590 +/- ##
=======================================
Coverage ? 71.82%
Complexity ? 65367
=======================================
Files ? 5312
Lines ? 304995
Branches ? 44440
=======================================
Hits ? 219065
Misses ? 67681
Partials ? 18249 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the version changes from https://github.com/opensearch-project/OpenSearch/pull/16455/files was missed when it was manually backported in #16396.
The test in question is intended to check for a previous version that does not read the array of null strings. By leaving it at
Version.CURRENTit bumped to 2.18.1 where 2.18.0 was the previous version and incorrectly tried to read that array.Related Issues
Resolves #16580
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.