[Backport 2.x] Implementing pagination for _cat/shards (#14641) #16396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding _list/shards API Signed-off-by: Harsh Garg <[email protected]>
gargharsh3134
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16396 +/- ##
============================================
- Coverage 71.81% 71.79% -0.03%
- Complexity 65052 65158 +106
============================================
Files 5305 5307 +2
Lines 304143 304341 +198
Branches 44231 44270 +39
============================================
+ Hits 218418 218489 +71
- Misses 67527 67661 +134
+ Partials 18198 18191 -7 ☔ View full report in Codecov by Sentry. |
gargharsh3134
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
gbbafna
approved these changes
Oct 21, 2024
3 tasks
dbwiddis
reviewed
Nov 7, 2024
| catShardsRequest.setCancelAfterTimeInterval(TimeValue.timeValueMillis(randomIntBetween(1, 5))); | ||
| catShardsRequest.setIndices(new String[2]); | ||
|
|
||
| Version version = VersionUtils.getPreviousVersion(Version.CURRENT); |
There was a problem hiding this comment.
This should be Version.V_2_18_0 else the test fails.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backporting #14641 to 2.x.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.