Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 2.18.0 for CatShards request and response #16455

Merged

Conversation

gargharsh3134
Copy link
Contributor

@gargharsh3134 gargharsh3134 commented Oct 23, 2024

Description

Updating version to 2.18.0 for CatShardsRequest and CatShardsResponse which were added as 3.0.0 as part of #14641

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 6e4ab14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsh Garg <[email protected]>
Copy link
Contributor

❌ Gradle check result for fd2f9c0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

❌ Gradle check result for fd2f9c0: FAILURE

I suspect the failure in CatShardsRequestTests.testSerializationWithOlderVersionsParametersNotSerialized is related to this change. @gargharsh3134 can you take a look?

Copy link
Contributor

❌ Gradle check result for 2806587: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargharsh3134 gargharsh3134 force-pushed the catShardsVersionChange branch from 2806587 to 9f75286 Compare October 23, 2024 19:45
Copy link
Contributor

❌ Gradle check result for 9f75286: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargharsh3134 gargharsh3134 force-pushed the catShardsVersionChange branch from 9f75286 to c314d98 Compare October 23, 2024 20:50
Copy link
Contributor

❌ Gradle check result for c314d98: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for c314d98: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsh Garg <[email protected]>
@gargharsh3134 gargharsh3134 force-pushed the catShardsVersionChange branch from c314d98 to 87d7231 Compare October 24, 2024 04:00
Copy link
Contributor

✅ Gradle check result for 87d7231: SUCCESS

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.10%. Comparing base (9489a21) to head (87d7231).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...action/admin/cluster/shards/CatShardsResponse.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16455      +/-   ##
============================================
+ Coverage     72.04%   72.10%   +0.06%     
- Complexity    65020    65060      +40     
============================================
  Files          5313     5313              
  Lines        303356   303356              
  Branches      43900    43900              
============================================
+ Hits         218551   218742     +191     
+ Misses        66905    66684     -221     
- Partials      17900    17930      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargharsh3134
Copy link
Contributor Author

@dbwiddis @andrross @owaiskazi19 Finally got the build working, had to re-run multiple times owing to flaky tests. Please check whenever you get a chance.
Thanks!

@dbwiddis
Copy link
Member

@dbwiddis @andrross @owaiskazi19 Finally got the build working, had to re-run multiple times owing to flaky tests. Please check whenever you get a chance. Thanks!

Winter is coming. (Snow) flakiness is a fact of the season ;)

@dbwiddis dbwiddis merged commit 119abaf into opensearch-project:main Oct 24, 2024
38 of 39 checks passed
@dbwiddis
Copy link
Member

@gargharsh3134 does this need a 2.x backport?

@gargharsh3134
Copy link
Contributor Author

@dbwiddis It was already handled while merging the 2.x backport of source PR (#16396). We should be good now.
Thanks!

@dbwiddis
Copy link
Member

dbwiddis commented Nov 7, 2024

It was already handled while merging the 2.x backport of source PR (#16396). We should be good now. Thanks!

@gargharsh3134 seems one of these was missed. I manually filed #16590 for 2.18 branch. I'll trigger the backport from this PR to hopefully fix 2.x as the other changes should be no-op.

@dbwiddis dbwiddis added the backport 2.x Backport to 2.x branch label Nov 7, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2024
* Update version to 2.18.0 for CatShards request and response

Signed-off-by: Harsh Garg <[email protected]>

* Retry Build

Signed-off-by: Harsh Garg <[email protected]>

* Fix CatShardsRequestTests

Signed-off-by: Harsh Garg <[email protected]>

* Retry Build

Signed-off-by: Harsh Garg <[email protected]>

---------

Signed-off-by: Harsh Garg <[email protected]>
Co-authored-by: Harsh Garg <[email protected]>
(cherry picked from commit 119abaf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Nov 7, 2024
…16591)

* Update version to 2.18.0 for CatShards request and response



* Retry Build



* Fix CatShardsRequestTests



* Retry Build



---------



(cherry picked from commit 119abaf)

Signed-off-by: Harsh Garg <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Harsh Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants