-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 2.18.0 for CatShards request and response #16455
Update version to 2.18.0 for CatShards request and response #16455
Conversation
Signed-off-by: Harsh Garg <[email protected]>
❌ Gradle check result for 6e4ab14: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsh Garg <[email protected]>
❌ Gradle check result for fd2f9c0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I suspect the failure in |
❌ Gradle check result for 2806587: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2806587
to
9f75286
Compare
❌ Gradle check result for 9f75286: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9f75286
to
c314d98
Compare
❌ Gradle check result for c314d98: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c314d98: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsh Garg <[email protected]>
c314d98
to
87d7231
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16455 +/- ##
============================================
+ Coverage 72.04% 72.10% +0.06%
- Complexity 65020 65060 +40
============================================
Files 5313 5313
Lines 303356 303356
Branches 43900 43900
============================================
+ Hits 218551 218742 +191
+ Misses 66905 66684 -221
- Partials 17900 17930 +30 ☔ View full report in Codecov by Sentry. |
@dbwiddis @andrross @owaiskazi19 Finally got the build working, had to re-run multiple times owing to flaky tests. Please check whenever you get a chance. |
Winter is coming. (Snow) flakiness is a fact of the season ;) |
@gargharsh3134 does this need a 2.x backport? |
@gargharsh3134 seems one of these was missed. I manually filed #16590 for 2.18 branch. I'll trigger the backport from this PR to hopefully fix 2.x as the other changes should be no-op. |
* Update version to 2.18.0 for CatShards request and response Signed-off-by: Harsh Garg <[email protected]> * Retry Build Signed-off-by: Harsh Garg <[email protected]> * Fix CatShardsRequestTests Signed-off-by: Harsh Garg <[email protected]> * Retry Build Signed-off-by: Harsh Garg <[email protected]> --------- Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]> (cherry picked from commit 119abaf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…16591) * Update version to 2.18.0 for CatShards request and response * Retry Build * Fix CatShardsRequestTests * Retry Build --------- (cherry picked from commit 119abaf) Signed-off-by: Harsh Garg <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Harsh Garg <[email protected]>
Description
Updating version to 2.18.0 for
CatShardsRequest
andCatShardsResponse
which were added as 3.0.0 as part of #14641Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.