feat: address styling of non-primary buttons by making secondary/empty #7211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7211 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 3469 3469
Lines 68479 68479
Branches 11130 11130
=======================================
Hits 46264 46264
Misses 19512 19512
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Viraj Sanghvi <[email protected]>
virajsanghvi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
kavilla
approved these changes
Jul 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
#7211) * feat: address styling of non-primary buttons by making secondary/empty --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f7ecefb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Jul 11, 2024
#7211) (#7217) * feat: address styling of non-primary buttons by making secondary/empty --------- (cherry picked from commit f7ecefb) Signed-off-by: Viraj Sanghvi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes buttons that have primary styling but are actually secondary buttons or just links by changing them to secondary or empty buttons, respectively.
To address, I searched for all filled buttons and those with hrefs, to identify candidates to change. I identified two additional to the three previously identified by design.
Issues Resolved
N/A
Screenshot
fyi @lauralexis
Testing the changes
Validated ui changes above
Changelog
Check List
yarn test:jestyarn test:jest_integration