Skip to content

Commit

Permalink
feat: address styling of non-primary buttons by making secondary/empty (
Browse files Browse the repository at this point in the history
#7211)

* feat: address styling of non-primary buttons by making secondary/empty

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f7ecefb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent e9ba24f commit b89021f
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 15 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/7211.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
feat:
- Address styling of non-primary buttons by making secondary/empty ([#7211](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7211))

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import rison from 'rison-node';
import { i18n } from '@osd/i18n';
import { FormattedMessage } from '@osd/i18n/react';
import {
EuiButton,
EuiButtonEmpty,
EuiFlexGroup,
EuiFlexItem,
EuiFlyout,
Expand Down Expand Up @@ -101,8 +101,7 @@ export function OpenSearchPanel({ onClose, makeUrl }: Props) {
<EuiFlexGroup justifyContent="flexEnd">
<EuiFlexItem grow={false}>
{/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
<EuiButton
fill
<EuiButtonEmpty
onClick={onClose}
href={addBasePath(
`/app/management/opensearch-dashboards/objects?_a=${rison.encode({
Expand All @@ -114,7 +113,7 @@ export function OpenSearchPanel({ onClose, makeUrl }: Props) {
id="discover.topNav.openSearchPanel.manageSearchesButtonLabel"
defaultMessage="Manage searches"
/>
</EuiButton>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutFooter>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ class ControlsTabUi extends PureComponent<ControlsTabUiProps, ControlsTabUiState
<EuiFlexItem grow={false}>
<EuiFormRow id="addControl">
<EuiButton
fill
onClick={this.handleAddControl}
iconType="plusInCircle"
data-test-subj="inputControlEditorAddBtn"
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ export class InputControlVis extends Component<InputControlVisProps> {
<EuiFlexGroup wrap={true}>
<EuiFlexItem grow={false}>
<EuiButton
fill
onClick={this.handleSubmit}
disabled={!this.props.hasChanges()}
data-test-subj="inputControlSubmitBtn"
Expand Down
1 change: 0 additions & 1 deletion src/plugins/share/public/components/url_panel_content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export class UrlPanelContent extends Component<Props, State> {
<EuiCopy textToCopy={this.state.url || ''} anchorClassName="eui-displayBlock">
{(copy: () => void) => (
<EuiButton
fill
fullWidth
onClick={copy}
disabled={this.state.isCreatingShortUrl || this.state.url === ''}
Expand Down

0 comments on commit b89021f

Please sign in to comment.