feat: address styling of non-primary buttons by making secondary/empty (

#7211) (#7217) * feat: address styling of non-primary buttons by making secondary/empty --------- (cherry picked from commit f7ecefb) Signed-off-by: Viraj Sanghvi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-project · Jul 11, 2024 · 3ba0f35 · 3ba0f35
1 parent e9ba24f
commit 3ba0f35
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 15 deletions.
diff --git a/changelogs/fragments/7211.yml b/changelogs/fragments/7211.yml
@@ -0,0 +1,2 @@
+feat:
+- Address styling of non-primary buttons by making secondary/empty ([#7211](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7211))
diff --git a/...cover/public/application/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap b/...cover/public/application/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap
diff --git a/src/plugins/discover/public/application/components/top_nav/open_search_panel.tsx b/src/plugins/discover/public/application/components/top_nav/open_search_panel.tsx
@@ -33,7 +33,7 @@ import rison from 'rison-node';
 import { i18n } from '@osd/i18n';
 import { FormattedMessage } from '@osd/i18n/react';
 import {
-  EuiButton,
+  EuiButtonEmpty,
   EuiFlexGroup,
   EuiFlexItem,
   EuiFlyout,
@@ -101,8 +101,7 @@ export function OpenSearchPanel({ onClose, makeUrl }: Props) {
         <EuiFlexGroup justifyContent="flexEnd">
           <EuiFlexItem grow={false}>
             {/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
-            <EuiButton
-              fill
+            <EuiButtonEmpty
               onClick={onClose}
               href={addBasePath(
                 `/app/management/opensearch-dashboards/objects?_a=${rison.encode({
@@ -114,7 +113,7 @@ export function OpenSearchPanel({ onClose, makeUrl }: Props) {
                 id="discover.topNav.openSearchPanel.manageSearchesButtonLabel"
                 defaultMessage="Manage searches"
               />
-            </EuiButton>
+            </EuiButtonEmpty>
           </EuiFlexItem>
         </EuiFlexGroup>
       </EuiFlyoutFooter>

diff --git a/...ugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap b/...ugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap
diff --git a/src/plugins/input_control_vis/public/components/editor/controls_tab.tsx b/src/plugins/input_control_vis/public/components/editor/controls_tab.tsx
@@ -212,7 +212,6 @@ class ControlsTabUi extends PureComponent<ControlsTabUiProps, ControlsTabUiState
             <EuiFlexItem grow={false}>
               <EuiFormRow id="addControl">
                 <EuiButton
-                  fill
                   onClick={this.handleAddControl}
                   iconType="plusInCircle"
                   data-test-subj="inputControlEditorAddBtn"

diff --git a/...ins/input_control_vis/public/components/vis/__snapshots__/input_control_vis.test.tsx.snap b/...ins/input_control_vis/public/components/vis/__snapshots__/input_control_vis.test.tsx.snap
diff --git a/src/plugins/input_control_vis/public/components/vis/input_control_vis.tsx b/src/plugins/input_control_vis/public/components/vis/input_control_vis.tsx
@@ -130,7 +130,6 @@ export class InputControlVis extends Component<InputControlVisProps> {
       <EuiFlexGroup wrap={true}>
         <EuiFlexItem grow={false}>
           <EuiButton
-            fill
             onClick={this.handleSubmit}
             disabled={!this.props.hasChanges()}
             data-test-subj="inputControlSubmitBtn"

diff --git a/src/plugins/share/public/components/url_panel_content.tsx b/src/plugins/share/public/components/url_panel_content.tsx
@@ -128,7 +128,6 @@ export class UrlPanelContent extends Component<Props, State> {
           <EuiCopy textToCopy={this.state.url || ''} anchorClassName="eui-displayBlock">
             {(copy: () => void) => (
               <EuiButton
-                fill
                 fullWidth
                 onClick={copy}
                 disabled={this.state.isCreatingShortUrl || this.state.url === ''}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		feat:
		- Address styling of non-primary buttons by making secondary/empty ([#7211](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7211))