-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Enable unit test suites in telemetry/public/components #532
Conversation
✅ DCO Check Passed d66fb64 |
✅ DCO Check Passed 978b2e0 |
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR enables three test suites in dir src/plugins/telemetry/public/components, which includes: 1) opt_in_banner.test.tsx, 2) opt_in_message.test.tsx, 3) opted_in_notice_banner.test.tsx Signed-off-by: Anan Zhuang <[email protected]>
✅ DCO Check Passed 7741827 |
LGTM but I have a question: I understand that we are just rendering the components without any logic. But are these components actually being used within the application? |
Have no idea for now. But I can dive into it and see if an issue is needed. |
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR enables three test suites in dir src/plugins/telemetry/public/components, which includes: 1) opt_in_banner.test.tsx, 2) opt_in_message.test.tsx, 3) opted_in_notice_banner.test.tsx Signed-off-by: Anan Zhuang <[email protected]>
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR enables three test suites in dir src/plugins/telemetry/public/components, which includes: 1) opt_in_banner.test.tsx, 2) opt_in_message.test.tsx, 3) opted_in_notice_banner.test.tsx Signed-off-by: Anan Zhuang <[email protected]>
Description
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR enables three test suites in dir
src/plugins/telemetry/public/components, which includes:
Signed-off-by: Anan Zhuang [email protected]
Issues Resolved
#516
#517
#518
Test results
unit test for opt_in_banner.test.tsx
unit test for opt_in_message.test.tsx
unit test for opted_in_notice_banner.test.tsx
Overall test result:
Check List