Skip to content

Commit

Permalink
[Test] Enable unit test suites in telemetry/public/components
Browse files Browse the repository at this point in the history
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR enables three test suites in dir
src/plugins/telemetry/public/components, which includes:
1) opt_in_banner.test.tsx,
2) opt_in_message.test.tsx,
3) opted_in_notice_banner.test.tsx

Signed-off-by: Anan Zhuang <[email protected]>
  • Loading branch information
ananzh committed Jun 23, 2021
1 parent 4293f92 commit 7741827
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { EuiButton } from '@elastic/eui';
import { shallowWithIntl } from 'test_utils/enzyme_helpers';
import { OptInBanner } from './opt_in_banner';

describe.skip('OptInDetailsComponent', () => {
describe('OptInDetailsComponent', () => {
it('renders as expected', () => {
expect(shallowWithIntl(<OptInBanner onChangeOptInClick={() => {}} />)).toMatchSnapshot();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import React from 'react';
import { shallowWithIntl } from 'test_utils/enzyme_helpers';
import { OptInMessage } from './opt_in_message';

describe.skip('OptInMessage', () => {
describe('OptInMessage', () => {
it('renders as expected', () => {
expect(shallowWithIntl(<OptInMessage />)).toMatchSnapshot();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { EuiButton } from '@elastic/eui';
import { shallowWithIntl } from 'test_utils/enzyme_helpers';
import { OptedInNoticeBanner } from './opted_in_notice_banner';

describe.skip('OptInDetailsComponent', () => {
describe('OptInDetailsComponent', () => {
it('renders as expected', () => {
expect(shallowWithIntl(<OptedInNoticeBanner onSeenBanner={() => {}} />)).toMatchSnapshot();
});
Expand Down

0 comments on commit 7741827

Please sign in to comment.