Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] unit test opt_in_message.test.tsx is skipped now #517

Closed
ananzh opened this issue Jun 21, 2021 · 0 comments · Fixed by #532
Closed

[Test] unit test opt_in_message.test.tsx is skipped now #517

ananzh opened this issue Jun 21, 2021 · 0 comments · Fixed by #532
Assignees

Comments

@ananzh
Copy link
Member

ananzh commented Jun 21, 2021

Describe the issue

Currently, opt_in_message.test.tsx test suite is skipped. To make a clean unit test, we want to explore and decide whether we still need to keep it as skipped.

/src/plugins/telemetry/public/components/opt_in_message.test.tsx
Test Suites: 1 skipped, 0 of 1 total
Tests:       1 skipped, 1 total

To Reproduce
Run:yarn test:jest {path to opt_in_message.test.tsx}

Expected behavior
explore the skipped unit tests, check:

  • can we enable all? if yes, create a PR and close the issue

  • can we remove all? if yes, create a PR and close the issue

  • should we keep all? if yes, describe the reasons in the issue.

The final output is expected to be a cleaned unit test with all the skipped ones being checked.

OpenSearch Version
OpenSearch 1.0.0

Dashboards Version
Dashboards 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant