-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Fix] Add platform "darwin-arm64" to unit test #5317
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5317 +/- ##
==========================================
- Coverage 66.81% 66.81% -0.01%
==========================================
Files 3284 3284
Lines 63149 63150 +1
Branches 10048 10049 +1
==========================================
Hits 42192 42192
Misses 18485 18485
- Partials 2472 2473 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Add platform "darwin-arm64" to unit test * Update related snapshots --------- Signed-off-by: Willie Hung <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 7b3a9f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
25e8953
to
f46e151
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this PR, as we may revert the change in main
due to node 14 lack of support.
@AMoo-Miki Is the plan to go ahead and merge this, followed by #5466? |
Yes |
Backport 7b3a9f6 from #5290.