Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Fix] Add platform "darwin-arm64" to unit test #5317

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b3a9f6 from #5290.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #5317 (f46e151) into 2.x (0e4b9f4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              2.x    #5317      +/-   ##
==========================================
- Coverage   66.81%   66.81%   -0.01%     
==========================================
  Files        3284     3284              
  Lines       63149    63150       +1     
  Branches    10048    10049       +1     
==========================================
  Hits        42192    42192              
  Misses      18485    18485              
- Partials     2472     2473       +1     
Flag Coverage Δ
Linux_1 35.26% <ø> (ø)
Linux_2 55.26% <ø> (ø)
Linux_3 43.84% <ø> (-0.01%) ⬇️
Linux_4 35.49% <0.00%> (-0.01%) ⬇️
Windows_1 35.28% <ø> (ø)
Windows_2 55.23% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dev/build/lib/platform.ts 100.00% <ø> (ø)
src/dev/build/lib/config.ts 84.21% <0.00%> (-2.28%) ⬇️

* Add platform "darwin-arm64" to unit test
* Update related snapshots

---------

Signed-off-by: Willie Hung <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 7b3a9f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@manasvinibs manasvinibs force-pushed the backport/backport-5290-to-2.x branch from 25e8953 to f46e151 Compare October 26, 2023 23:23
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR, as we may revert the change in main due to node 14 lack of support.

@joshuarrrr
Copy link
Member

@AMoo-Miki Is the plan to go ahead and merge this, followed by #5466?

@AMoo-Miki
Copy link
Collaborator

@AMoo-Miki Is the plan to go ahead and merge this, followed by #5466?

Yes

@AMoo-Miki AMoo-Miki merged commit ba20c9f into 2.x Nov 13, 2023
61 of 62 checks passed
@joshuarrrr joshuarrrr deleted the backport/backport-5290-to-2.x branch November 13, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports first-time-contributor OSCI Open Source Contributor Initiative v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants