[Fix] Add platform "darwin-arm64" to unit test #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willie-hung
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Signed-off-by: Willie Hung <[email protected]>
Signed-off-by: Willie Hung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5290 +/- ##
==========================================
- Coverage 66.77% 66.73% -0.05%
==========================================
Files 3284 3284
Lines 63095 63096 +1
Branches 10049 10050 +1
==========================================
- Hits 42134 42104 -30
- Misses 18488 18510 +22
- Partials 2473 2482 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@Willie-The-Lord Looks like there are some snapshots that need updating: see https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6513128467/job/17696075511?pr=5290 |
Signed-off-by: Willie Hung <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
approved these changes
Oct 16, 2023
ananzh
approved these changes
Oct 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Add platform "darwin-arm64" to unit test * Update related snapshots --------- Signed-off-by: Willie Hung <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 7b3a9f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Add platform "darwin-arm64" to unit test * Update related snapshots --------- Signed-off-by: Willie Hung <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 7b3a9f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
added a commit
that referenced
this pull request
Nov 3, 2023
This reverts commit 7b3a9f6.
AMoo-Miki
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Add platform "darwin-arm64" to unit test * Update related snapshots --------- Signed-off-by: Willie Hung <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 7b3a9f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the test cases can now pass for Mac (arm64) users.
Issues Resolved
Screenshot
Check List
yarn test:jestyarn test:jest_integration