[Backport 2.x] Enhance darwin-arm64 release #5466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add min-builds for `darwin-x64` and `darwin-arm64`. * Expose `--darwin-arm` as a parameter of the build script. * Work around build's cleanup failure when removal of an already deleted folder is attempted. * Exclude bundling fallbacks with `darwin-arm64` since Node.js v14 has no releases for them. * Update tests to accommodate `darwin-arm64`. * Generalize the Node.js versions used in some tests. Signed-off-by: Miki <[email protected]> (cherry picked from commit 89dc051) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc and
joshuarrrr
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested a review
from abbyhu2000
as a code owner
opensearch-trigger-bot
bot
added
Skip-Changelog
opensearch-trigger-bot
bot
requested a review
from zengyan-amazon
as a code owner
opensearch-trigger-bot
bot
requested review from
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #5466 +/- ##
======================================
Coverage ? 61.92%
======================================
Files ? 2847
Lines ? 55473
Branches ? 8881
======================================
Hits ? 34354
Misses ? 19189
Partials ? 1930
Flags with carried forward coverage won't be shown. Click here to find out more. |
ananzh
approved these changes
Nov 11, 2023
AMoo-Miki
approved these changes
Nov 11, 2023
AMoo-Miki
requested changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 89dc051 from #5455.