[CCI] Replace jquery usage in console plugin with native methods

[Nicksqain]

Description

• Replace $() select functions with native methods and properties
• Replace $.* utility methods (for example, $.each(), $.map(), $.Deferred(), $.when(), $.inArray(), $.ajax())
• Remove imports

Issues Resolved

• closes Replace jquery usage in console plugin with native methods #3679

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[joshuarrrr]

@Nicksqain Check the failing unit tests - it looks like we may need to account for cases when mappings isn't iterable: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/4561381846/jobs/8061888415?pr=3733

[Nicksqain]

@joshuarrrr

When using fetch and everything else jquery - all tests pass, then this error comes out. How do I run this 127.0.0.1:80?
And if I use everything natively that I've done - then iteration problems. Need to rewrite to loops, most likely

[Nicksqain]

@joshuarrrr Can you check pls :]

[ashwin-pc]

@Nicksqain As @joshuarrrr pointed out, some of the unit tests seem to be failing. I did not look at each failure, but the last few seem to be because you are trying to map an object without first converting it to an array. $.each automatically does this but to reproduce the same behaviour with native js you need to do the conversion first like Object.entries(obj).forEach(...

e.g.

$.each(mappings, function (index, indexMapping) {

to

Object.entries(mappings).forEach((index, indexMapping) => {

[joshuarrrr]

@Nicksqain Instead of running yarn test:jest, try with yarn test:jest_integration instead, for integration test failures.

[Nicksqain]

@joshuarrrr Any guidance on mapping.js? of #3775

[ashwin-pc]

@Nicksqain thats annoying merge conflict. Thankfully it looks like you can just accept the current changes in that file since @zhongnansu already removed jquery from that file in his PR.

[codecov-commenter]

Codecov Report

Merging #3733 (0c96f2b) into main (8f890e9) will increase coverage by 0.00%.
The diff coverage is 53.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3733   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files        3209     3208    -1     
  Lines       61733    61736    +3     
  Branches     9534     9534           
=======================================
+ Hits        41008    41011    +3     
  Misses      18438    18438           
  Partials     2287     2287           

Flag	Coverage Δ
Linux	66.37% <46.66%> (+<0.01%)	⬆️
Windows	66.37% <46.66%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...on/models/legacy_core_editor/legacy_core_editor.ts	56.94% <41.66%> (-0.20%)	⬇️
src/plugins/console/public/lib/osd/osd.js	74.54% <100.00%> (+4.17%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[joshuarrrr]

A couple minor nits.

[joshuarrrr]

All checks pass

[Nicksqain]

@joshuarrrr I fixed the error with DCO, but why does it require DCO to merge? Can you fix this? 51da17d

[joshuarrrr]

@Nicksqain DCO is part of the project's legal requirements: https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

In this case, the checker is overly strict, in that it expects even commits you accept from reviewers to be signed. Given the content of 3c7233d, I can set the DCO to pass in this case.