[CCI] Fix EUI/OUI type errors

[Nicksqain]

Description

• Update imports
• fix EuiIconType type error
• fix query type error in EuiSearchBar

Issues Resolved

• closes Fix EUI/OUI related type errors #3028

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[Nicksqain]

I initialised the PR to keep working on it!
I want to know if the imports will work correctly, would you be kind enough to give feedback?

[codecov-commenter]

Codecov Report

Merging #3798 (800b7d4) into main (8121c9d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3798      +/-   ##
==========================================
- Coverage   66.44%   66.43%   -0.01%     
==========================================
  Files        3229     3229              
  Lines       62067    62067              
  Branches     9599     9599              
==========================================
- Hits        41240    41234       -6     
- Misses      18525    18529       +4     
- Partials     2302     2304       +2     

Flag	Coverage Δ
Linux	66.38% <ø> (-0.01%)	⬇️
Windows	66.38% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...public/management_app/components/search/search.tsx	100.00% <ø> (ø)

... and 3 files with indirect coverage changes

[Nicksqain]

@joshuarrrr @ashwin-pc
I fixed the non-working imports that were declared in elastic ui, accidentally came across a folder with findTestSubject, which is identical and does not cause errors.
But what did I do wrong? I can't run snapshot
I don't think these tests broke everything

[joshuarrrr]

@Nicksqain It's not your fault or problem - it appears there's a problem with the windows snapshot images.

[joshuarrrr]

@Nicksqain The snapshot should be working again, I restarted the test automation.

[joshuarrrr]

When you get a chance, can you add an entry to the CHANGELOG.md under the "Refactoring" section?

[manasvinibs]

@Nicksqain Were you able to get the snapshot running? Also, can you add it to description on how did you test these changes?

[Nicksqain]

@manasvinibs
Thank you for your concern! I was able to run the snapshot! Working on that issue at the moment. It's not very clear to me, but it's interesting to figure it out.

Tests? If you mean imports of tests, I've been testing them like this
yarn test:jest src/plugins/advanced_settings/public/management_app/components/field/field.test.tsx

[joshuarrrr]

@Nicksqain Also please update the changelog, when you get the chance.

[ashwin-pc]

@Nicksqain thanks for updating the changelog. I see that you have 3 tasks listed in this PR but have only completed one of them. Are you planning on completing all three in the same PR?

[ashwin-pc]

Nice find! yep this function is equivalent to the eui one.

[Nicksqain]

@ashwin-pc I have updated the tasks. I have added changes to the entire PR. Please check, because I'm not sure if it's the way to use Query import. But this import is declared in eui

[ashwin-pc]

Thanks for updating the PR @Nicksqain. The rest of the changes look good to me, just one change needed

[ashwin-pc]

This change add a type error in the parent component that uses Search. I suggest that you instead add a ts-ignore comment to the ts error on line 114. e.g.

        {/* @ts-ignore The Query types that typescript complains about here are identical and is a false flag. Once OUI migration is complete, this ignore can be removed */}
        <EuiSearchBar box={box} filters={filters} onChange={this.onChange} query={query} />

[Nicksqain]

@ashwin-pc That is, do not need to update the import? Will the Query error be fixed in the future?

[ashwin-pc]

Yeah, we will replace all eui references to oui. That should fix it :)

[BSFishy]

+1 for removing references to @elastic/eui/lib/test. This will make migrations from OUI v1 to v2 much easier

[ashwin-pc]

Nice to see this finally over the finish line. @Nicksqain Tanks for sticking with it 🎉

[manasvinibs]

LGTM!

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-3798-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0e25f2e6e0e906e2474e513a6784be9ac63b26da
# Push it to GitHub
git push --set-upstream origin backport/backport-3798-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3798-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-3798-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0e25f2e6e0e906e2474e513a6784be9ac63b26da
# Push it to GitHub
git push --set-upstream origin backport/backport-3798-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3798-to-2.x.