Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps @microsoft/api-documenter and @microsoft/api-extractor #1064

Closed
wants to merge 8 commits into from

Conversation

tmarkley
Copy link
Contributor

Description

Bumps dependencies to address CVE.

Issues Resolved

Resolves #1063

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Tommy Markley and others added 8 commits December 29, 2021 22:58
* precommit checks are failing with an error related to an lmdb-store dependency
* unit tests are failing with an error related to lmdb-store
* bumped react from 16.12 to 16.14 to resolve unmet peer dependencies, but we still need a resolution to remove the old version
* need a replacement for @elastic/good

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
…est issues (opensearch-project#1012)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Add unit tests to github workflow and also creating a "bad apples"
environment variable. Some unit tests just fail on the CI for
hardware issues. They should be improved but step one will be
calling out the bad apples.

Also due to the flakiness we can cache the previous run results
and only run the tests that failed. It's too random to catch
with the bad apples mechanism. But still added the continue on
error for unit tests because it takes so long to re-run on the
CI. So instead if it does fail we automatically echo there
was a failure and ask them to re-run. However, if we can get
permission for a github action that can add a comment to the PR
then we could automatically add to PR.

Next step will be improving.

Also needed to limit the amount of workers because otherwise the
hardware can't handle well so then it will accidentally create conflicts.
This means we get an accurate test run but it is slower on the CI.

Included integration tests which worked out of the box.

Included e2e tests as well but it the chrome driver for the application
was different from github's chrome so to run it I just upgraded it for
the test run. Not ideal, ideally we should probably set up a
docker env and install the specific versions since we are now
depending on github's virtual env and the dependencies they installed
there. But at least this is a first pace.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Adds `--no-deprecation` flag for integration tests caused by `shot`
which is a downstream dependency of `hapi`.
* The ServerMetricsCollector tests are flaky and rely on the existing
v17 hapi library that Dashboards depends on. This will be upgraded
for the 2.0 release along with the Node.js upgrade.

Signed-off-by: Tommy Markley <markleyt@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Resolves opensearch-project#1063

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley added dependencies Pull requests that update a dependency file v2.0.0 security fix Security fix generated by Mend labels Dec 31, 2021
@tmarkley tmarkley requested a review from a team December 31, 2021 04:11
@tmarkley tmarkley linked an issue Dec 31, 2021 that may be closed by this pull request
kavilla
kavilla previously approved these changes Jan 3, 2022
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use microsoft/api anymore? LGTM thanks! I've been verifying the release build as well.

@tmarkley
Copy link
Contributor Author

tmarkley commented Jan 3, 2022

Do we use microsoft/api anymore? LGTM thanks! I've been verifying the release build as well.

Yeah they're both used here: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/dev/run_check_published_api_changes.ts

If we don't think we want to use the Core API Review process anymore then we can get rid of it.

@ananzh ananzh self-requested a review January 5, 2022 18:26
ananzh
ananzh previously approved these changes Jan 5, 2022
@tmarkley tmarkley changed the base branch from node-14 to main January 5, 2022 18:57
@tmarkley tmarkley dismissed stale reviews from ananzh and kavilla January 5, 2022 18:57

The base branch was changed.

@tmarkley
Copy link
Contributor Author

tmarkley commented Jan 6, 2022

Closing in favor of #1106

@tmarkley tmarkley closed this Jan 6, 2022
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
This pr makes enum types aligned to use a singular name, instead of plural.

BREAKING CHANGE: `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`

fix opensearch-project#767

Signed-off-by: Tre' Seymour <wayne.seymour@elastic.co>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [28.0.0](elastic/elastic-charts@v27.0.0...v28.0.0) (2021-04-02)

### Bug Fixes

* **annotations:** provide fallback for line annotation markers ([opensearch-project#1091](elastic/elastic-charts#1091)) ([d907c81](elastic/elastic-charts@d907c81))
* **legend:** action sizing ui and focus states ([opensearch-project#1102](elastic/elastic-charts#1102)) ([a58cc0a](elastic/elastic-charts@a58cc0a))
* **legend:** stop legend color picker dot twitching ([opensearch-project#1101](elastic/elastic-charts#1101)) ([f63bb3b](elastic/elastic-charts@f63bb3b))

### Code Refactoring

* rename enum types to singular ([opensearch-project#1064](elastic/elastic-charts#1064)) ([6e900e2](elastic/elastic-charts@6e900e2)), closes [opensearch-project#767](elastic/elastic-charts#767)

### BREAKING CHANGES

* `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`
@tmarkley tmarkley deleted the validator-cve branch March 1, 2022 00:26
@tmarkley tmarkley removed the security fix Security fix generated by Mend label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2021-3765 (Medium) detected in validator
4 participants