Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legend): stop legend color picker dot twitching #1101

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Mar 31, 2021

Summary

Fixes #1075

Improves spacing around legend item color dot

Screen.Recording.2021-03-31.at.12.15.25.PM.mp4

Prevents bouncing when color picker is opened and closed

Before

ezgif com-gif-maker

After

Screen Recording 2021-03-24 at 09 15 49 AM

Checklist

Delete any items that are not applicable to this PR.

  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added bug Something isn't working :legend Legend related issue labels Mar 31, 2021
@nickofthyme nickofthyme requested review from markov00 and rshen91 March 31, 2021 17:30
@nickofthyme nickofthyme merged commit c89b767 into elastic:master Apr 1, 2021
@nickofthyme nickofthyme changed the title fix(legend): stop legend in color dot twitching fix(legend): stop legend color picker dot twitching Apr 1, 2021
@nickofthyme nickofthyme deleted the fix-legend-color-ui branch April 1, 2021 16:17
nickofthyme pushed a commit that referenced this pull request Apr 2, 2021
# [28.0.0](v27.0.0...v28.0.0) (2021-04-02)

### Bug Fixes

* **annotations:** provide fallback for line annotation markers ([#1091](#1091)) ([0bd61f1](0bd61f1))
* **legend:** action sizing ui and focus states ([#1102](#1102)) ([3a76a2c](3a76a2c))
* **legend:** stop legend color picker dot twitching ([#1101](#1101)) ([c89b767](c89b767))

### Code Refactoring

* rename enum types to singular ([#1064](#1064)) ([396b3d1](396b3d1)), closes [#767](#767)

### BREAKING CHANGES

* `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 2, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [28.0.0](elastic/elastic-charts@v27.0.0...v28.0.0) (2021-04-02)

### Bug Fixes

* **annotations:** provide fallback for line annotation markers ([opensearch-project#1091](elastic/elastic-charts#1091)) ([d907c81](elastic/elastic-charts@d907c81))
* **legend:** action sizing ui and focus states ([opensearch-project#1102](elastic/elastic-charts#1102)) ([a58cc0a](elastic/elastic-charts@a58cc0a))
* **legend:** stop legend color picker dot twitching ([opensearch-project#1101](elastic/elastic-charts#1101)) ([f63bb3b](elastic/elastic-charts@f63bb3b))

### Code Refactoring

* rename enum types to singular ([opensearch-project#1064](elastic/elastic-charts#1064)) ([6e900e2](elastic/elastic-charts@6e900e2)), closes [opensearch-project#767](elastic/elastic-charts#767)

### BREAKING CHANGES

* `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :legend Legend related issue released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend item jumps when series is disabled
1 participant