Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename enum types to singular #767

Closed
markov00 opened this issue Jul 29, 2020 · 1 comment · Fixed by #1064
Closed

Rename enum types to singular #767

markov00 opened this issue Jul 29, 2020 · 1 comment · Fixed by #1064
Assignees
@nickofthyme
Labels
breaking change discuss To be discussed enhancement New feature or request released Issue released publicly

Comments

@markov00
Copy link
Member

Is your feature request related to a problem? Please describe.
Every enum types should be aligned to use singular name, instead of plural.

Describe the solution you'd like
Prefer singular over plural increase readability of code:

// bad
const chartType = ChartTypes.XYAxis

// good
const chartType = ChartType.XYAxis
@markov00 markov00 added enhancement New feature or request discuss To be discussed labels Jul 29, 2020
@markov00 markov00 mentioned this issue Jul 29, 2020
Merged
3 tasks
@nickofthyme nickofthyme self-assigned this Feb 22, 2021
@wayneseymour wayneseymour mentioned this issue Mar 8, 2021
Merged
wayneseymour added a commit that referenced this issue Mar 25, 2021
@wayneseymour
refactor: rename enum types to singular
52b37c5 
BREAKING CHANGE: The "enums" are no longer plural in signature.

fix #767

Signed-off-by: Tre' Seymour <[email protected]>
wayneseymour added a commit that referenced this issue Apr 1, 2021
@wayneseymour
refactor: rename enum types to singular
c07d621 
BREAKING CHANGE: The "enums" are no longer plural in signature.

fix #767

Signed-off-by: Tre' Seymour <[email protected]>
wayneseymour added a commit that referenced this issue Apr 2, 2021
@wayneseymour
refactor: rename enum types to singular (#1064)
396b3d1 
This pr makes enum types aligned to use a singular name, instead of plural.

BREAKING CHANGE: `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`

fix #767

Signed-off-by: Tre' Seymour <[email protected]>
nickofthyme pushed a commit that referenced this issue Apr 2, 2021
@semantic-release-bot
chore(release): 28.0.0 [skip ci]
f1a4c4e 
# [28.0.0](v27.0.0...v28.0.0) (2021-04-02)

### Bug Fixes

* **annotations:** provide fallback for line annotation markers ([#1091](#1091)) ([0bd61f1](0bd61f1))
* **legend:** action sizing ui and focus states ([#1102](#1102)) ([3a76a2c](3a76a2c))
* **legend:** stop legend color picker dot twitching ([#1101](#1101)) ([c89b767](c89b767))

### Code Refactoring

* rename enum types to singular ([#1064](#1064)) ([396b3d1](396b3d1)), closes [#767](#767)

### BREAKING CHANGES

* `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 2, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 28.0.0 [skip ci]
9b6188b 
# [28.0.0](elastic/elastic-charts@v27.0.0...v28.0.0) (2021-04-02)

### Bug Fixes

* **annotations:** provide fallback for line annotation markers ([opensearch-project#1091](elastic/elastic-charts#1091)) ([d907c81](elastic/elastic-charts@d907c81))
* **legend:** action sizing ui and focus states ([opensearch-project#1102](elastic/elastic-charts#1102)) ([a58cc0a](elastic/elastic-charts@a58cc0a))
* **legend:** stop legend color picker dot twitching ([opensearch-project#1101](elastic/elastic-charts#1101)) ([f63bb3b](elastic/elastic-charts@f63bb3b))

### Code Refactoring

* rename enum types to singular ([opensearch-project#1064](elastic/elastic-charts#1064)) ([6e900e2](elastic/elastic-charts@6e900e2)), closes [opensearch-project#767](elastic/elastic-charts#767)

### BREAKING CHANGES

* `AnnotationDomainTypes`, `AnnotationTypes`, `SeriesTypes`, `ChartTypes`, and `SpecTypes` are renamed to `AnnotationDomainType`, `AnnotationType`, `SeriesType`, `ChartType`, and `SpecType`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
breaking change discuss To be discussed enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename enum types to singular elastic/elastic-charts
2 participants
@markov00 @nickofthyme