Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 146 #180

Merged
merged 9 commits into from
Nov 26, 2018
Merged

Revert 146 #180

merged 9 commits into from
Nov 26, 2018

Conversation

hunterowens
Copy link
Collaborator

This PR reverts all changes made in PR #146, so that we don't merge the milliseconds since epoch unix timestamp feature. This is paired with PR #179, which cherry-picked those changes. If we squash and merge this, we can cut version 0.2.1.

@hunterowens hunterowens added this to the 0.2.1 milestone Nov 25, 2018
thekaveman
thekaveman previously approved these changes Nov 25, 2018
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to re-introduce those typos, fixed.

@thekaveman thekaveman mentioned this pull request Nov 25, 2018
@hunterowens hunterowens merged commit 71c038e into 0.2.x Nov 26, 2018
@hunterowens hunterowens deleted the revert-146 branch November 26, 2018 17:29
thekaveman added a commit that referenced this pull request Dec 3, 2018
remove the GeoJSON Feature oneOf allowance for properties when we are setting
the required field. This makes the properties key itself required, and forces its
type to object.

ported from the #146/#179/#180 mess
hunterowens pushed a commit that referenced this pull request Dec 4, 2018
remove the GeoJSON Feature oneOf allowance for properties when we are setting
the required field. This makes the properties key itself required, and forces its
type to object.

ported from the #146/#179/#180 mess
hunterowens added a commit that referenced this pull request Dec 4, 2018
* 0.2.1: (61 commits)
  updating release notes for 0.2.x
  fix for required properties in generated schema
  add WIND as a dockless mobility provider (#185)
  add Spin as a dockless mobility provider (#184)
  Reverts PR #146, moving Timestamp change into future release (#180)
  wheels (#177)
  adding info about mailing list. (#175)
  Adding Release guidelines (#147)
  Update providers.csv (#174)
  Add `next` link requirement (#166)
  Add OAauth client_credentials auth guidelines section
  update JUMP provider URL (#164)
  allowing null for links.next (#162)
  Agency vs Provider Clarification. [#148] (#150)
  Add LADOT Guidelines for the Handling of MSP Data (#154)
  allowing for null links properties
  Suggestion: Add Clarification to Propulsion Types
  fix versions
  remove oneOf when required is being added
  regenerate the schemas
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants